Google Git
Sign in
chromium / devtools / devtools-frontend / 6c0b15e0dc4084a80679968d823ad88650c96a4a
commit6c0b15e0dc4084a80679968d823ad88650c96a4a[log] [tgz]
authorPaul Lewis <[email protected]>Thu Jul 30 10:09:43 2020
committerCommit Bot <[email protected]>Thu Jul 30 20:00:00 2020
treebce37bca432d334a9dccd77a8e4ceea6b105dec7
parentb975535cc31d273a2b101b76d29d38e8c0dc450f [diff]
Adds global list of files expected for the GRD

We've found that files missed from the GRD cause issues in Chromium,
since it looks to the GRD/pak in order to serve the DevTools frontend.
Standalone builds of the DevTools frontend (as well as using
--custom-devtools-frontend in Chromium) do not present with the issue,
since in those cases the files are loaded directly from disk (rather
than via the GRD/pak file).

This CL introduces two new lists: a global list of files required for
the Release build (is_debug=false) of Chromium, and a second list of
files required for the Debug build (is_debug=true). These lists are
cross-referenced to ensure no overlap, thus in Release we use the first
list, and in Debug we use both.

In the root BUILD.gn we now check that files that are inputted to the
GRD builder action map exactly to the list of files expected for the
GRD, and any mismatch causes a build failure.

[email protected]

DISABLE_THIRD_PARTY_CHECK=Adding owners and file at the same time

Change-Id: I5e215eb5dc249123ab07210baa3eeb00da225410
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2324586
Commit-Queue: Paul Lewis <[email protected]>
Reviewed-by: Daniel Clifford <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Reviewed-by: Paul Lewis <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
3 files changed
tree: bce37bca432d334a9dccd77a8e4ceea6b105dec7
  1. back_end/
  2. build_overrides/
  3. docs/
  4. front_end/
  5. node_modules/
  6. scripts/
  7. test/
  8. third_party/
  9. v8/
  10. .clang-format
  11. .editorconfig
  12. .eslintignore
  13. .eslintrc.js
  14. .gitattributes
  15. .gitignore
  16. .gn
  17. .npmignore
  18. .npmrc
  19. .style.yapf
  20. .stylelintignore
  21. .stylelintrc.json
  22. all_devtools_files.gni
  23. all_devtools_modules.gni
  24. AUTHORS
  25. BUILD.gn
  26. COMMON_OWNERS
  27. DEPS
  28. devtools_grd_files.gni
  29. devtools_image_files.gni
  30. devtools_module_entrypoints.gni
  31. ENG_REVIEW_OWNERS
  32. INFRA_OWNERS
  33. LICENSE
  34. LIGHTHOUSE_OWNERS
  35. OWNERS
  36. package-lock.json
  37. package.json
  38. PRESUBMIT.py
  39. protocol.json
  40. README.md
  41. tsconfig.base.json
  42. tsconfig.json
  43. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found here.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found here.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch