[GN] Fix missing/incorrect build dependencies for `meta` targets.
This was noticed with https://crrev.com/c/5210758 (and caused that
CL to be reverted): The `meta` targets only transitively depend on
their imports (most of the time), which means that if one of their
imports change, but this change does not cause the `bundle` target
on which the `meta` target depends to change its output, ninja will
not rebuild the `meta` output. This causes issues specifically with
changing `enum` to `const enum`, as the *-meta.ts files don't get
rebuild correctly.
Fixed: chromium:1520414
Also-by: [email protected]
Bug: b:319814509, chromium:1172300, chromium:1167717
Change-Id: I436b349f3d99051848c7e7dbf63b35b5926d1448
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5222500
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
diff --git a/front_end/panels/developer_resources/BUILD.gn b/front_end/panels/developer_resources/BUILD.gn
index 3ec6d24..096296e 100644
--- a/front_end/panels/developer_resources/BUILD.gn
+++ b/front_end/panels/developer_resources/BUILD.gn
@@ -52,7 +52,11 @@
devtools_entrypoint("meta") {
entrypoint = "developer_resources-meta.ts"
- deps = [ ":bundle" ]
+ deps = [
+ ":bundle",
+ "../../core/i18n:bundle",
+ "../../ui/legacy:bundle",
+ ]
visibility = [ "../../entrypoints/*" ]
}
