Check license headers for CSS files during PRESUBMIT
This mirrors the license header checks we perform for
Python-like files and apply the same logic for CSS.
To do so, we modify the relevant regexes and patch
function to use the correct version of comment structure
for CSS files (which use `/*` rather than `#` as delimiters).
[email protected]
Bug: 1106746
Change-Id: I51d51e9b793a1015aeb20a3b3a55e075c2ee748f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3014756
Commit-Queue: Tim van der Lippe <[email protected]>
Auto-Submit: Tim van der Lippe <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d9cf8c2..bcbf54b 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -324,14 +324,14 @@
return results
-def _CheckDevToolsPythonLikeFileLicenseHeaders(input_api, output_api):
+def _CheckDevToolsNonJSFileLicenseHeaders(input_api, output_api):
results = [
output_api.PresubmitNotifyResult(
'Python-like file license header check:')
]
- lint_path = input_api.os_path.join(
- input_api.PresubmitLocalPath(), 'scripts', 'test',
- 'run_header_check_python_like_files.js')
+ lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
+ 'scripts', 'test',
+ 'run_header_check_non_js_files.js')
front_end_directory = input_api.os_path.join(
input_api.PresubmitLocalPath(), 'front_end')
@@ -356,7 +356,7 @@
should_bail_out, files_to_lint = _getFilesToLint(
input_api, output_api, lint_config_files, default_linted_directories,
- ['BUILD.gn', '.gni'], results)
+ ['BUILD.gn', '.gni', '.css'], results)
if should_bail_out:
return results
@@ -516,8 +516,8 @@
results.extend(_CheckJSON(input_api, output_api))
results.extend(_CheckDevToolsStyleJS(input_api, output_api))
results.extend(_CheckDevToolsStyleCSS(input_api, output_api))
- results.extend(
- _CheckDevToolsPythonLikeFileLicenseHeaders(input_api, output_api))
+ results.extend(_CheckDevToolsNonJSFileLicenseHeaders(
+ input_api, output_api))
results.extend(_CheckFormat(input_api, output_api))
results.extend(_CheckChangesAreExclusiveToDirectory(input_api, output_api))
