| commit | b2e370509bf6ce159ac9ea48a72d66b4432a571b | [log] [tgz] |
|---|---|---|
| author | Danil Somsikov <[email protected]> | Fri Mar 24 12:50:43 2023 |
| committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 27 18:50:51 2023 |
| tree | fdc63cf9e12b580cc3636777fe97e69b8b679c21 | |
| parent | a09c4de27878ff6f526c3b78f53bf99e6495f1d3 [diff] [blame] |
Use built-in URL class instead of string comparison in file URL check. Bug: 1423258 Change-Id: Ie6ea865fbe363c138b372d45d98daf1db6434671 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4370246 Commit-Queue: Alex Gough <[email protected]> Reviewed-by: Alex Gough <[email protected]> Auto-Submit: Danil Somsikov <[email protected]>
diff --git a/front_end/models/extensions/ExtensionAPI.ts b/front_end/models/extensions/ExtensionAPI.ts index 0709c79..3e64773 100644 --- a/front_end/models/extensions/ExtensionAPI.ts +++ b/front_end/models/extensions/ExtensionAPI.ts
@@ -1210,7 +1210,11 @@ } function canAccessResource(resource: APIImpl.ResourceData): boolean { - return extensionInfo.allowFileAccess || !resource.url.toLowerCase().startsWith('file:'); + try { + return extensionInfo.allowFileAccess || (new URL(resource.url)).protocol !== 'file:'; + } catch (e) { + return false; + } } function InspectedWindow(this: PublicAPI.Chrome.DevTools.InspectedWindow): void {