use urllib.request.urlcleanup() in download_emscripten.py
ref: https://docs.python.org/3/library/urllib.request.html#urllib.request.urlcleanup
Fixed: 1280064
Change-Id: Id39085d6d0ba871dd840e1bc8d74b4e7a3495565
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3341215
Reviewed-by: Tim Van der Lippe <[email protected]>
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Auto-Submit: Takuto Ikuta <[email protected]>
diff --git a/scripts/deps/download_emscripten.py b/scripts/deps/download_emscripten.py
index 4b7feb4..43f7d72 100644
--- a/scripts/deps/download_emscripten.py
+++ b/scripts/deps/download_emscripten.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env vpython
+#!/usr/bin/env python3
#
# Copyright 2020 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
@@ -9,19 +9,14 @@
"""
import argparse
-import platform
import os
+import platform
import subprocess
import sys
import tarfile
-import tempfile
+import urllib.request
import zipfile
-if sys.version_info >= (3, ):
- from urllib.request import urlretrieve
-else:
- from urllib import urlretrieve
-
BS = 8192
STAMP_FILE = 'build-revision'
DOWNLOAD_URL = "https://storage.googleapis.com/webassembly/emscripten-releases-builds/%s/%s/wasm-binaries.%s"
@@ -68,7 +63,7 @@
'zip' if os_name == 'win' else 'tbz2')
try:
- filename, _ = urlretrieve(url)
+ filename, _ = urllib.request.urlretrieve(url)
unzip(os_name, filename, options.dest)
@@ -77,6 +72,8 @@
sys.stderr.write('Error Downloading URL "{url}": {e}\n'.format(url=url,
e=e))
return 1
+ finally:
+ urllib.request.urlcleanup()
if __name__ == '__main__':
