RPP: remove alternative navigations experiment
Note: we are not removing the functionality; this CL just removes the
experiment infra (as it has been enabled by default for ages).
Bug: 313757601
Change-Id: Ic40f2f0d3b3ce25209bd52f866b9e12d69c46f63
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6494856
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Changhao Han <[email protected]>
Commit-Queue: Changhao Han <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
diff --git a/front_end/core/host/UserMetrics.ts b/front_end/core/host/UserMetrics.ts
index 5f8f52a..f088341 100644
--- a/front_end/core/host/UserMetrics.ts
+++ b/front_end/core/host/UserMetrics.ts
@@ -969,7 +969,6 @@
'timeline-debug-mode' = 93,
'timeline-experimental-insights' = 102,
'timeline-dim-unrelated-events' = 103,
- 'timeline-alternative-navigation' = 104,
// 106 was historically used [https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6230097]
// next experiment should be 107
/* eslint-enable @typescript-eslint/naming-convention */
diff --git a/front_end/core/root/Runtime.ts b/front_end/core/root/Runtime.ts
index 1af2a81..b28b59b 100644
--- a/front_end/core/root/Runtime.ts
+++ b/front_end/core/root/Runtime.ts
@@ -321,7 +321,6 @@
TIMELINE_COMPILED_SOURCES = 'timeline-compiled-sources',
TIMELINE_EXPERIMENTAL_INSIGHTS = 'timeline-experimental-insights',
TIMELINE_DIM_UNRELATED_EVENTS = 'timeline-dim-unrelated-events',
- TIMELINE_ALTERNATIVE_NAVIGATION = 'timeline-alternative-navigation',
// when adding to this enum, you'll need to also add to REGISTERED_EXPERIMENTS in EnvironmentHelpers.ts
}
diff --git a/front_end/entrypoints/main/MainImpl.ts b/front_end/entrypoints/main/MainImpl.ts
index b206ac5..20ffe01 100644
--- a/front_end/entrypoints/main/MainImpl.ts
+++ b/front_end/entrypoints/main/MainImpl.ts
@@ -369,14 +369,8 @@
'Performance panel: enable dimming unrelated events in performance insights and search results',
);
- Root.Runtime.experiments.register(
- Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
- 'Performance panel: enable a switch to an alternative timeline navigation option',
- );
-
Root.Runtime.experiments.enableExperimentsByDefault([
Root.Runtime.ExperimentName.NETWORK_PANEL_FILTER_BAR_REDESIGN,
- Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,
Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,
Root.Runtime.ExperimentName.HIGHLIGHT_ERRORS_ELEMENTS_PANEL,
diff --git a/front_end/panels/timeline/TimelinePanel.ts b/front_end/panels/timeline/TimelinePanel.ts
index 2910ba1..51311e3 100644
--- a/front_end/panels/timeline/TimelinePanel.ts
+++ b/front_end/panels/timeline/TimelinePanel.ts
@@ -2120,8 +2120,7 @@
// When the timeline is loaded for the first time, setup the shortcuts dialog and log what navigation setting is selected.
// Logging the setting on the first timeline load will allow us to get an estimate number of people using each option.
- if (this.#traceEngineModel.size() === 1 &&
- Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION)) {
+ if (this.#traceEngineModel.size() === 1) {
this.#setupNavigationSetting();
if (Common.Settings.moduleSetting('flamechart-selected-navigation').get() === 'classic') {
Host.userMetrics.navigationSettingAtFirstTimelineLoad(
diff --git a/front_end/testing/EnvironmentHelpers.ts b/front_end/testing/EnvironmentHelpers.ts
index ec672ba..7bb7477 100644
--- a/front_end/testing/EnvironmentHelpers.ts
+++ b/front_end/testing/EnvironmentHelpers.ts
@@ -127,7 +127,6 @@
Root.Runtime.ExperimentName.TIMELINE_ENHANCED_TRACES,
Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,
- Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
];
export async function initializeGlobalVars({reset = true} = {}) {
@@ -302,6 +301,9 @@
Common.Settings.SettingType.BOOLEAN),
createSettingValue(
Common.Settings.SettingCategory.APPEARANCE, 'chrome-theme-colors', true, Common.Settings.SettingType.BOOLEAN),
+ createSettingValue(
+ Common.Settings.SettingCategory.PERFORMANCE, 'timeline.user-had-shortcuts-dialog-opened-once', false,
+ Common.Settings.SettingType.BOOLEAN),
];
Common.Settings.registerSettingsForTest(settings, reset);
diff --git a/front_end/ui/components/docs/performance_panel/basic.ts b/front_end/ui/components/docs/performance_panel/basic.ts
index b8fbc53..1058f63 100644
--- a/front_end/ui/components/docs/performance_panel/basic.ts
+++ b/front_end/ui/components/docs/performance_panel/basic.ts
@@ -94,6 +94,7 @@
const actionRegistry = UI.ActionRegistry.ActionRegistry.instance();
UI.ShortcutRegistry.ShortcutRegistry.instance({forceNew: true, actionRegistry});
Common.Settings.settingForTest('flamechart-selected-navigation').set('classic');
+Common.Settings.settingForTest('timeline.user-had-shortcuts-dialog-opened-once').set(true);
const params = new URLSearchParams(window.location.search);
const traceFileName = params.get('trace');
const cpuprofileName = params.get('cpuprofile');
diff --git a/test/interactions/goldens/linux/performance/bottomUp.png b/test/interactions/goldens/linux/performance/bottomUp.png
index 18458d5..d954209 100644
--- a/test/interactions/goldens/linux/performance/bottomUp.png
+++ b/test/interactions/goldens/linux/performance/bottomUp.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/callTree.png b/test/interactions/goldens/linux/performance/callTree.png
index 6fcd500..505b88b 100644
--- a/test/interactions/goldens/linux/performance/callTree.png
+++ b/test/interactions/goldens/linux/performance/callTree.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/cpu-profile-node.png b/test/interactions/goldens/linux/performance/cpu-profile-node.png
index 30f518e..3c105ae 100644
--- a/test/interactions/goldens/linux/performance/cpu-profile-node.png
+++ b/test/interactions/goldens/linux/performance/cpu-profile-node.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/cpu-profile.png b/test/interactions/goldens/linux/performance/cpu-profile.png
index f6d5296..3bc2fcf 100644
--- a/test/interactions/goldens/linux/performance/cpu-profile.png
+++ b/test/interactions/goldens/linux/performance/cpu-profile.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/main-thread-long-task-candy-stripe.png b/test/interactions/goldens/linux/performance/main-thread-long-task-candy-stripe.png
index 39057a9..295ac8f 100644
--- a/test/interactions/goldens/linux/performance/main-thread-long-task-candy-stripe.png
+++ b/test/interactions/goldens/linux/performance/main-thread-long-task-candy-stripe.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/timeline-before-extension-toggle.png b/test/interactions/goldens/linux/performance/timeline-before-extension-toggle.png
index d132855..7e53d95 100644
--- a/test/interactions/goldens/linux/performance/timeline-before-extension-toggle.png
+++ b/test/interactions/goldens/linux/performance/timeline-before-extension-toggle.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/timeline-long-task-candystripe.png b/test/interactions/goldens/linux/performance/timeline-long-task-candystripe.png
index 39057a9..295ac8f 100644
--- a/test/interactions/goldens/linux/performance/timeline-long-task-candystripe.png
+++ b/test/interactions/goldens/linux/performance/timeline-long-task-candystripe.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/timeline-web-dev-screenshot-frames.png b/test/interactions/goldens/linux/performance/timeline-web-dev-screenshot-frames.png
index bfc4ac6..ac7529a 100644
--- a/test/interactions/goldens/linux/performance/timeline-web-dev-screenshot-frames.png
+++ b/test/interactions/goldens/linux/performance/timeline-web-dev-screenshot-frames.png
Binary files differ
diff --git a/test/interactions/goldens/linux/performance/timeline.png b/test/interactions/goldens/linux/performance/timeline.png
index 79fdfdd..d25a56e 100644
--- a/test/interactions/goldens/linux/performance/timeline.png
+++ b/test/interactions/goldens/linux/performance/timeline.png
Binary files differ
