Google Git
Sign in
chromium / devtools / devtools-frontend / f8c26e2f7648660f18ea1892b4203a0f0ebc58a5
commitf8c26e2f7648660f18ea1892b4203a0f0ebc58a5[log] [tgz]
authorTim van der Lippe <[email protected]>Wed Nov 03 11:46:58 2021
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 03 12:18:51 2021
tree0071de07e43356d15223bd2b01a45b0ee4a563e5
parent5d36df62d3117458accbae1fa7fa4ee02160caf7 [diff]
Use observer for obtaining target in CSSOverview

By removing the module.json file (and the corresponding promise to load
it in `css_overview-meta.ts`), the timing for the panel changed. As
such, it executes its constructor earlier than before. Normally, this
isn't a problem, but in this case, the constructor was requesting the
main target from the TargetManager. With the new timing, the main target
isn't ready yet.

Instead, we should be using the TargetObserver to obtain the correct
target when it is ready. We can then propagate the relevant models to
the other views, which will use it when rendering. Since these views
render at a later stage, the models will be available in time.

[email protected]

Fixed: 1266287
Change-Id: I83d8308576b72fb8566e401be81771c7c9ae4dd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259087
Commit-Queue: Tim van der Lippe <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Tim van der Lippe <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
2 files changed
tree: 0071de07e43356d15223bd2b01a45b0ee4a563e5
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. ARCHITECTURE.md
  27. AUTHORS
  28. BUILD.gn
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch