Cleanups and simplifications to code, noticed by inspection. NFC.
--
PiperOrigin-RevId: 247758075
diff --git a/mlir/lib/Transforms/LoopInvariantCodeMotion.cpp b/mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
index b03a3c7..2f95db9 100644
--- a/mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
+++ b/mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
@@ -19,9 +19,6 @@
//
//===----------------------------------------------------------------------===//
-#include <iomanip>
-#include <sstream>
-
#include "mlir/AffineOps/AffineOps.h"
#include "mlir/Analysis/AffineAnalysis.h"
#include "mlir/Analysis/AffineStructures.h"
@@ -57,7 +54,6 @@
struct LoopInvariantCodeMotion : public FunctionPass<LoopInvariantCodeMotion> {
void runOnFunction() override;
void runOnAffineForOp(AffineForOp forOp);
- std::vector<AffineForOp> forOps;
};
} // end anonymous namespace
@@ -81,7 +77,7 @@
LLVM_DEBUG(for (auto i
: loopDefinedOps) {
- (i->print(llvm::dbgs() << "\nLoop-dependent op\n"));
+ i->print(llvm::dbgs() << "\nLoop-dependent op\n");
});
for (auto &op : *loopBody) {
@@ -109,20 +105,14 @@
}
void LoopInvariantCodeMotion::runOnFunction() {
- forOps.clear();
- // Gather all loops in a function, and order them in innermost-loop-first
- // order. This way, we first LICM from the inner loop, and place the ops in
- // the outer loop, which in turn can be further LICM'ed. This saves iterating
- // on the inner loop operations while LICMing through the outer loop.
- getFunction().walk<AffineForOp>(
- [&](AffineForOp forOp) { forOps.push_back(forOp); });
- // We gather loops first, and then go over them later because we don't want to
- // mess the iterators up.
- for (auto op : forOps) {
+ // Walk through all loops in a function in innermost-loop-first order. This
+ // way, we first LICM from the inner loop, and place the ops in
+ // the outer loop, which in turn can be further LICM'ed.
+ getFunction().walk<AffineForOp>([&](AffineForOp op) {
LLVM_DEBUG(op.getOperation()->print(llvm::dbgs() << "\nOriginal loop\n"));
runOnAffineForOp(op);
- }
+ });
}
static PassRegistration<LoopInvariantCodeMotion>
