commit 1d6d1b44cccd94ee74e1e87726e03eafa4496660
author Rafael Espindola <rafael.espindola@gmail.com> Tue Jan 17 16:08:06 2017
committer Rafael Espindola <rafael.espindola@gmail.com> Tue Jan 17 16:08:06 2017
tree b7d3e53a0531f4e3e27dc64c0825b2f4d90360ee
parent c39f5491a4d4c671af3d3960a4e476b8c666e46a

Add a isInCurrentDSO helper. NFC.

llvm-svn: 292228

lld/ELF/Symbols.cpp

diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index 7c2b5fb..0fe42be 100644
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -203,8 +203,8 @@
   // Truncate the symbol name so that it doesn't include the version string.
   Name = {S.data(), Pos};
 
-  // If this is an undefined or shared symbol it is not a definition.
-  if (isUndefined() || isShared())
+  // If this is not in this DSO, it is not a definition.
+  if (!isInCurrentDSO())
     return;
 
   // '@@' in a symbol name means the default version.
@@ -300,7 +300,7 @@
   if (Visibility != STV_DEFAULT && Visibility != STV_PROTECTED)
     return STB_LOCAL;
   const SymbolBody *Body = body();
-  if (VersionId == VER_NDX_LOCAL && !Body->isUndefined() && !Body->isShared())
+  if (VersionId == VER_NDX_LOCAL && Body->isInCurrentDSO())
     return STB_LOCAL;
   if (Config->NoGnuUnique && Binding == STB_GNU_UNIQUE)
     return STB_GLOBAL;