commit 750cd1755dd32f47cb5e00f23ef9b2feb2cde450
author Caroline Tice <ctice@apple.com> Tue Oct 26 23:49:36 2010
committer Caroline Tice <ctice@apple.com> Tue Oct 26 23:49:36 2010
tree 181307a37ae79f4d1e4f1ec5a46e61a469943d7a
parent 19ead876d257159c2019cae80456e158be3accef

Clean up the API logging code:
      - Try to reduce logging to one line per function call instead of tw
      - Put all arguments & their values into log for calls
      - Add 'this' parameter information to function call logging, making it show the appropriate
        internal pointer (this.obj, this.sp, this.ap...)
      - Clean up some return values
      - Remove logging of constructors that construct empty objects
      - Change '==>' to '=>'  for showing result values...
      - Fix various minor bugs
      - Add some protected 'get' functions to help getting the internal pointers for the 'this' arguments...      

llvm-svn: 117417

lldb/source/API/SBSymbol.cpp

diff --git a/lldb/source/API/SBSymbol.cpp b/lldb/source/API/SBSymbol.cpp
index a3dc218..c8bbdc6 100644
--- a/lldb/source/API/SBSymbol.cpp
+++ b/lldb/source/API/SBSymbol.cpp
@@ -22,23 +22,20 @@
 SBSymbol::SBSymbol () :
     m_opaque_ptr (NULL)
 {
-    Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API | LIBLLDB_LOG_VERBOSE);
-
-    if (log)
-        log->Printf ("SBSymbol::SBSymbol () ==> this = %p", this);
 }
 
 SBSymbol::SBSymbol (lldb_private::Symbol *lldb_object_ptr) :
     m_opaque_ptr (lldb_object_ptr)
 {
-    Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API | LIBLLDB_LOG_VERBOSE);
+    Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API);
 
     if (log)
     {
         SBStream sstr;
         GetDescription (sstr);
-        log->Printf ("SBSymbol::SBSymbol (lldb_private::Symbol *lldb_object_ptr) lldb_object_ptr = %p ==> "
-                     "this = %p (%s)", lldb_object_ptr, this, sstr.GetData());
+        log->Printf ("SBSymbol::SBSymbol (lldb_object_ptr=%p) => this.obj = %p (%s)", lldb_object_ptr, m_opaque_ptr, 
+                     sstr.GetData());
+                     
     }
 }
 
@@ -58,18 +55,20 @@
 {
     Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API);
 
-    if (log)
-        log->Printf ("SBSymbol::GetName ()");
+    //if (log)
+    //    log->Printf ("SBSymbol::GetName ()");
 
     if (m_opaque_ptr)
     {
         if (log)
-            log->Printf ("SBSymbol::GetName ==> %s", m_opaque_ptr->GetMangled().GetName().AsCString());
+            log->Printf ("SBSymbol::GetName (this.obj=%p) => '%s'", m_opaque_ptr, 
+                         m_opaque_ptr->GetMangled().GetName().AsCString());
+
         return m_opaque_ptr->GetMangled().GetName().AsCString();
     }
     
     if (log)
-        log->Printf ("SBSymbol::GetName ==> NULL");
+        log->Printf ("SBSymbol::GetName (this.obj=%p) => NULL", m_opaque_ptr);
 
     return NULL;
 }
@@ -136,3 +135,8 @@
     return sb_instructions;
 }
 
+lldb_private::Symbol *
+SBSymbol::get ()
+{
+    return m_opaque_ptr;
+}