commit | 859e6aa1008b80d9b10657bac37822a32ee14a23 | [log] [tgz] |
---|---|---|
author | Mohammed Keyvanzadeh <[email protected]> | Tue Sep 12 22:21:47 2023 |
committer | GitHub <[email protected]> | Tue Sep 12 22:21:47 2023 |
tree | 1149353840df9d6d3a85fd87a461381868de13fc | |
parent | d78ca7324c88a2658492f722222cc8c1eb4ace71 [diff] [blame] |
[github] GitHub Actions workflows changes (#65856) - Remove usages of the non-existent `ignore-forks` field, conditions in jobs already exist to prevent the jobs from running in forks. - Don't use variables in the `printf` format string. Use `printf "..%s.." "$foo"`. ([SC2059](https://www.shellcheck.net/wiki/SC2059)) - Double quote variable expansion to prevent globbing and word splitting. ([SC2086](https://www.shellcheck.net/wiki/SC2086)) - Prefer `[ p ] || [ q ]` as `[ p -o q ]` is not well defined. ([SC2166](https://www.shellcheck.net/wiki/SC2166)) - Consider `{ cmd1; cmd2; } >> file` instead of individual redirects. ([SC2129](https://www.shellcheck.net/wiki/SC2129)) - Use `$(...)` notation instead of legacy notation `...`. ([SC2006](https://www.shellcheck.net/wiki/SC2006)) - Use `./*glob*` or `-- *glob*` so names with dashes won't become options. ([SC2035](https://www.shellcheck.net/wiki/SC2035)) - Refactor JavaScript code in certain workflows. - Change workflow variable substitution style of some workflows to be consistent with others.
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml index a4d4dd8..bd6d09c 100644 --- a/.github/workflows/issue-release-workflow.yml +++ b/.github/workflows/issue-release-workflow.yml
@@ -55,9 +55,9 @@ - name: Backport Commits run: | - printf "$COMMENT_BODY" | + printf "%s" "$COMMENT_BODY" | ./llvm/utils/git/github-automation.py \ - --repo $GITHUB_REPOSITORY \ + --repo "$GITHUB_REPOSITORY" \ --token ${{ secrets.RELEASE_WORKFLOW_PUSH_SECRET }} \ release-workflow \ --issue-number ${{ github.event.issue.number }} \ @@ -84,9 +84,9 @@ - name: Create Pull Request run: | - printf "$COMMENT_BODY" | + printf "%s" "$COMMENT_BODY" | ./llvm/utils/git/github-automation.py \ - --repo $GITHUB_REPOSITORY \ + --repo "$GITHUB_REPOSITORY" \ --token ${{ secrets.RELEASE_WORKFLOW_PUSH_SECRET }} \ release-workflow \ --issue-number ${{ github.event.issue.number }} \