commit b07ef4d566c702ff5d71a8e6b1274a7b3c47eb4c
author Fangrui Song <i@maskray.me> Mon Feb 28 18:25:21 2022
committer Fangrui Song <i@maskray.me> Mon Feb 28 18:25:21 2022
tree 0a845bcd8599c283f9a5618b2719f40ade531e82
parent 3906ebf750b80e36c2d6c52130cf40771e1b55fb

[ELF] Rename Symbol::compare to shouldReplace. NFC

The return value is not a boolean instead of a tri-state.
Suggested by Peter Smith in D120640.

lld/ELF/Symbols.cpp

diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index 484ad8e..8b74725 100644
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -508,7 +508,7 @@
 }
 
 // Compare two symbols. Return true if the new symbol should win.
-bool Symbol::compare(const Defined &other) const {
+bool Symbol::shouldReplace(const Defined &other) const {
   if (LLVM_UNLIKELY(isCommon())) {
     if (config->warnCommon)
       warn("common " + getName() + " is overridden");
@@ -605,7 +605,7 @@
 }
 
 void Symbol::resolveDefined(const Defined &other) {
-  if (compare(other))
+  if (shouldReplace(other))
     replace(other);
 }