commit 09d2db4e963c6696f7c22386b6791e419ad75cfb
author Simonas Kazlauskas <git@kazlauskas.me> Tue Mar 06 18:27:19 2018
committer Simonas Kazlauskas <git@kazlauskas.me> Tue May 01 07:44:44 2018
tree face2460d8fc7b217c6ce884bfd639a1711cb58a
parent 5b800c231f45fcd823a3e958bb942cd620ceb3e0

Rework force-frame-pointer

This reworks the force-frame-pointer PR to explicitly only consider the
value of the flag if it is provided, and use a target default otherwise.

Something that was tried but not kept was renaming the flag to
`frame-pointer`, because for flag `frame-pointer=no`, there is no
guarante, that LLVM will elide *all* the frame pointers; oposite of what
the literal reading of the flag would suggest.

src/librustc/session/config.rs

diff --git a/src/librustc/session/config.rs b/src/librustc/session/config.rs
index 023be78..59b40e9 100644
--- a/src/librustc/session/config.rs
+++ b/src/librustc/session/config.rs
@@ -1053,8 +1053,8 @@
          2 = full debug info with variable and type information"),
     opt_level: Option<String> = (None, parse_opt_string, [TRACKED],
         "optimize with possible levels 0-3, s, or z"),
-    force_frame_pointers: bool = (false, parse_bool, [TRACKED],
-        "force frame pointers to be used"),
+    force_frame_pointers: Option<bool> = (None, parse_opt_bool, [TRACKED],
+        "force use of the frame pointers"),
     debug_assertions: Option<bool> = (None, parse_opt_bool, [TRACKED],
         "explicitly enable the cfg(debug_assertions) directive"),
     inline_threshold: Option<usize> = (None, parse_opt_uint, [TRACKED],
@@ -2968,7 +2968,7 @@
         assert!(reference.dep_tracking_hash() != opts.dep_tracking_hash());
 
         opts = reference.clone();
-        opts.cg.force_frame_pointers = true;
+        opts.cg.force_frame_pointers = Some(false);
         assert!(reference.dep_tracking_hash() != opts.dep_tracking_hash());
 
         opts = reference.clone();

src/librustc/session/mod.rs

diff --git a/src/librustc/session/mod.rs b/src/librustc/session/mod.rs
index 45b7e2d..2ab72ba 100644
--- a/src/librustc/session/mod.rs
+++ b/src/librustc/session/mod.rs
@@ -658,8 +658,11 @@
     }
 
     pub fn must_not_eliminate_frame_pointers(&self) -> bool {
-        self.opts.debuginfo != DebugInfoLevel::NoDebugInfo
-            || !self.target.target.options.eliminate_frame_pointer
+        if let Some(x) = self.opts.cg.force_frame_pointers {
+            x
+        } else {
+            !self.target.target.options.eliminate_frame_pointer
+        }
     }
 
     /// Returns the symbol name for the registrar function,

src/test/codegen/force-frame-pointers.rs

diff --git a/src/test/codegen/force-frame-pointers.rs b/src/test/codegen/force-frame-pointers.rs
index d40406a..f70e366 100644
--- a/src/test/codegen/force-frame-pointers.rs
+++ b/src/test/codegen/force-frame-pointers.rs
@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 //
-// compile-flags: -C no-prepopulate-passes -C force-frame-pointers
+// compile-flags: -C no-prepopulate-passes -C force-frame-pointers=y
 
 #![crate_type="lib"]