Fixed #12901. Again. Model validation will not be performed on excluded fields that were overridden in the form. Thanks, ammarr.

jkocherhans · jkocherhans · commit e488c1dc0d29 · 2010-02-25T17:18:27.000Z
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12590 bcc190cf-cafb-0310-a4f2-bffc1f526a37
diff --git a/django/forms/models.py b/django/forms/models.py
@@ -280,6 +280,8 @@ def _get_validation_exclusions(self):
             # class. See #12901.
             elif self._meta.fields and field not in self._meta.fields:
                 exclude.append(f.name)
+            elif self._meta.exclude and field in self._meta.exclude:
+                exclude.append(f.name)
 
             # Exclude fields that failed form validation. There's no need for
             # the model fields to validate them as well.
diff --git a/tests/modeltests/model_forms/tests.py b/tests/modeltests/model_forms/tests.py
@@ -3,7 +3,7 @@
 from models import Category
 
 
-class IncompleteCategoryForm(forms.ModelForm):
+class IncompleteCategoryFormWithFields(forms.ModelForm):
     """
     A form that replaces the model's url field with a custom one. This should
     prevent the model field's validation from being called.
@@ -14,8 +14,24 @@ class Meta:
         fields = ('name', 'slug')
         model = Category
 
+class IncompleteCategoryFormWithExclude(forms.ModelForm):
+    """
+    A form that replaces the model's url field with a custom one. This should
+    prevent the model field's validation from being called.
+    """
+    url = forms.CharField(required=False)
+
+    class Meta:
+        exclude = ['url']
+        model = Category
+
+
 class ValidationTest(TestCase):
-    def test_validates_with_replaced_field(self):
-        form = IncompleteCategoryForm(data={'name': 'some name', 'slug': 'some-slug'})
+    def test_validates_with_replaced_field_not_specified(self):
+        form = IncompleteCategoryFormWithFields(data={'name': 'some name', 'slug': 'some-slug'})
+        assert form.is_valid()
+
+    def test_validates_with_replaced_field_excluded(self):
+        form = IncompleteCategoryFormWithExclude(data={'name': 'some name', 'slug': 'some-slug'})
         assert form.is_valid()
 
