[1.1.X] Fixed #13259 -- Ensure that multiple calls to message() don't corrupt any extra message headers. Thanks to canburak for the report, and Andi Albrecht for the fix.

freakboy3742 · freakboy3742 · commit 33052458c579 · 2010-04-01T15:25:54.000Z
Backport of r12901 from trunk. git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.1.X@12902 bcc190cf-cafb-0310-a4f2-bffc1f526a37
diff --git a/django/core/mail.py b/django/core/mail.py
@@ -249,7 +249,7 @@ def message(self):
                            self.content_subtype, encoding)
         msg = self._create_message(msg)
         msg['Subject'] = self.subject
-        msg['From'] = self.extra_headers.pop('From', self.from_email)
+        msg['From'] = self.extra_headers.get('From', self.from_email)
         msg['To'] = ', '.join(self.to)
 
         # Email header names are case-insensitive (RFC 2045), so we have to
@@ -260,6 +260,8 @@ def message(self):
         if 'message-id' not in header_names:
             msg['Message-ID'] = make_msgid()
         for name, value in self.extra_headers.items():
+            if name.lower() == 'from':
+                continue
             msg[name] = value
         return msg
 
diff --git a/tests/regressiontests/mail/tests.py b/tests/regressiontests/mail/tests.py
@@ -95,6 +95,16 @@
 >>> message['From']
 'from@example.com'
 
+# Regression for #13259 - Make sure that headers are not changed
+# when calling EmailMessage.message()
+>>> email = EmailMessage('Subject', 'Content', 'bounce@example.com', ['to@example.com'], headers={'From': 'from@example.com'})
+>>> message = email.message()
+>>> message['From']
+'from@example.com'
+>>> message = email.message()
+>>> message['From']
+'from@example.com'
+
 # Regression for #11144 - When a to/from/cc header contains unicode,
 # make sure the email addresses are parsed correctly (especially
 # with regards to commas)
