Skip to content

Commit 271e108

Browse files
David-Wobrockfelixxm
authored andcommitted
Refs #31318 -- Optimized sqlmigrate by using MigrationLoader.
Only loader from MigrationExecutor was used.
1 parent 71c1b7f commit 271e108

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

django/core/management/commands/sqlmigrate.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
from django.apps import apps
22
from django.core.management.base import BaseCommand, CommandError
33
from django.db import DEFAULT_DB_ALIAS, connections
4-
from django.db.migrations.executor import MigrationExecutor
5-
from django.db.migrations.loader import AmbiguityError
4+
from django.db.migrations.loader import AmbiguityError, MigrationLoader
65

76

87
class Command(BaseCommand):
@@ -33,8 +32,8 @@ def handle(self, *args, **options):
3332
# Get the database we're operating from
3433
connection = connections[options['database']]
3534

36-
# Load up an executor to get all the migration data
37-
executor = MigrationExecutor(connection)
35+
# Load up an loader to get all the migration data
36+
loader = MigrationLoader(connection)
3837

3938
# Resolve command-line arguments into a migration
4039
app_label, migration_name = options['app_label'], options['migration_name']
@@ -43,10 +42,10 @@ def handle(self, *args, **options):
4342
apps.get_app_config(app_label)
4443
except LookupError as err:
4544
raise CommandError(str(err))
46-
if app_label not in executor.loader.migrated_apps:
45+
if app_label not in loader.migrated_apps:
4746
raise CommandError("App '%s' does not have migrations" % app_label)
4847
try:
49-
migration = executor.loader.get_migration_by_prefix(app_label, migration_name)
48+
migration = loader.get_migration_by_prefix(app_label, migration_name)
5049
except AmbiguityError:
5150
raise CommandError("More than one migration matches '%s' in app '%s'. Please be more specific." % (
5251
migration_name, app_label))
@@ -61,8 +60,8 @@ def handle(self, *args, **options):
6160

6261
# Make a plan that represents just the requested migrations and show SQL
6362
# for it
64-
plan = [(executor.loader.graph.nodes[target], options['backwards'])]
65-
sql_statements = executor.loader.collect_sql(plan)
63+
plan = [(loader.graph.nodes[target], options['backwards'])]
64+
sql_statements = loader.collect_sql(plan)
6665
if not sql_statements and options['verbosity'] >= 1:
6766
self.stderr.write('No operations found.')
6867
return '\n'.join(sql_statements)

0 commit comments

Comments
 (0)