Timeline



Oct 4, 2010:

10:52 PM Ticket #14391 (Core (Management commands) - update man django-admin.1 to include missing commands) updated by laurentluce
Triage Stage changed
Accepted after feedback from Russell.
10:49 PM reset_sqlreset_warnings.2.diff attached to Ticket #14268 by laurentluce
10:49 PM reset_sqlreset_warnings.diff attached to Ticket #14268 by laurentluce
10:45 PM Ticket #14268 (Core (Management commands) - reset and sqlreset management commands should raise ...) updated by laurentluce
Has patch changed
10:45 PM Ticket #14268 (Core (Management commands) - reset and sqlreset management commands should raise ...) updated by laurentluce
Status changed
- added PendingDeprecationWarning to reset command in …
10:41 PM Ticket #14268 (Core (Management commands) - reset and sqlreset management commands should raise ...) updated by laurentluce
Owner changed
10:41 PM Ticket #14391 (Core (Management commands) - update man django-admin.1 to include missing commands) updated by laurentluce
Status changed
10:41 PM Ticket #14391 (Core (Management commands) - update man django-admin.1 to include missing commands) created by laurentluce
10:02 PM Ticket #13870 (Documentation - Document transaction/connection management outside the web server context) updated by davidr
I ran into to this problem from Django 1.0 and ended up using the …
8:44 PM Ticket #14388 (Documentation - Logging documentation typos) updated by Russell Keith-Magee
(In [13984]) Refs #14388 -- ... and corrected the naming of a …
8:44 PM Changeset [63d960ca]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Russell Keith-Magee <russell@…>
Refs #14388 -- ... and corrected the naming of a formatter in the …
8:42 PM Ticket #14388 (Documentation - Logging documentation typos) updated by Russell Keith-Magee
(In [13983]) Refs #14388 -- Corrected another spelling erorr.
8:42 PM Changeset [9e153a3]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Russell Keith-Magee <russell@…>
Refs #14388 -- Corrected another spelling erorr. git-svn-id: …
7:56 PM Ticket #2407 (Core (Other) - CGI Support for django) closed by Russell Keith-Magee
wontfix: Django doesn't support CGI for deployment, and Trac isn't a user …
7:55 PM Ticket #2407 (Core (Other) - CGI Support for django) reopened by DremLIN
Hello, In my hosting, I have: Python 2.3 run with Apache 1.3 as CGI. …
7:47 PM Ticket #14023 (Documentation - Better example for the custom form template) updated by Tim Graham
Triage Stage changed
7:44 PM Ticket #14384 (Documentation - Installation documentation should avoid sys.path.append) updated by Tim Graham
Triage Stage changed
7:36 PM Reports edited by Russell Keith-Magee
Corrected the link for DDN tickets (diff)
7:15 PM Ticket #13914 (contrib.auth - Add natural keys to contrib.auth.User and Group models) updated by Paul McMillan
Needs documentation, Needs tests changed
At the very least this patch still needs tests and documentation …
7:11 PM Ticket #14388 (Documentation - Logging documentation typos) closed by Russell Keith-Magee
fixed: (In [13982]) Fixed #14388 -- Corrected some typos in the logging docs. …
7:11 PM Changeset [240f68e]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Russell Keith-Magee <russell@…>
Fixed #14388 -- Corrected some typos in the logging docs. Thanks to …
6:26 PM Ticket #14390 (contrib.auth - set_password functionality outside of the User model) updated by Łukasz Rekucki
Actually, you can... in Python 3. Sorry for the confusion.
5:44 PM Ticket #14390 (contrib.auth - set_password functionality outside of the User model) reopened by Alex Gaynor
No, you really can't use that: […]
5:04 PM Ticket #14390 (contrib.auth - set_password functionality outside of the User model) closed by Łukasz Rekucki
worksforme: You don't have to create a User model. If your custom model also has a …
4:51 PM Ticket #13795 (Core (Cache system) - Add CACHE_KEY_PREFIX setting that prefixes the low-level cache API) updated by Austin Gabel
Patch needs improvement, Milestone changed
My last patch had a few problems with file based caching. The latest …
4:49 PM cache_key_prefix_13891.diff attached to Ticket #13795 by Austin Gabel
4:48 PM Ticket #14346 (HTTP handling - Url patterns double slash // problem) closed by dan_head
invalid: I've seen this before and it's usually an Apace/mod_rewrite issue. …
4:10 PM Ticket #10944 (contrib.sites - Site app should be able to make absolute URLs.) updated by laurentluce
Needs documentation, Has patch changed
- add method get_url to Site model to return an absolute url based on …
4:09 PM site_url.diff attached to Ticket #10944 by laurentluce
get_url Site model method and site_url template tage
4:08 PM Ticket #10944 (contrib.sites - Site app should be able to make absolute URLs.) updated by laurentluce
Status changed
4:08 PM Ticket #10944 (contrib.sites - Site app should be able to make absolute URLs.) updated by laurentluce
Owner, Status changed
4:07 PM Ticket #10944 (contrib.sites - Site app should be able to make absolute URLs.) updated by anonymous
Status, Owner changed
3:29 PM Ticket #10944 (contrib.sites - Site app should be able to make absolute URLs.) updated by anonymous
Owner changed
3:10 PM ClassBasedViews edited by Luke Plant
(diff)
2:05 PM Ticket #14388 (Documentation - Logging documentation typos) updated by Gabriel Hurley
Triage Stage, Milestone changed
Added one tiny typo cleanup, otherwise patch looks good to me. Marking RFC.
2:03 PM 14388_2.patch attached to Ticket #14388 by Gabriel Hurley
Corrected "a Error" -> "an Error", otherwise same patch.
1:54 PM ClassBasedViews edited by Luke Plant
(diff)
1:53 PM Ticket #14386 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) updated by Gabriel Hurley
Thanks for the final cleanup (and commit) on the patch, Luke. The …
1:35 PM 14388.patch attached to Ticket #14388 by Ramiro Morales
Patch for the reported typos and a couple more
1:32 PM Ticket #14388 (Documentation - Logging documentation typos) updated by Ramiro Morales
Has patch changed
1:29 PM Ticket #14390 (contrib.auth - set_password functionality outside of the User model) created by kent@…
Today I wanted to use a hashed, salted password in a custom model. …
12:27 PM Ticket #13877 (Core (Other) - More documentation needed on exceptions in middlewares) updated by pascal chambon
I guess the whole middleware processing should be protected by …
11:53 AM CaseStudyLeads edited by Derek Willis
added USAT, WashPost info (diff)
11:51 AM Ticket #14388 (Documentation - Logging documentation typos) updated by Brian Neal
Summary changed
11:50 AM Ticket #14388 (Documentation - Logging documentation typos) updated by Brian Neal
Also: * "A logger is configured to have log level" should …
11:44 AM Ticket #13965 (Internationalization - psycopg2 throws an "can't adapt" error on ugettext_lazy translated strings) updated by Mitar
Hm, but in this case this is not a silent data loss because it is …
11:13 AM Ticket #14389 (Template system - Future url replacement) created by Sean Brant
As previously discussed in #7917 context variables inside {% url %} do …
11:11 AM Ticket #14388 (Documentation - Logging documentation typos) created by John Shimek
The new logging documentation has a typo with the word ERRORR: …
10:57 AM DjangoWarts created by Luke Plant
10:43 AM Ticket #11358 (Contrib apps - Flatpage sitemap shows all pages, even private pages) updated by Karen Tracey
Replying to lukeplant: > Is there a reason this wasn't …
10:39 AM 12323.3.diff attached to Ticket #12323 by Jannis Leidel
Caching the file finders.
10:33 AM Ticket #11358 (Contrib apps - Flatpage sitemap shows all pages, even private pages) updated by Luke Plant
Is there a reason this wasn't backported? I'm trying to backport …
10:12 AM Ticket #12012 (Core (Other) - Integration with the Python standard library logging module) closed by Russell Keith-Magee
fixed: (In [13981]) Fixed #12012 -- Added support for logging. Thanks to …
10:12 AM Changeset [24acca4]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Russell Keith-Magee <russell@…>
Fixed #12012 -- Added support for logging. Thanks to Vinay Sajip for …
9:55 AM Ticket #7923 (contrib.admin - Add links when using raw_id_fields in admin) updated by EmilStenstrom
Here's a snippet that adds links to ManyToManyField too: …
9:52 AM Ticket #7028 (contrib.admin - Better admin raw_id_fields feedback) updated by EmilStenstrom
While you wait for this ticket to be resolved, I've added a snippet …
9:27 AM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Patryk Zawadzki
I only test with sqlite and pg and could reproduce with both in 1.2 …
9:20 AM Tickets #8960,​10235,​10608,​10909,​13845,​14377,​14386 batch updated by Luke Plant
fixed: (In [13980]) Fixed #14386, #8960, #10235, #10909, #10608, #13845, …
9:20 AM Changeset [667d832]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Luke Plant <L.Plant.98@…>
Fixed #14386, #8960, #10235, #10909, #10608, #13845, #14377 - …
9:15 AM Ticket #14386 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) updated by Luke Plant
I will commit this shortly. I've made some tweaks to the patch, which …
9:04 AM t12991-rc1.diff.gz attached to Ticket #12991 by Russell Keith-Magee
RC1 of patch to add unittest2 support
9:04 AM Ticket #14387 (Database layer (models, ORM) - pre_save problem with inherrited model) updated by iskren
Owner, Status changed
The solution I used was to check if the primary key of the instance is …
9:04 AM Ticket #13974 (Database layer (models, ORM) - saving object with multi-table inheritance is not transactional by default) closed by Johannes Dollinger
wontfix: Django cannot know the scope of your transaction. At best, …
8:53 AM Ticket #13804 (Forms - URLField validation fails with "://" on the path and no scheme) updated by Johannes Dollinger
Triage Stage changed
8:44 AM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Carl Meyer
One possible difference is that I only ran this test on Postgres and …
8:42 AM Ticket #6735 (Generic views - Class-based generic views) updated by anonymous
Cc changed
8:41 AM Ticket #14023 (Documentation - Better example for the custom form template) updated by Matthias Kestenholz
Triage Stage, Milestone changed
People forget about form.non_field_errors all the time.
8:38 AM Ticket #13979 (Core (Management commands) - Django manage.py doesn’t work with IPython) updated by Russell Keith-Magee
@adamnelson: That's a common setup, but it's not universal. I, for …
8:37 AM Ticket #14018 (Database layer (models, ORM) - Introduce class_plural %-substitution placeholder for related_name of ...) updated by Matthias Kestenholz
Making code (attribute names) dependent on the result of a translation …
8:27 AM Ticket #13979 (Core (Management commands) - Django manage.py doesn’t work with IPython) closed by Adam Nelson
worksforme: Two people saying worksforme seems sufficient to mark it as such. …
8:26 AM Ticket #13972 (Forms - Field initial value callable should take a request object as an argument) updated by Matthias Kestenholz
Triage Stage changed
The form classes do not know anything about requests currently, and …
8:10 AM Ticket #13965 (Internationalization - psycopg2 throws an "can't adapt" error on ugettext_lazy translated strings) updated by Matthias Kestenholz
Triage Stage changed
No, semantics aren't the same. A lazy i18n string depends on the …
8:05 AM Ticket #12735 (Core (Management commands) - django shell is broken with IPython 0.11.x (bzr.r1219)) updated by Matthias Kestenholz
Has patch, Patch needs improvement changed
Most of the time we try the "new way" to do things first and fall back …
7:53 AM Ticket #13938 (Testing framework - django.test.Client response has wrong request type) closed by Matthias Kestenholz
invalid: As you wrote initializing the request object directly is probably …
7:42 AM Ticket #13918 (Generic views - [patch] Simplify implementation of `get_model_and_form_class`) updated by Matthias Kestenholz
Triage Stage changed
Even though there's an upcoming refactoring of generic views using …
7:38 AM Ticket #13916 (Forms - DecimalField min_value does not enforce use of decimal.Decimal type) closed by Matthias Kestenholz
wontfix: I think the developer can be expected to know the distinction between …
7:34 AM Ticket #13896 (contrib.syndication - Change language to dynamic attribute in syndication feed generator) updated by Matthias Kestenholz
Needs documentation, Triage Stage changed
I think this makes sense. The language of the feed might be encoded …
7:26 AM Ticket #6735 (Generic views - Class-based generic views) updated by Matthias Kestenholz
XViewMiddleware should be fixed if class-based views are added to …
7:26 AM Ticket #13842 (Core (Other) - XViewMiddleware fails with django.contrib.syndication.views.Feed) updated by Matthias Kestenholz
Status, Owner, Triage Stage changed
See #6735 too (adding class-based generic views to Django)
7:21 AM fix13839.patch attached to Ticket #13839 by Matthias Kestenholz
7:21 AM Ticket #13839 (Database layer (models, ORM) - select_related caches None for non-existent objects in reverse ...) updated by Matthias Kestenholz
Has patch, Triage Stage, Milestone changed
Proposed fix attached. This isn't my area of expertise though but the …
7:02 AM test13839.patch attached to Ticket #13839 by Matthias Kestenholz
7:02 AM Ticket #13839 (Database layer (models, ORM) - select_related caches None for non-existent objects in reverse ...) updated by Matthias Kestenholz
Here's a patch for the testsuite which currently fails, but should not.
6:35 AM Ticket #13770 (Forms - form BooleanField should clean the string u'false' as False.) updated by Matthias Kestenholz
Needs tests, Triage Stage changed
I think this feature makes sense. However, we still need tests for this.
6:28 AM Ticket #5365 (Database layer (models, ORM) - sqlite3+DateField: field__year doesn't work.) closed by Matthias Kestenholz
worksforme: Cannot reproduce, please provide a testcase if this is still a problem.
6:28 AM Ticket #14387 (Database layer (models, ORM) - pre_save problem with inherrited model) updated by iskren
After creating an empty instance of the Child Class and trying to save …
6:22 AM children_pre_save_problem.tar.gz attached to Ticket #14387 by iskren
A Django Program representing the problem, with tests
6:20 AM Ticket #14387 (Database layer (models, ORM) - pre_save problem with inherrited model) created by iskren
Hello. I have a base-class and a child-class. The child-class has a …
6:20 AM Ticket #14295 (Uncategorized - Saving an object with a custom manager results in IntegrityError) updated by Matthias Kestenholz
I think this has been fixed in [10056]
5:53 AM Ticket #5938 (Testing framework - test.Client.login_user(user_instance)) updated by Thomas Güttler
New ticket #14350
5:52 AM Ticket #14350 (Testing framework - Please add a login method to the test Client that doesn't depend on ...) updated by Thomas Güttler
Cc changed
I had this idea some time ago, but it was rejected. I hope this ticket …
5:03 AM Ticket #13965 (Internationalization - psycopg2 throws an "can't adapt" error on ugettext_lazy translated strings) updated by Mitar
Replying to mk: > I'm not sure whether lazy strings should …
4:57 AM Ticket #14350 (Testing framework - Please add a login method to the test Client that doesn't depend on ...) updated by Gabriel Hurley
Component changed
4:53 AM Ticket #14332 (Core (Management commands) - manage testserver and manage runserver should have similiar ...) updated by Gabriel Hurley
Component changed
4:49 AM Ticket #14295 (Uncategorized - Saving an object with a custom manager results in IntegrityError) closed by Gabriel Hurley
worksforme: I can't reproduce this failure on trunk or 1.2 with the code provided. …
4:21 AM Ticket #14283 (Contrib apps - AttributeError on admin detail page after r13708) updated by Gabriel Hurley
Component changed
4:21 AM fix14283.patch attached to Ticket #14283 by Matthias Kestenholz
4:20 AM Ticket #14041 (Contrib apps - Templates in function calls for sitemap) updated by Gabriel Hurley
Component changed
4:20 AM Ticket #14283 (Contrib apps - AttributeError on admin detail page after r13708) updated by Matthias Kestenholz
Has patch, Triage Stage changed
Need to curry formfield_for_dbfield in contenttypes/generic.py. Patch …
4:19 AM Ticket #13877 (Core (Other) - More documentation needed on exceptions in middlewares) updated by Gabriel Hurley
Triage Stage changed
Looks like this could use a little DDN... is this a documentation …
4:14 AM Ticket #14279 (Contrib apps - typo in tests for private flatpage not showing sitemaps) updated by Gabriel Hurley
Triage Stage, Milestone changed
This typo didn't actually affect the test, but it's good to correct …
4:10 AM Ticket #14377 (contrib.auth - Add site to the context of the logout view) updated by Gabriel Hurley
Triage Stage changed
Valid issue, marking accepted. However, the fix for this issue is in …
4:09 AM Ticket #14386 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) updated by Gabriel Hurley
Since apparently overwriting an old patch file in Trac overwrites …
4:04 AM 14386.diff attached to Ticket #14386 by Gabriel Hurley
Updated to fix #14377 as well. Uses get_current_site() in …
3:59 AM Ticket #13845 (contrib.auth - Contrib auth password-reset email depends on is_admin_site) updated by Gabriel Hurley
Triage Stage changed
For the record, the reason behind that email template control has to …
3:47 AM Ticket #14384 (Documentation - Installation documentation should avoid sys.path.append) updated by Greg Wogan-Browne
Status, Milestone, Owner, Has patch, Triage Stage changed
Agreed, the documentation should follow mod_wsgi best practices here. …
3:40 AM Ticket #14135 (Uncategorized - Admin ignores to_field on ForeignKey) updated by Matthias Kestenholz
This is an usage question -- please submit it to the django-users …
3:37 AM fix14132.patch attached to Ticket #14132 by Matthias Kestenholz
3:37 AM Ticket #14132 (Contrib apps - Feedgenerator doesn't support dates before 1900) updated by Matthias Kestenholz
Triage Stage, Status, Summary, Owner, Has patch changed
This affects feedgenerator, not feedparser.
3:36 AM 14384.patch attached to Ticket #14384 by Greg Wogan-Browne
3:30 AM Ticket #12325 (contrib.comments - Allow value of zero for moderate_after and close_after) updated by Gabriel Hurley
Needs tests, Summary, Needs documentation, Milestone changed
Added a new patch which allows 0 as a valid value for both …
3:28 AM 12325_comment_moderation.diff attached to Ticket #12325 by Gabriel Hurley
New patch with docs and tests
3:27 AM Ticket #13494 (Core (Mail) - Bad default for EMAIL_SUBJECT_PREFIX) updated by Andi Albrecht
Status, Owner changed
3:26 AM Ticket #13494 (Core (Mail) - Bad default for EMAIL_SUBJECT_PREFIX) updated by Andi Albrecht
Has patch changed
3:23 AM bug13494.diff attached to Ticket #13494 by Andi Albrecht
3:15 AM Ticket #14135 (Uncategorized - Admin ignores to_field on ForeignKey) updated by vbs
Replying to mk: > You must define a unicode method on …
3:14 AM Ticket #14135 (Uncategorized - Admin ignores to_field on ForeignKey) updated by vbs
but if i just want a specified field rather than an object, how can i …
2:56 AM Ticket #14386 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) updated by Gabriel Hurley
Status changed
I'm not sure why Trac isn't displaying the diff for this patch, but …
2:54 AM Ticket #14385 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) closed by Gabriel Hurley
duplicate: Duplicate of #14386... Trac is being buggy at the moment :-/
2:52 AM Ticket #14386 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) created by Gabriel Hurley
A few days ago I started …
2:51 AM Ticket #14385 (Contrib apps - Standardize Site/RequestSite access; looser coupling of sites ...) created by Gabriel Hurley
A few days ago I started …
2:44 AM Ticket #14135 (Uncategorized - Admin ignores to_field on ForeignKey) closed by Matthias Kestenholz
invalid: You must define a unicode method on course if you do not want the …
2:19 AM Ticket #14200 (Core (URLs) - new RegexURLResolver is contructed for every request) updated by Matthias Kestenholz
Patch needs improvement changed
Did you do some performance testing? I'm not sure whether this really …
2:11 AM Ticket #14175 (contrib.comments - Comment object's user_name field too short for User.get_full_name) updated by Matthias Kestenholz
Triage Stage changed
Either that or the return value of get_full_name() would have to be …
2:10 AM Ticket #14384 (Documentation - Installation documentation should avoid sys.path.append) created by monokrome
Using Apache's mod_wsgi implementation (and I'm sure some others), …
2:07 AM Ticket #14167 (Generic views - Using Instances in Generic Create/Update/Delete) updated by monokrome
Needs tests changed
2:01 AM Ticket #13965 (Internationalization - psycopg2 throws an "can't adapt" error on ugettext_lazy translated strings) updated by Matthias Kestenholz
I'm not sure whether lazy strings should be automatically converted to …
1:56 AM Ticket #13979 (Core (Management commands) - Django manage.py doesn’t work with IPython) updated by Matthias Kestenholz
Component changed
I'm using IPython on Snow Leopard all the time. I think this ticket …

Oct 3, 2010:

11:53 PM Ticket #9666 (Template system - ssi tag don't works with context variables) updated by Eric Holscher
Milestone changed
11:44 PM Ticket #7474 (Testing framework - add documentation restructured text checker to test suite) closed by Russell Keith-Magee
wontfix: I agree with Eric. A "make html" build already reports errors, so we …
11:16 PM Ticket #5418 (Testing framework - Add assertNoBrokenLinks() to test system) updated by Russell Keith-Magee
Triage Stage changed
To my mind, crawling is a slightly different activity to what this …
10:47 PM Ticket #13224 (contrib.admin - style of m2m readonly_fields in admin change_form) updated by Eric Holscher
Milestone changed
10:46 PM Ticket #13146 (contrib.admin - Remove hardcoded stuff in contrib.admin) updated by Eric Holscher
Milestone changed
Seems easy enough to fix and make people's lives easier.
10:45 PM Ticket #10214 (Core (Other) - Add 'internal' option to SEND_BROKEN_LINK_EMAILS) updated by Eric Holscher
Component changed
10:44 PM Ticket #9371 (Core (Serialization) - Fixtures combined with inherited models causing constraint ...) updated by Eric Holscher
Component changed
10:43 PM Ticket #8949 (Uncategorized - A django-stones benchmark) updated by Eric Holscher
Needs documentation, Milestone changed
Marking this for 1.3, because it would be really useful to have this …
10:41 PM Ticket #14276 (Testing framework - Typo in the docstring to one of the unittests) updated by Eric Holscher
Milestone changed
10:41 PM Ticket #14276 (Testing framework - Typo in the docstring to one of the unittests) updated by Eric Holscher
Triage Stage changed
10:39 PM Ticket #12226 (Testing framework - Test HttpResponse template attribute needlessly hard to use) updated by Eric Holscher
Milestone changed
10:38 PM Ticket #12141 (Testing framework - Add glob support to tests/runtests.py) updated by Eric Holscher
Status, Owner, Milestone changed
10:34 PM Ticket #8363 (Testing framework - Make it possible to specify tests to skip when running runtests.py) updated by Eric Holscher
Milestone changed
10:33 PM Ticket #7884 (Testing framework - Test framework needs option to run tests and return statuses) closed by Eric Holscher
fixed: Seems like this is provided by: …
10:30 PM Ticket #7474 (Testing framework - add documentation restructured text checker to test suite) updated by Eric Holscher
Triage Stage, Milestone changed
This seems like something that might work better as a Sphinx plugin. I …
10:28 PM Ticket #5418 (Testing framework - Add assertNoBrokenLinks() to test system) updated by Eric Holscher
Triage Stage, Milestone changed
It should be noted that I have implemented this as a third party app. …
10:26 PM Ticket #5416 (Testing framework - Add assertNumQueries() to testing framework) updated by Eric Holscher
Milestone changed
10:25 PM Ticket #9962 (Documentation - Add a tutorial for the testing framework) updated by Eric Holscher
Milestone, Status, Owner changed
I'd like to see this get into 1.3. Fix the "more tutorials coming …
10:22 PM Ticket #5624 (Testing framework - Add mechanism for associating fixtures with doctests) closed by Eric Holscher
wontfix: Going to close this one as wontfix because we are moving away from …
10:19 PM Ticket #9449 (Testing framework - test runner repeatedly parsers fixtures) updated by Eric Holscher
Status, Needs tests, Milestone, Owner, Needs documentation, Has patch changed
Going to work on this for 1.3. Thinking it should be disablable, …
10:15 PM Ticket #14319 (Testing framework - Add signals test_setup and test_teardown to Django test suite runner ...) updated by Eric Holscher
Triage Stage changed
10:08 PM Ticket #25 (contrib.admin - Filtering interface on ForeignKey <select> boxes) updated by Eric Holscher
Sorry I didn't comment earlier. I looked at this during the sprints, …
10:03 PM Ticket #14187 (Core (Management commands) - Add support for bpython in django-admin.py shell) updated by Eric Holscher
Needs tests, Triage Stage changed
Looks good to me. AFAIK we don't test that ipython works. However, …
9:51 PM Ticket #14356 (Core (Other) - Unused import in django.core.management.sql) updated by Eric Holscher
Triage Stage changed
Confirmed that these imports are never used. Perhaps a good pyflaking …
9:49 PM Ticket #11495 (Core (Other) - Improvements to django.views.static.serve directory indexes) updated by Eric Holscher
Needs documentation, Needs tests changed
Seems like a good idea. However the new prefix needs to be documented, …
9:44 PM Ticket #8960 (Contrib apps - "View on site" does not work if contrib.sites is not installed) updated by Eric Holscher
Needs tests changed
For people who want to see this get into 1.3, it will need tests at least.
9:42 PM Ticket #14103 (Core (Cache system) - Have django.utils.cache.patch_response_headers honor ...) updated by Eric Holscher
Triage Stage changed
Added a patch that mentions this other usage in the documentation. I …
9:40 PM 14103_with_docs.diff attached to Ticket #14103 by Eric Holscher
9:30 PM Ticket #12202 (contrib.auth - Hardcoded subject in the reset password mail) updated by Eric Holscher
Version, Triage Stage changed
This seems sane to me. I don't know if a template, or a passed in …
7:59 PM Ticket #13772 (Database layer (models, ORM) - 'exists' parameter for pre_save signal) updated by Łukasz Rekucki
Triage Stage changed
This ticket's history is a mess right now. You shouldn't mark your own …
7:24 PM Ticket #13828 (Template system - Refactor `dictsort` and `dictsortreversed` to make them more DRY) updated by Łukasz Rekucki
Summary changed
Both functions turn into one-liners in Python 2.4, so a common …
7:15 PM 13828_dry_dictsort_3.diff attached to Ticket #13828 by Łukasz Rekucki
Simplified patch.
7:05 PM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Luke Plant
Replying to carljm: > Any further detail from patrys or …
6:17 PM Ticket #14381 (Database layer (models, ORM) - small improvement in db.utils.ConnectionRouter.__init__) updated by Łukasz Rekucki
Triage Stage changed
Looks good. As it's very simple, going to mark as RFC.
5:47 PM Ticket #13279 (Documentation - Documentation that needs a small expansion) updated by Tim Graham
Triage Stage changed
5:19 PM Ticket #12325 (contrib.comments - Allow value of zero for moderate_after and close_after) updated by Gabriel Hurley
Status, Needs documentation, Owner, Summary changed
I'll finish off this patch with tests and a small note about allowed …
5:19 PM Ticket #12369 (Documentation - cStringIO portability) updated by Tim Graham
Triage Stage changed
5:16 PM Ticket #14382 (contrib.comments - a few suggestions) closed by Gabriel Hurley
invalid: Matthew, thank you for contributing to Django, however I've got a …
4:05 PM Ticket #14383 (Documentation - Capitalization of reStructuredText (reST)) updated by Tim Graham
Has patch, Triage Stage changed
4:04 PM 14383.diff attached to Ticket #14383 by Tim Graham
4:04 PM Ticket #14383 (Documentation - Capitalization of reStructuredText (reST)) created by Tim Graham
This was mentioned in #12975 -- thanks to whiteinge for the initial …
3:02 PM Ticket #11582 (Core (Other) - BaseHTTPServer has lots of special handling for admin media) updated by Jannis Leidel
A fix is included in the latest patch of #12323.
2:40 PM Ticket #12323 (Core (Other) - Ease handling of static files (e.g. included in apps)) updated by Jannis Leidel
I'm waiting with the modifications of the logging code in the patch …
2:38 PM 12323.2.diff attached to Ticket #12323 by Jannis Leidel
Latest patch from Github.
2:35 PM Ticket #12323 (Core (Other) - Ease handling of static files (e.g. included in apps)) updated by Jannis Leidel
Status, Owner, Milestone changed
2:30 PM Ticket #11495 (Core (Other) - Improvements to django.views.static.serve directory indexes) updated by Jannis Leidel
Triage Stage, Milestone changed
I agree with SmileyChris, this should be made consistent across the …
2:20 PM Ticket #11582 (Core (Other) - BaseHTTPServer has lots of special handling for admin media) updated by Jannis Leidel
Milestone changed
Marking for 1.3 since we can fix this when adding staticfiles.
1:21 PM django-14381.diff attached to Ticket #14381 by Alex Gaynor
Turned it into a diff.
12:59 PM Ticket #11509 (Documentation - Incorrect capitalisation of web in Widget documentation) updated by Tim Graham
Triage Stage changed
12:58 PM 11509.2.diff attached to Ticket #11509 by Tim Graham
update to apply cleanly to trunk
12:25 PM Ticket #9995 (Documentation - Mention 'pip install Django' as an alternative installation method.) updated by Tim Graham
Triage Stage changed
11:57 AM Ticket #14004 (Documentation - update() is not mention in the Queryset API Reference) updated by Tim Graham
Triage Stage changed
11:56 AM 14004.2.diff attached to Ticket #14004 by Tim Graham
tweaks to existing patch
11:42 AM Ticket #10841 (Core (Other) - Better 500 template for AJAX calls) updated by Diederik van der Boor
I would love to see JSON in the response, instead of plain text …
11:40 AM Ticket #12203 (contrib.admin - ManyToManyField with through model can't be used in admin) updated by Marc Aymerich
Cc changed
11:28 AM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Alex Gaynor
Seems related to #11256.
11:16 AM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Carl Meyer
Github branch here: …
11:14 AM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Carl Meyer
Ok, out of time for this at the moment; uploaded my initial tests. So …
11:10 AM 14373_r13978_initial_tests.diff attached to Ticket #14373 by Carl Meyer
10:33 AM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Carl Meyer
Owner changed
Putting together a patch for this. My initial take is that both fixes …
10:27 AM Ticket #13944 (*.djangoproject.com - Very long accept-language headers break parser) updated by anonymous
Replying to ramiro: > I cant' reproduce this with the …
9:32 AM Ticket #14382 (contrib.comments - a few suggestions) created by Matthew Sporleder
I have having trouble comment moderation because …
7:52 AM Ticket #14380 (Forms - Form provided by modelform_factory fails when using fields attribute) updated by Olivier Le Thanh Duong
Hum this was a error of retranscription when I wrote the bug, I had …
7:01 AM Ticket #14381 (Database layer (models, ORM) - small improvement in db.utils.ConnectionRouter.__init__) created by dauerbaustelle
Raising an ImproperlyConfigured error if a configured Router class …
6:42 AM Ticket #14051 (Database layer (models, ORM) - Signals for transaction commit/rollback) updated by Ask Solem <ask@…>
Cc changed
6:41 AM Ticket #14051 (Database layer (models, ORM) - Signals for transaction commit/rollback) updated by Ask Solem <ask@…>
@peritus, Patch looks good to me. Do you think the handlers should …
12:16 AM Ticket #14380 (Forms - Form provided by modelform_factory fails when using fields attribute) closed by Matt McClanahan
invalid: Per …

Oct 2, 2010:

6:12 PM Ticket #14380 (Forms - Form provided by modelform_factory fails when using fields attribute) updated by Olivier Le Thanh Duong
A friend can reproduce this bug using 1.1.1
6:11 PM Ticket #14380 (Forms - Form provided by modelform_factory fails when using fields attribute) created by Olivier Le Thanh Duong
When creating a form using modelform_factory, setting the fields …
5:32 PM Ticket #5677 (Documentation - Debugging with mod_python (apache)) updated by Tim Graham
Triage Stage changed
5:31 PM 5677.2.diff attached to Ticket #5677 by Tim Graham
updated danielr's patch to apply cleanly trunk
1:22 PM Ticket #14379 (Forms - formset.is_bound returns False for ModelFormsets created with queryset ...) created by Jannis Vajen
When a Modelformset is instantiated via a queryset, its is_bound
12:54 PM ClassBasedViews edited by George Sakkis
Syntax sugar for storing state on request through getattr/setattr (diff)
10:47 AM Ticket #14378 (Testing framework - Enable customization of the class for self.client in tests) updated by Russell Keith-Magee
Triage Stage, Milestone changed
Looks good to me. Thanks for the idea and patch, Ned.
10:34 AM t12991-alpha2.diff.gz attached to Ticket #12991 by Russell Keith-Magee
Second draft of adding unittest2 to trunk
10:29 AM Ticket #12991 (Testing framework - Django 1.2 should have optional support for unittest2) updated by Russell Keith-Magee
Owner, Status changed
Second draft patch now available for testing. See …
10:15 AM Ticket #4788 (Testing framework - django selftests should skip tests bound to fail) closed by Russell Keith-Magee
duplicate: I'm going to close this in favor of #12991; unittest2 provides test …
10:00 AM Ticket #10215 (Core (Other) - Dont rollback transaction on errors in management/loaddata in ...) updated by Vadim Fint
That was a long waiting.. :) Thanks, guys!
8:58 AM Ticket #10215 (Core (Other) - Dont rollback transaction on errors in management/loaddata in ...) updated by Russell Keith-Magee
For the benefit of history: Karen and I discussed this on IRC. We came …
8:56 AM Ticket #10215 (Core (Other) - Dont rollback transaction on errors in management/loaddata in ...) updated by Russell Keith-Magee
(In [13979]) [1.2.X] Fixed #10215 -- Ensured that there is parity …
8:56 AM Changeset [8266925]stable/1.2.x by Russell Keith-Magee <russell@…>
[1.2.X] Fixed #10215 -- Ensured that there is parity between enter and …
8:56 AM Ticket #10215 (Core (Other) - Dont rollback transaction on errors in management/loaddata in ...) closed by Russell Keith-Magee
fixed: (In [13978]) Fixed #10215 -- Ensured that there is parity between …
8:56 AM Changeset [96c11b2]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Russell Keith-Magee <russell@…>
Fixed #10215 -- Ensured that there is parity between enter and leave …
8:40 AM Ticket #13772 (Database layer (models, ORM) - 'exists' parameter for pre_save signal) updated by George Sakkis
Cc, Triage Stage changed
Extended and migrated the doctests into proper unit tests.
8:38 AM 13772.patch attached to Ticket #13772 by George Sakkis
Patch against r13975
8:14 AM Changeset [1429a3db]stable/1.2.x by Russell Keith-Magee <russell@…>
[1.2.X] Corrected a test failure under MySQL. Backport of r13976 from …
8:14 AM Ticket #10728 (Database layer (models, ORM) - [PATCH] SubfieldBase classes can't be subclassed.) updated by George Sakkis
Triage Stage, Milestone changed
Revamped and migrated the doctests into proper unit tests.
8:13 AM Changeset [57456c5]mainstable/1.10.xstable/1.11.xstable/1.3.xstable/1.4.xstable/1.5.xstable/1.6.xstable/1.7.xstable/1.8.xstable/1.9.xstable/2.0.xstable/2.1.xstable/2.2.xstable/3.0.xstable/3.1.xstable/3.2.xstable/4.0.xstable/4.1.xstable/4.2.xstable/5.0.xstable/5.1.xstable/5.2.x by Russell Keith-Magee <russell@…>
Corrected a test failure under MySQL. git-svn-id: …
8:00 AM Ticket #14378 (Testing framework - Enable customization of the class for self.client in tests) updated by Ned Batchelder
Cc changed
7:59 AM Ticket #14378 (Testing framework - Enable customization of the class for self.client in tests) updated by Ned Batchelder
Status, Owner changed
7:58 AM custom-test-client.diff attached to Ticket #14378 by Ned Batchelder
the patch
7:57 AM Ticket #14378 (Testing framework - Enable customization of the class for self.client in tests) created by Ned Batchelder
The attached patch removes the hard connection between test.TestCase …
7:04 AM ClassBasedViews edited by Carl Meyer
self-correction: copy-on-call's failure can manifest in … (diff)
5:31 AM DjangoJobs edited by Mark2011
(diff)
3:23 AM Ticket #8217 (Forms - Alphabetical sorted FilePathField) updated by Claude Paroz
Milestone changed
2:27 AM Ticket #14377 (contrib.auth - Add site to the context of the logout view) created by Hraban <hraban@…>
This should be a really simple addition. ;) In my app's root template …

Oct 1, 2010:

11:44 PM 0001-Added-ref-doc-to-Brazilian-CPF-and-CNPJ-fields.diff attached to Ticket #14376 by Henrique Bastos
11:44 PM Ticket #14376 (Documentation - Localflavors documentation for BRCPFField and BRCNPJField) created by Henrique Bastos
There were two undocumented classes in contrib.localflavors.br: …
11:38 PM 0001-Added-missing-templates-for-contrib.auth-tests.diff attached to Ticket #14374 by Henrique Bastos
Just fixing the file extension.
11:07 PM SplitSettings edited by Antti Kaihola
Fixed init.py file name formatting (diff)
11:04 PM SplitSettings edited by Antti Kaihola
Added a refined method for importing local settings (diff)
9:31 PM Ticket #14375 (Documentation - Typo in formfield documentation) updated by David Novakovic
Has patch, Triage Stage changed
9:30 PM formfield-doc-patch.diff attached to Ticket #14375 by David Novakovic
9:26 PM Ticket #14375 (Documentation - Typo in formfield documentation) updated by David Novakovic
Triage Stage changed
8:18 PM Ticket #13751 (HTTP handling - Avoid open redirect issue with whitelist) updated by Luke Plant
Patch needs improvement changed
The logging call is definitely wrong - have a look at the examples in …
7:43 PM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Luke Plant
Triage Stage, Milestone changed
6:31 PM Ticket #13751 (HTTP handling - Avoid open redirect issue with whitelist) updated by David Novakovic
Needs documentation, Needs tests, Patch needs improvement changed
Hey, I couldn't get sphinx to render the docs properly, so I couldn't …
6:29 PM openredirect-with-docs.diff attached to Ticket #13751 by David Novakovic
6:12 PM Ticket #14375 (Documentation - Typo in formfield documentation) created by Blue
Formfields page has a typo: MultiValuefield instead of MultiValueField …
5:41 PM Ticket #11670 (Database layer (models, ORM) - Model fields named 'year', 'month', 'gt', 'lt' etc. get mistaken for ...) updated by Joel Watts
Owner changed
4:54 PM Ticket #9886 (HTTP handling - File-like interface for HttpRequest) updated by Jacob
Triage Stage changed
4:35 PM 9886.5.diff attached to Ticket #9886 by Ivan Sagalaev
Updated to current trunk, tests converted to unittests
3:50 PM Ticket #10728 (Database layer (models, ORM) - [PATCH] SubfieldBase classes can't be subclassed.) updated by Joel Watts
Cc changed
3:47 PM Ticket #4656 (Core (Serialization) - Allow In-depth serialization by specifying depth to follow relationship) updated by anonymous
Cc changed
3:34 PM 0001-Added-missing-templates-for-contrib.auth-tests.patch attached to Ticket #14374 by Henrique Bastos
3:33 PM Ticket #14374 (Contrib apps - Missing templates on contrib.auth makes tests in a new project fail ...) created by Henrique Bastos
After installing django and creating a project runing "django-admin.py …
2:55 PM ClassBasedViews edited by Carl Meyer
use preview, fool (diff)
2:53 PM ClassBasedViews edited by Carl Meyer
add a couple additional notes (diff)
2:48 PM patch.4.diff attached to Ticket #14355 by Yeago
removed exception
2:39 PM patch.3.diff attached to Ticket #14355 by Yeago
removed exception
2:39 PM patch.2.diff attached to Ticket #14355 by Yeago
removed exception
2:32 PM Ticket #14355 (contrib.admin - "readonly" fields don't display their "help_text" in admin) updated by anonymous
Has patch changed
2:31 PM Ticket #6903 (contrib.admin - Go back to old change_list view after hitting save) updated by hejsan
Cc changed
2:29 PM patch.diff attached to Ticket #14355 by alexbmeng@…
Added help_text to readonly admin fields
2:27 PM Ticket #6183 (contrib.admin - [patch] Support help_text with ManyToMany field widgets) updated by Andrew Badr
Cc changed
2:18 PM Ticket #12369 (Documentation - cStringIO portability) updated by niall
Updated the patch, now just has a comment above the import with a one …
2:17 PM outputting-pdf.diff attached to Ticket #12369 by niall
2:16 PM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) updated by Patryk Zawadzki
In case it was not obvious, the example was supposed to say …
2:13 PM Ticket #14364 (contrib.admin - Admin add form, element focus script not working because of wrong id) closed by Karen Tracey
invalid: Please include a minimal example model/admin definition needed to …
1:54 PM Ticket #3999 (Core (Management commands) - django-admin.py template dir argument) updated by Chris Beaven
A better place to talk about closed tickets is the mailing list.
1:01 PM Ticket #14373 (Database layer (models, ORM) - annotate() will gladly delete your data) created by Patryk Zawadzki
Consider the following example: […] Create your database, fill it …
11:38 AM ClassBasedViews edited by Russell Keith-Magee
Document why modifying urlresolver isn't viable. (diff)
11:04 AM Ticket #5833 (contrib.admin - Custom FilterSpecs) updated by Yeago
Triage Stage changed
switched back to accepted.
10:50 AM Ticket #5054 (contrib.admin - Calendar in admin interface doesn't display over dropdowns correctly in IE6) closed by Yeago
wontfix: This ticket would create validation warnings because the iframe is …
10:48 AM 14372-admin-hiddenfield.diff attached to Ticket #14372 by Michael Newman
Simple check to is_hidden to determine if we should render the label.
10:38 AM Ticket #14372 (contrib.admin - Admin shouldn't render label tags on hidden fields) created by Michael Newman
If a field in the admin is hidden, the label tag is still rendered. It …
10:32 AM ClassBasedViews edited by Carl Meyer
add "store state on request" thread-safety option (diff)
10:17 AM ClassBasedViews edited by Andrew Godwin
Adding a few more "bikeshed-worthy" topics, and a reasonable first … (diff)
9:37 AM Ticket #7700 (Core (Other) - Query parent for child) updated by Vlastimil Zíma
Cc changed
Replying to cdeccio: > It still seems to be exhibiting the …
9:00 AM Ticket #3999 (Core (Management commands) - django-admin.py template dir argument) updated by pbaker@…
Bump. This is a bit old, but came across it in development of Django …
8:58 AM Ticket #13839 (Database layer (models, ORM) - select_related caches None for non-existent objects in reverse ...) updated by Vlastimil Zíma
Cc changed
8:55 AM Ticket #14371 (Database layer (models, ORM) - Select related and parents) created by Vlastimil Zíma
I have a parent model for multiple children, but has nothing but …
8:19 AM Ticket #14368 (Database layer (models, ORM) - Reverse relation attribute for OneToOneField fails when set to None) updated by Yeago
Wow. I just tried bob.soul = Soul.objects.create() and I must admit …
8:09 AM Ticket #10790 (Database layer (models, ORM) - Too many joins in a comparison for NULL.) updated by Vlastimil Zíma
Cc changed
7:59 AM Ticket #12241 (contrib.admin - Admin forgets URL used for prefilling forms when hitting Save and add ...) updated by Batiste Bieler
Thanks Chris. Keep me updated with the progress.
6:48 AM Ticket #6735 (Generic views - Class-based generic views) updated by Ben Firshman
Milestone changed
Wiki page with the current status of this ticket: …
6:45 AM ClassBasedViews edited by Ben Firshman
(diff)
6:16 AM admin-log-deletion.diff attached to Ticket #10889 by 3point2
6:16 AM Ticket #10889 (contrib.admin - ModelAdmin calls .log_deletion after deletion, causing invalid object_id) reopened by 3point2
I recently discovered I was getting log messages for failed deletions. …
5:53 AM Ticket #12417 (Core (Other) - Add signing and signed cookies to Django) updated by Luke Plant
A few comments on the patch, while I remember: I think that …
4:45 AM Ticket #10944 (contrib.sites - Site app should be able to make absolute URLs.) updated by Jannis Leidel
Triage Stage changed
4:45 AM Emacs edited by Anatoly Kamchatnov
Fixed ToC, indicated current statuses of the modes (diff)
4:15 AM Ticket #12241 (contrib.admin - Admin forgets URL used for prefilling forms when hitting Save and add ...) updated by Chris Beaven
batiste, I've got a local branch with some more changes than your …
4:13 AM Ticket #12241 (contrib.admin - Admin forgets URL used for prefilling forms when hitting Save and add ...) updated by Batiste Bieler
Cc changed
3:48 AM Ticket #14368 (Database layer (models, ORM) - Reverse relation attribute for OneToOneField fails when set to None) updated by George Sakkis
I'm baffled, your comment doesn't make any sense. > I disagree. Do …
1:40 AM Ticket #13814 (Contrib apps - Utility method for getting a Site object) closed by Gabriel Hurley
duplicate: Duplicate of #10235 (which adds a method to do exactly this as part of …
1:25 AM Ticket #13969 (contrib.auth - auth module should use longer salt for hashing) updated by Gabriel Hurley
Patch needs improvement, Triage Stage changed
This is a valid concern, and the code works for me, however I'm not a …
1:19 AM Ticket #14354 (contrib.auth - Check password is not None in User.check_password) updated by Gabriel Hurley
Triage Stage changed
Seems like a valid point to me. I think it might be a little cleaner …
1:05 AM t12012-rc2.diff attached to Ticket #12012 by Russell Keith-Magee
RC2 of logging patch.
Note: See TracTimeline for information about the timeline view.
Back to Top