Skip to content

Commit 7a68b0d

Browse files
jonsimantovtom-andersenAlmostMatta-mauricecompnerd
authored
Merge main into UMP feature branch and update readme (#1458)
* iOS: Remove Analytics dependency from GMA integration test (#1386) * Try using CoreOnly instead of Analytics cocoapod for tests. * Update readme. * Add stub workflow for updating feature branches. * Add script to merge main into all active feature branches on a regular schedule. (#1394) * Add workflow for automatically updating feature branches weekly. * Corrected filename, and added inputs. * Remove trailing spaces. * Fix workflow. * Fix workflow name. * Fix syntax. * Fix syntax. * List remote branches instead. * Clean up script. * Untab. * Add branch list for debugging. * Untab. * Specify remote branches. * Skip second stage if no first. * Typo * Error. * List all branches. * Fix logic. * Fix spacing. * Fix output * Fix parameters. * Fix merge to use origin. * Remove debug echos. * Add git config. * Fix PR creation. * Fix PR creation. * Fix automatic push. * Increase retry. (#1402) * Add Firestore test history report (#1403) * Add --firestore flag to report Firestore history. * Add Firestore report to nightly cron job. * Remove multiline commands. * Revert "Remove multiline commands." This reverts commit 6393ae9. * Fix tabbing. * Fix packaging test detection for Firestore. * Revert "OR Query Implementation (#1335)" (#1399) This reverts commit 11332d4. * Wrap the real-time RemoteConfig test in flaky-block to automatically retry. (#1406) * Only use flaky_test on android * Update the iOS version used by FTL (#1408) * Kick off nightly packaging an hour earlier (#1409) * Fix crash on gma::Initialize without a Firebase App (#1320) Initialize Util before using Util::FIndClass. Also add an integration test for initializing gma without a firebase app. * build: pass along the CMake path (#1410) When building the subproject, we would invoke `cmake` directly, relying on the path lookup of the tool, which may or may not match the currently executing CMake. Use `CMAKE_COMMAND` which gives us the path to the current CMake executable ensuring that we use the same CMake for building the dependencies. * Add log to gsutil fetch. (#1411) * Update mobile dependencies - Thu Aug 03 2023 (#1413) * Update mobile dependencies - Thu Aug 03 2023 ### Android - com.google.firebase.firebase_bom → 32.2.2 ### iOS - Firebase/Analytics → 10.13.0 - Firebase/AppCheck → 10.13.0 - Firebase/Auth → 10.13.0 - Firebase/Core → 10.13.0 - Firebase/CoreOnly → 10.13.0 - Firebase/Crashlytics → 10.13.0 - Firebase/Database → 10.13.0 - Firebase/DynamicLinks → 10.13.0 - Firebase/Firestore → 10.13.0 - Firebase/Functions → 10.13.0 - Firebase/Installations → 10.13.0 - Firebase/Messaging → 10.13.0 - Firebase/RemoteConfig → 10.13.0 - Firebase/Storage → 10.13.0 - Google-Mobile-Ads-SDK → 10.9.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/5755777170). * Ensure using a Swift bridging header that supports both arm64 and x86_64. * Add release note about i386 no longer being supported. * Remove armv7 as well. --------- Co-authored-by: firebase-workflow-trigger-bot <[email protected]> Co-authored-by: Jon Simantov <[email protected]> Co-authored-by: [email protected] <[email protected]> * feat(auth): Add emulator support (#1400) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` --------- Co-authored-by: Cynthia Jiang <[email protected]> * Update merge-to-main script (#1420) * Before creating the merge-main PR, branch it off main, so merge conflicts can be addressed in the branch rather than by committing to main. * Format. * Update release version number for M135, 11.4.0 (#1421) * feat(auth): enable emulator support on desktop (#1423) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` * make json request always do restrict json * add readme info * prepare for review * some minor tweak * code format * update review comments * update the unit test after request json change --------- Co-authored-by: Cynthia Jiang <[email protected]> * Internal Updates. (#1422) * Add logic to trim webp parameter from native image urls * Add Analytics function for on-device conversion (#1429) * Add Analytics function for phone number conversion * Formatting * Update analytics.h * Update analytics_test.cc * Update mobile dependencies - Tue Aug 29 2023 (#1436) * Update mobile dependencies - Tue Aug 29 2023 ### Android - com.google.android.gms.play_services_ads → 22.3.0 - com.google.firebase.firebase_bom → 32.2.3 ### iOS - Firebase/Analytics → 10.14.0 - Firebase/AppCheck → 10.14.0 - Firebase/Auth → 10.14.0 - Firebase/Core → 10.14.0 - Firebase/CoreOnly → 10.14.0 - Firebase/Crashlytics → 10.14.0 - Firebase/Database → 10.14.0 - Firebase/DynamicLinks → 10.14.0 - Firebase/Firestore → 10.14.0 - Firebase/Functions → 10.14.0 - Firebase/Installations → 10.14.0 - Firebase/Messaging → 10.14.0 - Firebase/RemoteConfig → 10.14.0 - Firebase/Storage → 10.14.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6016988287). * Update query_main to use normalized_order_bys * Update query_main.cc --------- Co-authored-by: firebase-workflow-trigger-bot <[email protected]> Co-authored-by: a-maurice <[email protected]> * add UseEmulator api to auth (#1437) * add auth emulator support * fix ios number parse * update the documentation part * reduce lint warning * more lint warnings * code format * use environment to decide using emulator or not * fix a typo * add readme entry for FirebaseApp.GetApps() * update for review comment * add missing ` * make json request always do restrict json * add readme info * prepare for review * some minor tweak * code format * update review comments * update the unit test after request json change * remove platform logging v1 code * add useEmulator api * test with emulator * clean up for review * tweak for review * update with comments * put back necessary heartbeat blocks --------- Co-authored-by: Cynthia Jiang <[email protected]> * On Android, set dynamic code files to readonly (#1430) * To address an Android 14 security issue, set dex files to readonly. This follows the advice on dynamic code loading here: https://developer.android.com/about/versions/14/behavior-changes-14#safer-dynamic-code-loading * Format code. * Reorder exception check so that we cover all the spots. * Add release note. * Update iOS dependencies - Tue Sep 12 2023 (#1443) ### iOS - Firebase/Analytics → 10.15.0 - Firebase/AppCheck → 10.15.0 - Firebase/Auth → 10.15.0 - Firebase/Core → 10.15.0 - Firebase/CoreOnly → 10.15.0 - Firebase/Crashlytics → 10.15.0 - Firebase/Database → 10.15.0 - Firebase/DynamicLinks → 10.15.0 - Firebase/Firestore → 10.15.0 - Firebase/Functions → 10.15.0 - Firebase/Installations → 10.15.0 - Firebase/Messaging → 10.15.0 - Firebase/RemoteConfig → 10.15.0 - Firebase/Storage → 10.15.0 - Google-Mobile-Ads-SDK → 10.10.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6164028143). Co-authored-by: firebase-workflow-trigger-bot <[email protected]> * Apply unused variables patch to Flatbuffers on Android as well. (#1444) Already applied on desktop elsewhere. * Fix iOS test version from deprecate 16.5 to 16.6. (#1449) * Update Android dependencies - Mon Sep 18 2023 (#1448) * Update release version to 11.5.0. * Update readme. * Update Android dependencies - Mon Sep 18 2023 ### Android - com.google.android.gms.play_services_ads → 22.4.0 - com.google.firebase.firebase_bom → 32.3.1 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6226059256). * Add note about GMA Android. * Revert play-services-ads to 22.3.0. --------- Co-authored-by: Jon Simantov <[email protected]> Co-authored-by: firebase-workflow-trigger-bot <[email protected]> * Add a matrix label to FTL test runs, to make sorting them easier. (#1452) * Add a matrix label to FTL test runs, to make sorting them easier. * Fix label for iOS * OR Query Implementation (#1453) * OR Query Implementation * Pretty * Add includes * Fix from PR feedback * Fix variadic parameters * Add and fix tests * Add/fix method descriptions. * Add/fix constructor and class descriptions. * Add method description to disjunction/conjunction. * Add tests. Revealed bugs to be fixed. * Fix type * Add test * Android implementation * Pretty * Pretty * Pretty * Remove const * Pretty * Fixes from code review * Release notes * Release notes * Fix Android OR Query * Release notes. * Fix release notes. * Format * Internal Updates (#1439) * Internal Updates * Revert firestore to main. * Add additional release note. * Fix bad merge output. --------- Co-authored-by: Tom Andersen <[email protected]> Co-authored-by: Matthew Hyndman <[email protected]> Co-authored-by: a-maurice <[email protected]> Co-authored-by: Saleem Abdulrasool <[email protected]> Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com> Co-authored-by: firebase-workflow-trigger-bot <[email protected]> Co-authored-by: Cynthia J <[email protected]> Co-authored-by: Cynthia Jiang <[email protected]> Co-authored-by: nakirekommula <[email protected]>
1 parent 1a8c017 commit 7a68b0d

39 files changed

+2171
-59
lines changed

app/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,7 @@ if (IOS)
518518
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/document_snapshot.h
519519
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/field_path.h
520520
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/field_value.h
521+
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/filter.h
521522
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/listener_registration.h
522523
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/load_bundle_task_progress.h
523524
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/map_field_value.h

firestore/CMakeLists.txt

+9
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ set(common_SRCS
3131
src/common/document_snapshot.cc
3232
src/common/exception_common.cc
3333
src/common/exception_common.h
34+
src/common/filter.cc
3435
src/common/field_path.cc
3536
src/common/field_value.cc
3637
src/common/firestore.cc
@@ -97,6 +98,8 @@ set(android_SRCS
9798
src/android/field_path_portable.h
9899
src/android/field_value_android.cc
99100
src/android/field_value_android.h
101+
src/android/filter_android.cc
102+
src/android/filter_android.h
100103
src/android/firestore_android.cc
101104
src/android/firestore_android.h
102105
src/android/firestore_exceptions_android.h
@@ -201,13 +204,17 @@ set(main_SRCS
201204
src/main/aggregate_query_snapshot_main.h
202205
src/main/collection_reference_main.cc
203206
src/main/collection_reference_main.h
207+
src/main/composite_filter_main.cc
208+
src/main/composite_filter_main.h
204209
src/main/converter_main.h
205210
src/main/document_change_main.cc
206211
src/main/document_change_main.h
207212
src/main/document_reference_main.cc
208213
src/main/document_reference_main.h
209214
src/main/document_snapshot_main.cc
210215
src/main/document_snapshot_main.h
216+
src/main/filter_main.cc
217+
src/main/filter_main.h
211218
src/main/field_value_main.cc
212219
src/main/field_value_main.h
213220
src/main/firestore_main.cc
@@ -227,6 +234,8 @@ set(main_SRCS
227234
src/main/transaction_main.h
228235
src/main/user_data_converter_main.cc
229236
src/main/user_data_converter_main.h
237+
src/main/unary_filter_main.cc
238+
src/main/unary_filter_main.h
230239
src/main/util_main.h
231240
src/main/write_batch_main.cc
232241
src/main/write_batch_main.h)

firestore/integration_test_internal/CMakeLists.txt

+2
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ set(FIREBASE_INTEGRATION_TEST_PORTABLE_TEST_SRCS
9191
# public API are performed.
9292
src/integration_test.cc
9393
# Internal tests below.
94+
src/aggregate_count_test.cc
9495
src/aggregate_query_snapshot_test.cc
9596
src/aggregate_query_test.cc
9697
src/bundle_test.cc
@@ -99,6 +100,7 @@ set(FIREBASE_INTEGRATION_TEST_PORTABLE_TEST_SRCS
99100
src/document_change_test.cc
100101
src/document_reference_test.cc
101102
src/document_snapshot_test.cc
103+
src/filter_test.cc
102104
src/field_value_test.cc
103105
src/fields_test.cc
104106
src/firestore_test.cc

firestore/integration_test_internal/integration_test.xcodeproj/project.pbxproj

+24
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@
2121
12CCF1E928FDBD9F00C24941 /* set_options_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 12CCF1DF28FDBD9F00C24941 /* set_options_test.cc */; };
2222
12D513142684C8C200A83FAA /* bundle_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 12D513132684C8C200A83FAA /* bundle_test.cc */; };
2323
12D5131A2684C8D100A83FAA /* bundle_builder.cc in Sources */ = {isa = PBXBuildFile; fileRef = 12D513182684C8D100A83FAA /* bundle_builder.cc */; };
24+
1BAFACA32A449C2B00834979 /* aggregate_query_snapshot_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA02A449C2B00834979 /* aggregate_query_snapshot_test.cc */; };
25+
1BAFACA42A449C2B00834979 /* aggregate_query_snapshot_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA02A449C2B00834979 /* aggregate_query_snapshot_test.cc */; };
26+
1BAFACA52A449C2B00834979 /* aggregate_count_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA12A449C2B00834979 /* aggregate_count_test.cc */; };
27+
1BAFACA62A449C2B00834979 /* aggregate_count_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA12A449C2B00834979 /* aggregate_count_test.cc */; };
28+
1BAFACA72A449C2B00834979 /* aggregate_query_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA22A449C2B00834979 /* aggregate_query_test.cc */; };
29+
1BAFACA82A449C2B00834979 /* aggregate_query_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA22A449C2B00834979 /* aggregate_query_test.cc */; };
30+
1BAFACAA2A449CBD00834979 /* filter_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA92A449CBD00834979 /* filter_test.cc */; };
31+
1BAFACAB2A449CBD00834979 /* filter_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = 1BAFACA92A449CBD00834979 /* filter_test.cc */; };
2432
520BC0391C869159008CFBC3 /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = 520BC0381C869159008CFBC3 /* GoogleService-Info.plist */; };
2533
5270BB448DF5ECE860FDD68B /* firebase_firestore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = EAFAF9474EC412ADCC65F2CC /* firebase_firestore.framework */; };
2634
529226D61C85F68000C89379 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 529226D51C85F68000C89379 /* Foundation.framework */; };
@@ -123,6 +131,10 @@
123131
12D513182684C8D100A83FAA /* bundle_builder.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = bundle_builder.cc; path = src/util/bundle_builder.cc; sourceTree = "<group>"; };
124132
12D513192684C8D100A83FAA /* bundle_builder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = bundle_builder.h; path = src/util/bundle_builder.h; sourceTree = "<group>"; };
125133
1B3D64B35A22073C76B376D5 /* libPods-integration_test_tvos.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-integration_test_tvos.a"; sourceTree = BUILT_PRODUCTS_DIR; };
134+
1BAFACA02A449C2B00834979 /* aggregate_query_snapshot_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = aggregate_query_snapshot_test.cc; path = src/aggregate_query_snapshot_test.cc; sourceTree = "<group>"; };
135+
1BAFACA12A449C2B00834979 /* aggregate_count_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = aggregate_count_test.cc; path = src/aggregate_count_test.cc; sourceTree = "<group>"; };
136+
1BAFACA22A449C2B00834979 /* aggregate_query_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = aggregate_query_test.cc; path = src/aggregate_query_test.cc; sourceTree = "<group>"; };
137+
1BAFACA92A449CBD00834979 /* filter_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = filter_test.cc; path = src/filter_test.cc; sourceTree = "<group>"; };
126138
3DE393E827F88B06CD3C39CD /* Pods-integration_test_tvos.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-integration_test_tvos.release.xcconfig"; path = "Target Support Files/Pods-integration_test_tvos/Pods-integration_test_tvos.release.xcconfig"; sourceTree = "<group>"; };
127139
4AAFA3E3DA9641C2E3C46C9D /* Pods_integration_test.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_integration_test.framework; sourceTree = BUILT_PRODUCTS_DIR; };
128140
520BC0381C869159008CFBC3 /* GoogleService-Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "GoogleService-Info.plist"; sourceTree = "<group>"; };
@@ -281,6 +293,10 @@
281293
5292271D1C85FB5500C89379 /* src */ = {
282294
isa = PBXGroup;
283295
children = (
296+
1BAFACA92A449CBD00834979 /* filter_test.cc */,
297+
1BAFACA12A449C2B00834979 /* aggregate_count_test.cc */,
298+
1BAFACA02A449C2B00834979 /* aggregate_query_snapshot_test.cc */,
299+
1BAFACA22A449C2B00834979 /* aggregate_query_test.cc */,
284300
12CCF1DF28FDBD9F00C24941 /* set_options_test.cc */,
285301
12CCF1DB28FDBD9E00C24941 /* settings_test.cc */,
286302
12CCF1DC28FDBD9F00C24941 /* source_test.cc */,
@@ -576,12 +592,14 @@
576592
D62CCBC022F367140099BE9F /* gmock-all.cc in Sources */,
577593
D61CFBC126091C3B0035CB2A /* integration_test.cc in Sources */,
578594
D6AAAD532606C22D0025C53B /* includes_test.cc in Sources */,
595+
1BAFACA52A449C2B00834979 /* aggregate_count_test.cc in Sources */,
579596
D6AAAD502606C22D0025C53B /* numeric_transforms_test.cc in Sources */,
580597
D6ED33BE2606CD890058CBF9 /* integration_test_util.cc in Sources */,
581598
D6C179EA22CB322900C2651A /* ios_firebase_test_framework.mm in Sources */,
582599
12CCF1E228FDBD9F00C24941 /* source_test.cc in Sources */,
583600
D6AAAD4C2606C22D0025C53B /* server_timestamp_test.cc in Sources */,
584601
D6AAAD4E2606C22D0025C53B /* firestore_test.cc in Sources */,
602+
1BAFACAA2A449CBD00834979 /* filter_test.cc in Sources */,
585603
D6AAAD452606C22D0025C53B /* document_change_test.cc in Sources */,
586604
D6AAAD472606C22D0025C53B /* document_snapshot_test.cc in Sources */,
587605
D6C179E922CB322900C2651A /* ios_app_framework.mm in Sources */,
@@ -591,7 +609,9 @@
591609
EDEEC7632800CD0000EFBAAF /* leveldb_snappy_test.cc in Sources */,
592610
12CCF1E828FDBD9F00C24941 /* set_options_test.cc in Sources */,
593611
D6AAAD562606C22D0025C53B /* query_network_test.cc in Sources */,
612+
1BAFACA72A449C2B00834979 /* aggregate_query_test.cc in Sources */,
594613
D6AAAD552606C22D0025C53B /* listener_registration_test.cc in Sources */,
614+
1BAFACA32A449C2B00834979 /* aggregate_query_snapshot_test.cc in Sources */,
595615
12D5131A2684C8D100A83FAA /* bundle_builder.cc in Sources */,
596616
D6AAAD4A2606C22D0025C53B /* fields_test.cc in Sources */,
597617
D6AAAD462606C22D0025C53B /* query_test.cc in Sources */,
@@ -610,6 +630,8 @@
610630
isa = PBXSourcesBuildPhase;
611631
buildActionMask = 2147483647;
612632
files = (
633+
1BAFACAB2A449CBD00834979 /* filter_test.cc in Sources */,
634+
1BAFACA62A449C2B00834979 /* aggregate_count_test.cc in Sources */,
613635
BC1D6850267B00EB005DC2DA /* app_framework.cc in Sources */,
614636
BC1D6853267B00EB005DC2DA /* transaction_extra_test.cc in Sources */,
615637
BC1D683E267B00EB005DC2DA /* integration_test_util.cc in Sources */,
@@ -623,6 +645,7 @@
623645
BC1D6848267B00EB005DC2DA /* sanity_test.cc in Sources */,
624646
12CCF1E728FDBD9F00C24941 /* write_batch_test.cc in Sources */,
625647
12CCF1E128FDBD9F00C24941 /* settings_test.cc in Sources */,
648+
1BAFACA82A449C2B00834979 /* aggregate_query_test.cc in Sources */,
626649
BC1D6856267B00EE005DC2DA /* ios_app_framework.mm in Sources */,
627650
BC1D6843267B00EB005DC2DA /* numeric_transforms_test.cc in Sources */,
628651
BC1D6844267B00EB005DC2DA /* array_transform_test.cc in Sources */,
@@ -632,6 +655,7 @@
632655
BC1D684E267B00EB005DC2DA /* includes_test.cc in Sources */,
633656
BC1D684C267B00EB005DC2DA /* document_change_test.cc in Sources */,
634657
BC1D6851267B00EB005DC2DA /* firestore_integration_test.cc in Sources */,
658+
1BAFACA42A449C2B00834979 /* aggregate_query_snapshot_test.cc in Sources */,
635659
BC1D6838267B00EB005DC2DA /* future_test_util.cc in Sources */,
636660
12CCF1E528FDBD9F00C24941 /* validation_test.cc in Sources */,
637661
BC1D6839267B00EB005DC2DA /* type_test.cc in Sources */,

firestore/integration_test_internal/src/aggregate_count_test.cc

-16
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,9 @@
2828
#include "firestore_integration_test.h"
2929
#include "util/event_accumulator.h"
3030

31-
#if defined(__ANDROID__)
32-
#include "firestore/src/android/query_android.h"
33-
#include "firestore/src/common/wrapper_assertions.h"
34-
#endif // defined(__ANDROID__)
35-
3631
#include "Firestore/core/src/util/firestore_exceptions.h"
3732
#include "firebase/firestore/firestore_errors.h"
3833
#include "firebase_test_framework.h"
39-
#include "gmock/gmock.h"
4034
#include "gtest/gtest.h"
4135

4236
namespace firebase {
@@ -757,15 +751,5 @@ TEST_F(AggregateCountTest,
757751
EXPECT_EQ(aggregate_query2, aggregate_snapshot2.query());
758752
}
759753

760-
#if defined(__ANDROID__)
761-
TEST(QueryTestAndroidStub, Construction) {
762-
testutil::AssertWrapperConstructionContract<Query>();
763-
}
764-
765-
TEST(QueryTestAndroidStub, Assignment) {
766-
testutil::AssertWrapperAssignmentContract<Query>();
767-
}
768-
#endif // defined(__ANDROID__)
769-
770754
} // namespace firestore
771755
} // namespace firebase

firestore/integration_test_internal/src/aggregate_query_test.cc

+15
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
#include "firebase/firestore.h"
1818
#include "firestore_integration_test.h"
1919

20+
#if defined(__ANDROID__)
21+
#include "firestore/src/android/aggregate_query_android.h"
22+
#include "firestore/src/common/wrapper_assertions.h"
23+
#endif // defined(__ANDROID__)
24+
2025
#include "gtest/gtest.h"
2126

2227
namespace firebase {
@@ -332,6 +337,16 @@ TEST_F(AggregateQueryTest, TestHashCode) {
332337
AggregateQueryHash(query1.Count()));
333338
}
334339

340+
#if defined(__ANDROID__)
341+
TEST(QueryTestAndroidStub, Construction) {
342+
testutil::AssertWrapperConstructionContract<AggregateQuery>();
343+
}
344+
345+
TEST(QueryTestAndroidStub, Assignment) {
346+
testutil::AssertWrapperAssignmentContract<AggregateQuery>();
347+
}
348+
#endif // defined(__ANDROID__)
349+
335350
} // namespace
336351
} // namespace firestore
337352
} // namespace firebase

0 commit comments

Comments
 (0)