Skip to content

missing spaces in error output related to cleanup policy #8413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brantgurga opened this issue Apr 8, 2025 · 3 comments · Fixed by #8414
Closed

missing spaces in error output related to cleanup policy #8413

brantgurga opened this issue Apr 8, 2025 · 3 comments · Fixed by #8414

Comments

@brantgurga
Copy link

brantgurga commented Apr 8, 2025

[REQUIRED] Environment info

firebase-tools:
14.1.0

Platform:
Linux

[REQUIRED] Test case

Run firebase deploy --only functions from an account without the artifactregistry.repositories.update permission and for which no cleanup policy is set up. When prompted to set up a policy and how many days, accept the default 1 day value.

[REQUIRED] Steps to reproduce

Run the command as indicated.

[REQUIRED] Expected behavior

Error has proper spacing.

[REQUIRED] Actual behavior

Error is missing a spaces between sentences and the space in 'orrun' that should be 'or run'.
Line 294 in

`Functions successfully deployed but could not set up cleanup policy in ` +
appears relevant. Looks like the space is there.
Similar code is at line 200 in
`Functions successfully deployed but could not set up cleanup policy in ` +
and that seems to be where the spacing is missing. Template strings get concatenated but there's no space in the template string so it gets concatenated together.

@google-oss-bot
Copy link
Contributor

This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

@aalej
Copy link
Contributor

aalej commented Apr 8, 2025

Nice catch @brantgurga! There does seem to be a typo on the error message being raised. We'll work on getting that message updated.

@aalej
Copy link
Contributor

aalej commented Apr 9, 2025

This should be fixed in the upcoming releases once next gets merged into master.

@aalej aalej closed this as completed Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants