Skip to content

os: Root.Mkdir creates directories with zero permissions on OpenBSD [1.24 backport] #73570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 2, 2025 · 3 comments
Closed

os: Root.Mkdir creates directories with zero permissions on OpenBSD [1.24 backport] #73570

gopherbot opened this issue May 2, 2025 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.24.4

Comments

@gopherbot
Copy link
Contributor

@jrick requested issue #73559 to be considered for backport to the next 1.24 minor release.

@gopherbot please consider this for backport to 1.24, it prevents Root.Mkdir from working at all considering that Root also has no Chmod method.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 2, 2025
@gopherbot gopherbot mentioned this issue May 2, 2025
Closed
@gopherbot gopherbot added this to the Go1.24.3 milestone May 2, 2025
@neild
Copy link
Contributor

neild commented May 2, 2025

I support this backport: It is low-risk and there is no workaround for the bug.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/669397 mentions this issue: [release-branch.go1.24] os: fix Root.Mkdir permission bits on OpenBSD

@gopherbot gopherbot modified the milestones: Go1.24.3, Go1.24.4 May 6, 2025
@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label May 7, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 7, 2025
gopherbot pushed a commit that referenced this issue May 12, 2025
@jrick @mknyszek
[release-branch.go1.24] os: fix Root.Mkdir permission bits on OpenBSD
431f75a 
Pass missing mode bits in the mkdirat() syscall wrapper.

For #73559
Fixes #73570

Change-Id: I54b1985bd77b1fe5d1a48acab9f2597f8c931854
GitHub-Last-Rev: 669c173
GitHub-Pull-Request: #73565
Reviewed-on: https://go-review.googlesource.com/c/go/+/669375
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Damien Neil <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
(cherry picked from commit f0a9ed7dd89f35c187830742402cfebba9d6d33a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/669397
Reviewed-by: Joel Sing <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 669397 (commit 431f75a) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.24.4
Development

No branches or pull requests
3 participants
@neild @gopherbot @cherrymui