Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit 3de69ba

Browse files
samples: add lint presubmit checks (#297)
* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(java_templates): add lint/static analysis presubmit checks for samples * chore(java_templates): add lint/static analysis presubmit checks for samples * chore: fix trailing whitespace Source-Author: Jeff Ching <[email protected]> Source-Date: Mon Aug 17 14:29:16 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: c3caf0704f25a0c365f1c315e804a30b87c62a75 Source-Link: googleapis/synthtool@c3caf07 * chore(java_templates): stop running pmd/spotbugs checks for samples This was creating too much noise. We will revisit with other options and/or tune these checks. Source-Author: Jeff Ching <[email protected]> Source-Date: Wed Aug 19 12:26:49 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9602086c6c5b05db77950c7f7495a2a3868f3537 Source-Link: googleapis/synthtool@9602086
1 parent df4f4d6 commit 3de69ba

File tree

3 files changed

+21
-6
lines changed

3 files changed

+21
-6
lines changed

.github/workflows/samples.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
on:
2+
pull_request:
3+
name: samples
4+
jobs:
5+
lint:
6+
runs-on: ubuntu-latest
7+
steps:
8+
- uses: actions/checkout@v2
9+
- uses: actions/setup-java@v1
10+
with:
11+
java-version: 8
12+
- name: Run checkstyle
13+
run: mvn -P lint --quiet --batch-mode checkstyle:check
14+
working-directory: samples/snippets

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file
1717
<dependency>
1818
<groupId>com.google.cloud</groupId>
1919
<artifactId>libraries-bom</artifactId>
20-
<version>9.0.0</version>
20+
<version>9.1.0</version>
2121
<type>pom</type>
2222
<scope>import</scope>
2323
</dependency>
@@ -39,7 +39,7 @@ If you are using Maven without BOM, add this to your dependencies:
3939
<dependency>
4040
<groupId>com.google.cloud</groupId>
4141
<artifactId>google-cloud-asset</artifactId>
42-
<version>1.5.1</version>
42+
<version>1.5.2</version>
4343
</dependency>
4444

4545
```
@@ -48,11 +48,11 @@ If you are using Maven without BOM, add this to your dependencies:
4848

4949
If you are using Gradle, add this to your dependencies
5050
```Groovy
51-
compile 'com.google.cloud:google-cloud-asset:1.6.0'
51+
compile 'com.google.cloud:google-cloud-asset:1.5.2'
5252
```
5353
If you are using SBT, add this to your dependencies
5454
```Scala
55-
libraryDependencies += "com.google.cloud" % "google-cloud-asset" % "1.6.0"
55+
libraryDependencies += "com.google.cloud" % "google-cloud-asset" % "1.5.2"
5656
```
5757
[//]: # ({x-version-update-end})
5858

synth.metadata

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/java-asset.git",
7-
"sha": "2484a2cabf09c22f563661d05c1503b6e920fbad"
7+
"sha": "df4f4d66c5b90c90be37550004fe4374d4ca3d1a"
88
}
99
},
1010
{
@@ -59,7 +59,7 @@
5959
"git": {
6060
"name": "synthtool",
6161
"remote": "https://github.com/googleapis/synthtool.git",
62-
"sha": "f8823dec98277a9516f2fb6fae9f58b3a59a23e1"
62+
"sha": "9602086c6c5b05db77950c7f7495a2a3868f3537"
6363
}
6464
}
6565
],
@@ -128,6 +128,7 @@
128128
".github/release-please.yml",
129129
".github/trusted-contribution.yml",
130130
".github/workflows/ci.yaml",
131+
".github/workflows/samples.yaml",
131132
".kokoro/build.bat",
132133
".kokoro/build.sh",
133134
".kokoro/coerce_logs.sh",

0 commit comments

Comments
 (0)