Skip to content

Commit 90bb8ef

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
chore: fix todo comments formatting in model monitoring for batch prediction
PiperOrigin-RevId: 487395425
1 parent 13e2165 commit 90bb8ef

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

google/cloud/aiplatform/jobs.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ def create(
625625
f"{predictions_format} is not an accepted prediction format "
626626
f"type. Please choose from: {constants.BATCH_PREDICTION_OUTPUT_STORAGE_FORMATS}"
627627
)
628-
# TODO: remove temporary import statements once model monitoring for batch prediction is GA
628+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
629629
if model_monitoring_objective_config:
630630
from google.cloud.aiplatform.compat.types import (
631631
io_v1beta1 as gca_io_compat,
@@ -759,7 +759,7 @@ def create(
759759
sync=sync,
760760
create_request_timeout=create_request_timeout,
761761
)
762-
# TODO: b/242108750
762+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
763763
from google.cloud.aiplatform.compat.types import (
764764
io as gca_io_compat,
765765
batch_prediction_job as gca_bp_job_compat,
@@ -2626,7 +2626,7 @@ def update(
26262626
deployed_model_ids=deployed_model_ids,
26272627
)
26282628
)
2629-
# TODO: b/254285776 add optional_sync support to model monitoring job
2629+
# TODO(b/254285776): add optional_sync support to model monitoring job
26302630
lro = self.api_client.update_model_deployment_monitoring_job(
26312631
model_deployment_monitoring_job=current_job,
26322632
update_mask=field_mask_pb2.FieldMask(paths=update_mask),

google/cloud/aiplatform/model_monitoring/alert.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
model_monitoring as gca_model_monitoring_v1,
2121
)
2222

23-
# TODO: remove imports from v1beta1 once model monitoring for batch prediction is GA
23+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
2424
from google.cloud.aiplatform_v1beta1.types import (
2525
model_monitoring as gca_model_monitoring_v1beta1,
2626
)
@@ -47,7 +47,7 @@ def __init__(
4747
self.enable_logging = enable_logging
4848
self.user_emails = user_emails
4949

50-
# TODO: remove config_for_bp parameter when model monitoring for batch prediction is GA
50+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
5151
def as_proto(self, config_for_bp: bool = False):
5252
"""Returns EmailAlertConfig as a proto message.
5353

google/cloud/aiplatform/model_monitoring/objective.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
model_monitoring as gca_model_monitoring_v1,
2323
)
2424

25-
# TODO: b/242108750
25+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
2626
from google.cloud.aiplatform_v1beta1.types import (
2727
io as gca_io_v1beta1,
2828
model_monitoring as gca_model_monitoring_v1beta1,
@@ -199,7 +199,7 @@ def __init__(
199199
self.drift_detection_config = drift_detection_config
200200
self.explanation_config = explanation_config
201201

202-
# TODO: b/242108750
202+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
203203
def as_proto(self, config_for_bp: bool = False):
204204
"""Returns _SkewDetectionConfig as a proto message.
205205

tests/unit/aiplatform/test_jobs.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ def test_batch_predict_gcs_source_and_dest_with_monitoring(
598598
batch_prediction_job.wait()
599599

600600
# Construct expected request
601-
# TODO: remove temporary import statements once model monitoring for batch prediction is GA
601+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
602602
from google.cloud.aiplatform.compat.types import (
603603
io_v1beta1 as gca_io_compat,
604604
batch_prediction_job_v1beta1 as gca_batch_prediction_job_compat,
@@ -635,7 +635,7 @@ def test_batch_predict_gcs_source_and_dest_with_monitoring(
635635
batch_prediction_job=expected_gapic_batch_prediction_job,
636636
timeout=None,
637637
)
638-
# TODO: remove temporary import statements once model monitoring for batch prediction is GA
638+
# TODO(b/242108750): remove temporary re-import statements once model monitoring for batch prediction is GA
639639
from google.cloud.aiplatform.compat.types import (
640640
io as gca_io_compat,
641641
batch_prediction_job as gca_batch_prediction_job_compat,

0 commit comments

Comments
 (0)