Skip to content

Commit a750893

Browse files
authored
[VPlan][LV] Fix invalid truncation in VPScalarIVStepsRecipe (#137832)
Replace CreateTrunc with CreateSExtOrTrunc in VPScalarIVStepsRecipe to safely handle type conversion. This prevents assertion failures from invalid truncation when StartIdx0 has a smaller integer type than IntStepTy. The assertion was introduced by commit 783a846. Fixes #137185
1 parent 6479e9b commit a750893

File tree

2 files changed

+94
-1
lines changed

2 files changed

+94
-1
lines changed

llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2127,7 +2127,7 @@ void VPScalarIVStepsRecipe::execute(VPTransformState &State) {
21272127
Builder.CreateMul(StartIdx0, ConstantInt::get(StartIdx0->getType(),
21282128
getUnrollPart(*this)));
21292129
}
2130-
StartIdx0 = Builder.CreateTrunc(StartIdx0, IntStepTy);
2130+
StartIdx0 = Builder.CreateSExtOrTrunc(StartIdx0, IntStepTy);
21312131
}
21322132

21332133
if (!FirstLaneOnly && State.VF.isScalable()) {
Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt -passes=loop-vectorize -S %s 2>&1 | FileCheck %s
3+
4+
target datalayout = "E-m:a-p:32:32-Fi32-i64:64-n32"
5+
target triple = "powerpc-ibm-aix7.2.0.0"
6+
7+
define void @test_iv_trunc_crash(ptr %a, ptr %b, i32 %n) {
8+
; CHECK-LABEL: define void @test_iv_trunc_crash(
9+
; CHECK-SAME: ptr [[A:%.*]], ptr [[B:%.*]], i32 [[N:%.*]]) {
10+
; CHECK-NEXT: [[ENTRY:.*]]:
11+
; CHECK-NEXT: [[SUM_0:%.*]] = fadd reassoc double 0.000000e+00, 0.000000e+00
12+
; CHECK-NEXT: [[X:%.*]] = load double, ptr [[A]], align 8
13+
; CHECK-NEXT: [[TMP0:%.*]] = sext i32 [[N]] to i64
14+
; CHECK-NEXT: [[TMP1:%.*]] = add nsw i64 [[TMP0]], 1
15+
; CHECK-NEXT: [[SMAX1:%.*]] = call i64 @llvm.smax.i64(i64 [[TMP1]], i64 0)
16+
; CHECK-NEXT: [[TMP2:%.*]] = trunc i64 [[SMAX1]] to i32
17+
; CHECK-NEXT: [[TMP3:%.*]] = add nuw i32 [[TMP2]], 1
18+
; CHECK-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ule i32 [[TMP3]], 8
19+
; CHECK-NEXT: br i1 [[MIN_ITERS_CHECK]], label %[[SCALAR_PH:.*]], label %[[VECTOR_SCEVCHECK:.*]]
20+
; CHECK: [[VECTOR_SCEVCHECK]]:
21+
; CHECK-NEXT: [[TMP4:%.*]] = sext i32 [[N]] to i64
22+
; CHECK-NEXT: [[TMP5:%.*]] = add nsw i64 [[TMP4]], 1
23+
; CHECK-NEXT: [[SMAX:%.*]] = call i64 @llvm.smax.i64(i64 [[TMP5]], i64 0)
24+
; CHECK-NEXT: [[TMP6:%.*]] = trunc i64 [[SMAX]] to i32
25+
; CHECK-NEXT: [[TMP7:%.*]] = icmp slt i32 [[TMP6]], 0
26+
; CHECK-NEXT: [[TMP8:%.*]] = icmp ugt i64 [[SMAX]], 4294967295
27+
; CHECK-NEXT: [[TMP9:%.*]] = or i1 [[TMP7]], [[TMP8]]
28+
; CHECK-NEXT: br i1 [[TMP9]], label %[[SCALAR_PH]], label %[[VECTOR_PH:.*]]
29+
; CHECK: [[VECTOR_PH]]:
30+
; CHECK-NEXT: [[N_MOD_VF:%.*]] = urem i32 [[TMP3]], 8
31+
; CHECK-NEXT: [[TMP10:%.*]] = icmp eq i32 [[N_MOD_VF]], 0
32+
; CHECK-NEXT: [[TMP11:%.*]] = select i1 [[TMP10]], i32 8, i32 [[N_MOD_VF]]
33+
; CHECK-NEXT: [[N_VEC:%.*]] = sub i32 [[TMP3]], [[TMP11]]
34+
; CHECK-NEXT: [[DOTCAST:%.*]] = sitofp i32 [[N_VEC]] to double
35+
; CHECK-NEXT: [[TMP12:%.*]] = fmul reassoc double [[X]], [[DOTCAST]]
36+
; CHECK-NEXT: [[TMP13:%.*]] = fadd reassoc double [[SUM_0]], [[TMP12]]
37+
; CHECK-NEXT: br label %[[VECTOR_BODY:.*]]
38+
; CHECK: [[VECTOR_BODY]]:
39+
; CHECK-NEXT: [[INDEX:%.*]] = phi i32 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
40+
; CHECK-NEXT: [[DOTCAST2:%.*]] = sitofp i32 [[INDEX]] to double
41+
; CHECK-NEXT: [[TMP14:%.*]] = fmul reassoc double [[X]], [[DOTCAST2]]
42+
; CHECK-NEXT: [[OFFSET_IDX:%.*]] = fadd reassoc double [[SUM_0]], [[TMP14]]
43+
; CHECK-NEXT: [[TMP15:%.*]] = fmul reassoc double 7.000000e+00, [[X]]
44+
; CHECK-NEXT: [[TMP16:%.*]] = fadd reassoc double [[OFFSET_IDX]], [[TMP15]]
45+
; CHECK-NEXT: store double [[TMP16]], ptr [[B]], align 8
46+
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i32 [[INDEX]], 8
47+
; CHECK-NEXT: [[TMP17:%.*]] = icmp eq i32 [[INDEX_NEXT]], [[N_VEC]]
48+
; CHECK-NEXT: br i1 [[TMP17]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
49+
; CHECK: [[MIDDLE_BLOCK]]:
50+
; CHECK-NEXT: br label %[[SCALAR_PH]]
51+
; CHECK: [[SCALAR_PH]]:
52+
; CHECK-NEXT: [[BC_RESUME_VAL:%.*]] = phi double [ [[TMP13]], %[[MIDDLE_BLOCK]] ], [ [[SUM_0]], %[[ENTRY]] ], [ [[SUM_0]], %[[VECTOR_SCEVCHECK]] ]
53+
; CHECK-NEXT: [[BC_RESUME_VAL3:%.*]] = phi i32 [ [[N_VEC]], %[[MIDDLE_BLOCK]] ], [ 0, %[[ENTRY]] ], [ 0, %[[VECTOR_SCEVCHECK]] ]
54+
; CHECK-NEXT: br label %[[LOOP_HEADER:.*]]
55+
; CHECK: [[LOOP_HEADER]]:
56+
; CHECK-NEXT: [[SUM_1:%.*]] = phi double [ [[BC_RESUME_VAL]], %[[SCALAR_PH]] ], [ [[SUM_NEXT:%.*]], %[[LOOP_BODY:.*]] ]
57+
; CHECK-NEXT: [[I:%.*]] = phi i32 [ [[BC_RESUME_VAL3]], %[[SCALAR_PH]] ], [ [[I_NEXT:%.*]], %[[LOOP_BODY]] ]
58+
; CHECK-NEXT: [[COND:%.*]] = icmp sgt i32 [[I]], [[N]]
59+
; CHECK-NEXT: br i1 [[COND]], label %[[EXIT:.*]], label %[[LOOP_BODY]]
60+
; CHECK: [[LOOP_BODY]]:
61+
; CHECK-NEXT: store double [[SUM_1]], ptr [[B]], align 8
62+
; CHECK-NEXT: [[SUM_NEXT]] = fadd reassoc double [[SUM_1]], [[X]]
63+
; CHECK-NEXT: [[I_NEXT]] = add i32 [[I]], 1
64+
; CHECK-NEXT: br label %[[LOOP_HEADER]], !llvm.loop [[LOOP3:![0-9]+]]
65+
; CHECK: [[EXIT]]:
66+
; CHECK-NEXT: ret void
67+
;
68+
entry:
69+
%sum.0 = fadd reassoc double 0.0, 0.0
70+
%x = load double, ptr %a, align 8
71+
br label %loop_header
72+
73+
loop_header: ; preds = %loop_body, %entry
74+
%sum.1 = phi double [ %sum.0, %entry ], [ %sum.next, %loop_body ]
75+
%i = phi i32 [ 0, %entry ], [ %i.next, %loop_body ]
76+
%cond = icmp sgt i32 %i, %n
77+
br i1 %cond, label %exit, label %loop_body
78+
79+
loop_body: ; preds = %loop_header
80+
store double %sum.1, ptr %b, align 8
81+
%sum.next = fadd reassoc double %sum.1, %x
82+
%i.next = add i32 %i, 1
83+
br label %loop_header
84+
85+
exit:
86+
ret void
87+
}
88+
;.
89+
; CHECK: [[LOOP0]] = distinct !{[[LOOP0]], [[META1:![0-9]+]], [[META2:![0-9]+]]}
90+
; CHECK: [[META1]] = !{!"llvm.loop.isvectorized", i32 1}
91+
; CHECK: [[META2]] = !{!"llvm.loop.unroll.runtime.disable"}
92+
; CHECK: [[LOOP3]] = distinct !{[[LOOP3]], [[META1]]}
93+
;.

0 commit comments

Comments
 (0)