Skip to content

ER: In HDFStore create warnings for mode, quiet #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jul 25, 2013 · 5 comments · Fixed by #4417
Closed

ER: In HDFStore create warnings for mode, quiet #4367

jreback opened this issue Jul 25, 2013 · 5 comments · Fixed by #4417
Labels
Error Reporting Incorrect or improved errors from pandas IO HDF5 read_hdf, HDFStore
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

  • If mode == 'w' and warn==True then weird raw_input is requested. Change this to raise/warn as appropriate
  • change the _quiet field (default is False) to a warning (about duplicates in readback)
@jtratner
Copy link
Contributor

When I was looking at this before, was thinking that store could change mode from w after opening so that it doesn't overwrite on a second write. (i.e., at end of the handle open part, just change mode to whatever seems appropriate - user can change mode explicitly if they want...)

@jreback
Copy link
Contributor Author

jreback commented Jul 26, 2013

I always open as append mode (personally)

I simulate w by removing the file

I think that might be the way to go here

then u don't need to track status of the mode

@jreback
Copy link
Contributor Author

jreback commented Jul 31, 2013

@jtratner changed the API slightly on open/closes....let me know if you think it makes sens

@jtratner
Copy link
Contributor

I think I proposed it but then never got to it, because I wasn't sure what real-world uses would do.

@jtratner
Copy link
Contributor

heh, so what I proposed is actually at the top of this issue 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants