Skip to content

CLN: Remove special handling of nans in the float64-case of isin #22117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 10, 2018
Merged

CLN: Remove special handling of nans in the float64-case of isin #22117

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f950de
CLN: Remove special handling of nans in the float64-case of isin
realead Jul 29, 2018
6791a2c
adding performance tests for isin in combination with float64
realead Jul 30, 2018
f4ab903
adding bug-id to unit test
realead Jul 30, 2018
9f5524d
tweaking tests
realead Aug 4, 2018
567e7bb
pep8 problems
realead Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding bug-id to unit test
  • Loading branch information
@realead
realead committed Aug 9, 2018
commit f4ab90336b36735c5bdf16fbf7dd2bc463119f17
1 change: 1 addition & 0 deletions pandas/tests/test_algos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,7 @@ def test_different_nan_objects(self):
tm.assert_numpy_array_equal(expected, result)

def test_different_nans_as_float64(self):
# GH 21866
# create different nans from bit-patterns,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the issue number as a comment here

# these nans will land in different buckets in the hash-table
# if no special care is taken
Expand Down