Skip to content

Do not call TyCtxt::type_of() on a trait #14830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Do not call TyCtxt::type_of() on a trait #14830

merged 1 commit into from
May 18, 2025

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented May 17, 2025 •
edited by rustbot
Loading

changelog: [useless_as_ref]: fix ICE on trait method

Fixes #14828

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 17, 2025
@samueltardieu
Copy link
Contributor Author

r? @Alexendoo
This has been caused by b768fbe which is part of Clippy nightly since yesterday (after the last sync).

@flip1995 We've had two ICE reported already, maybe we'll need an out-of-cycle sync to fix this if we receive some more.

@rustbot rustbot assigned Alexendoo and unassigned blyxyas May 18, 2025
@Alexendoo Alexendoo added this pull request to the merge queue May 18, 2025
@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 18, 2025
Merged via the queue into rust-lang:master with commit 618ccd7 May 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clippy failed when computing type
4 participants
@samueltardieu @rustbot @Alexendoo @blyxyas