Skip to content

Commit 03e1342

Browse files
BorisChioumoz-wptsync-bot
authored andcommitted
Part 2: Implement Animate for track lists on grid-template-{columns|rows}.
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1348519#c6 and w3c/csswg-drafts#3201: Currently grid-template-rows/columns interpolate “per computed value”, which means that if the number of tracks differs, or any track changes to/from a particular keyword value to any other value, or if a line name is added/removed at any position, the entire track listing is interpolated as “discrete”. But we "agree" with two more granular options: 1. Check interpolation type per track, rather than for the entire list, before falling back to discrete. I.e. a length-percentage track can animate between two values while an adjacent auto track flips discretely to min-content. 2. Allow discrete interpolation of line name changes independently of track sizes. Besides, for the repeat() function, it's complicated to support interpolation between different repeat types (i.e. auto-fill, auto-fit) and different repeat counts, so we always fall-back to discrete if the first parameter of repeat() is different. Depends on D16339 Differential Revision: https://phabricator.services.mozilla.com/D16129 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1348519 gecko-commit: bd4efc854419ae1643bfaeeedc67403703575ea0 gecko-integration-branch: central gecko-reviewers: emilio
1 parent 976b09a commit 03e1342

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

web-animations/animation-model/animation-types/property-list.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -679,18 +679,6 @@ const gCSSProperties = {
679679
{ type: 'discrete', options: [ [ '". . a b" ". .a b"', 'none' ] ] }
680680
]
681681
},
682-
'grid-template-columns': {
683-
// https://drafts.csswg.org/css-template/#grid-template-columns
684-
types: [
685-
{ type: 'discrete', options: [ [ '1px', '5px' ] ] }
686-
]
687-
},
688-
'grid-template-rows': {
689-
// https://drafts.csswg.org/css-template/#grid-template-rows
690-
types: [
691-
{ type: 'discrete', options: [ [ '1px', '5px' ] ] }
692-
]
693-
},
694682
'height': {
695683
// https://drafts.csswg.org/css21/visudet.html#propdef-height
696684
types: [

0 commit comments

Comments
 (0)