| commit | 35585b15a00ec9022b1b9488e2a2edf23f205240 | [log] [tgz] |
|---|---|---|
| author | Andrey Kulikov <[email protected]> | Tue May 31 21:03:32 2022 +0100 |
| committer | Andrey Kulikov <[email protected]> | Tue May 31 22:30:22 2022 +0100 |
| tree | 11f03b7122b63569bb2ebd06ade709f313d2df08 | |
| parent | 45ed5a4f044db7733bb4f41ff074fd11e67d4ce2 [diff] |
Fix currentCompositeKeyHash changing after inner recomposition inside movable content. Because of that the state restoration is essentially broken inside movable contents now. There were two issues: 1) when we invoke movable content we were starting movable group, then starting a new group with compositionLocalMapKey and only then changing the compoundKeyHash to movableContentKey. This ordering is incorrect as we need to update compoundKeyHash right after we entered movable group and before we entered another group as it has its own key which should be applied for the compoundKeyHash. the same reordering should be done when we exit groups. 2) When recomposition happens there is a logic for calculating the compound key for the group. And it is recursively going from this group to parent till it finds the movable content group (see compoundKeyOf()). And it never happened as groupCompoundKeyPart() was returning not the stable movableContentKey as it is done during the initial composition, but a hashCode of MovableContent holder object. It is incorrect, so we have to detect that we reached movable content group and return the expected key manually. Fixes: 234223545 Test: new test in MovableContentTests Change-Id: I6a43146c80c9bfda818f07256a06c691521ccf89
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.