Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
[Actor] differentiate cancelled vs finished tasks
Bug: 435765746
Change-Id: I2ca20017520a3f4c1ffeb9158d704530122218bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819976
Commit-Queue: Christine Ying <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497949}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1754492369-416172ac96647cc32175a052ffbf68a26de78582-1a8bdc4f2b9d9b5b57d90d5397a05761631527b9.profdata to chrome-win64-main-1754502670-00c8f66cbfc8b1574217d63ed448d67abd7c3de6-096e8db36a5f17fc8336839dc5caccd0c1d825f1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I911eee805d03d3924b761c15c2dc36d587c2d64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825732
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497948}
Disallow browser controls from scrolling off on desktop android
Some websites don't properly account for dynamic viewports, resulting
from browser controls that can scroll off screen. Chrome already
disallows browser controls from scrolling off screen in desktop
windowing mode, however, this is currently opaque to Blink.
This CL adds a new flag, default enabled on desktop android and default
disabled otherwise, to disallow top controls from scrolling off screen
on large tablets by setting the top toolbar min height equal to the
toolbar height on large tablets.
Low-Coverage-Reason: EXPERIMENTAL_CODE
Bug: 386142033, 436900619, 374135077
Change-Id: I9f8276f73d8e4159586721d979cb12f798ef362a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825782
Auto-Submit: Theresa Sullivan <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Reviewed-by: Sirisha Kavuluru <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497947}
Roll Perfetto from 9b818254a49c to 35d2dad8cba2 (3 revisions)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/9b818254a49c..35d2dad8cba2
2025-08-06 [email protected] stdlib: Make static_freq generic across CPUs (#2448)
2025-08-06 [email protected] tp: update android_special_classes with graph.scan and add heap_graph.class_relationship module (#2444)
2025-08-06 [email protected] tp: fix bad performance of startup breakdowns in large android trace (#2447)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:434979529
Tbr: [email protected],[email protected]
Change-Id: I8687f2642f6ed39825365e0a40ad7a62b4dc0d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826101
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497946}
[CleanUp] Reduce use of glic service in actor
This is one of 2 CLs that attempts to refactor and centralize how actor
consumes messages from glic. We want one entrypoint method, as we don't
want actor to access the glic service to re-fetch state in other places.
Bug: b:436308813
Change-Id: Ie6e866cca613950d066c7be777fc2ae16c26cc14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824303
Reviewed-by: Kevin Graney <[email protected]>
Reviewed-by: Maggie Jennings <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: Christine Ying <[email protected]>
Commit-Queue: Aashna Sheth <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497945}
[A11y] Remove aleventhal from a11y OWNERS
Bug: none
Change-Id: I6135a7fc2e08f6000355422db8af85668f4e3fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824071
Commit-Queue: Tzarial <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Reviewed-by: Tzarial <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497944}
Roll ANGLE from bc7e86b13827 to 7a193b06c425 (2 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/bc7e86b13827..7a193b06c425
2025-08-06 [email protected] Unthrottle validation error messages for all of Chromium
2025-08-06 [email protected] tests: Skip PbufferDifferentConfig on system EGL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:436292490
Tbr: [email protected]
Test: Test: angle_end2end_tests \
Change-Id: Ia454d1281d94380e0e866da501746164c92faa9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825935
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497943}
Add protection to prevent crash when refreshing battery info
The current implementation uses the vid/pid as a key to match an input
device with a Bluetooth device. This can lead to a device mismatch,
where the system attempts to read battery information from a Bluetooth
device that lacks it, causing a crash.
This change adds protective code to prevent the crash until a more
robust device-matching approach is adopted.
Bug: 435054249
Change-Id: Ibf331f5f7b34a4c19041210a818e86c15f98ebb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6817843
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Yun-hao Chung <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497942}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1754488781-29edd5521e3765ec9c485b2da403250c6b36c8f7-f52cbf9a1f13ce5039810bd62fb4244425f2a88c.profdata to chrome-mac-arm-main-1754502670-b95eb1ab3feb6d610b5826837bd836043be05bfe-096e8db36a5f17fc8336839dc5caccd0c1d825f1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I18a03642c70ea1c18d5cc03926ca0a7fbcf66968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825245
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497941}
[webaudio-testharness] Migrate audioparam-close.html to testharness.js
Convert
webaudio/the-audio-api/the-audioparam-interface/audioparam-close.html
from the legacy audit.js runner to pure testharness.js
Bug: 396477778
Change-Id: Ia54cdbe1fc1621ce586e1604d9c257b756b6dc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680970
Reviewed-by: Michael Wilson <[email protected]>
Commit-Queue: Saqlain <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497940}
[webaudio-testharness] Migrate audioparam-summingjunction.html
Convert third_party/blink/web_tests/external/wpt/webaudio
/the-audio-api/the-audioparam-interface/audioparam-summingjunction.html
from the legacy audit.js runner to pure testharness.js
Bug: 396477778
Change-Id: I842785b69deb8a9ea6f68f7fc644e0b9238a5ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6771062
Commit-Queue: Saqlain <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Reviewed-by: Michael Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497939}
Preconnect: Add suzukikeita@ to OWNERS
Bug: n/a
Change-Id: I1cf4766159401871cd513f54e288693bdedb169e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824164
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Kouhei Ueno <[email protected]>
Auto-Submit: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497938}
Ensure glic pinned underlines never show when floaty is closed
Bug: b:436930023
Change-Id: I7b7f50a7e1a25b9b3e9b6ec9b3662ee0532be288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825291
Commit-Queue: Anthony Cui <[email protected]>
Reviewed-by: Ian Wells <[email protected]>
Commit-Queue: Ian Wells <[email protected]>
Auto-Submit: Anthony Cui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497937}
Settings: Fix search bubble aggregate count.
The logic was assuming that all search hits that should be reflected in
a search bubble come from the same SearchRequest object. This assumption
is no longer true with the new Settings "plugin" architecture where
different SearchRequest objects need to be reflected on the same search
bubble. Fixed by storing the number of previous hits directly on the
bubble element itself usinsg a 'data-result' attirbute, instead of
storing it on the SearchRequest object.
Bug: 424223101
Change-Id: Idcc88f0c0bdb7a5a325523517c7a4f16b0f0fff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825805
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Teresa Mao <[email protected]>
Commit-Queue: Teresa Mao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497936}
Roll clank/internal/apps from f7eadeea33dd to b61e625c71d0 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/f7eadeea33dd..b61e625c71d0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
No-Try: true
Change-Id: Ied796762ba72697c159a41e2195d70a74bf19c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825373
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1497935}
Make ModelList changes atomically
This avoids having DataSetObservers trigger before the changes are
complete, and fixes a bug where the DataSetObserver would destroy the
popup because the menu was (temporarily) empty.
Demo: https://screencast.googleplex.com/cast/NDc5Nzk0OTM0NjMxNjI4OHw5NzMyZGFmMC0zNA
Bug: 402164499
Change-Id: I6f275088746569bdaaf25417edb39fa3eca52aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822505
Commit-Queue: Jenna Himawan <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497934}
ash/drive: base/hash/md5 -> crypto/obsolete/md5
The new API is functionally identical and is a replacement for the
deprecated base/hash/md5 API. I did make one minor tweak here: instead
of constructing an intermediate string to pass into a single call of the
hash function, I used the streaming interface and passed each part of
the intermediate string in separately. The results should be equivalent.
Bug: 406729261
Change-Id: I6b5bc5e06823f2c133a03b590cc4d238e15a39bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6823556
Commit-Queue: François Degros <[email protected]>
Reviewed-by: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497933}
Reset ScopedObserver when window is destroyed
Change-Id: I389734cc7ef5c2a47f8661b46633a6bfb25d4382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822208
Reviewed-by: Ryo Hashimoto <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497932}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1754511045-0585440e600803a3be8fba7ef12ca88f0f83eadb-3d549f38bbd1f8be56b0f0f656facc63d37c1ce7.profdata to chrome-android64-main-1754515953-8c8e75ba844b0cb12309ded78dfb9e7341e9de82-a1cd5dd02af565d161902479172dc8327ccb1fe1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ie3e05cad37495676c7c60d40e79771f71b1d066b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825932
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497931}
Roll Chrome Android ARM64 Orderfile from Vrultxol_0agIZNpg... to vH4VqcKSFfR036LSF...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I6bd5dbfa8c8944aab9a42c4dbb882dcda3707c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826044
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497930}
Reland "Draw HistoryActivity edge-to-edge"
This reverts commit 7d955fb856f224c6f9008357547edc524fe3bb0f.
Reason for revert: Relanding excluding automotive since edge-to-edge is not yet enabled on auto.
Bug: 433563241
Original change's description:
> Revert "Draw HistoryActivity edge-to-edge"
>
> This reverts commit 51b70addaaec4b0ba2e12633992d907d4a3649c4.
>
> Reason for revert: b/436647786
>
> Bug: 433563241
> Original change's description:
> > Draw HistoryActivity edge-to-edge
> >
> > https://screenshot.googleplex.com/nurwB7PJMx9Jcjf.png
> > https://screenshot.googleplex.com/8v5eWBc3D5i4wzi.png
> > https://screencast.googleplex.com/cast/NTkxMjcwMDQ1NzU4MjU5Mnw5ODAzN2IwMS0wZg
> >
> > Bug: 433563241
> > Change-Id: I3a587a21b8a7cc2ec1ceeef3fad0cc8cc334d498
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6792749
> > Reviewed-by: Wenyu Fu <[email protected]>
> > Commit-Queue: Charles Hager <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1497131}
>
> Bug: 433563241
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ia8de724186770c85a32ba3c2602cea9c6e04df8d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822374
> Bot-Commit: Rubber Stamper <[email protected]>
> Owners-Override: Mei Liang <[email protected]>
> Auto-Submit: Mei Liang <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1497225}
Bug: 433563241
Change-Id: Icfb381460db4ddd6d56ca99ea5d5ade526bfb5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822654
Commit-Queue: Charles Hager <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497929}
Roll compiler-rt from 693bb2c75d48 to 0cf143592518 (3 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/693bb2c75d48..0cf143592518
2025-08-06 [email protected] [ubsan_minimal] Allow UBSan handler from Minimal runtime to accept arguments (#152192)
2025-08-06 [email protected] [sanitizer_common] Disable SanitizerCommon lsan tests on Apple arm64 (#151929)
2025-08-05 [email protected] [sanitizer] Don't TestPTrace() if SPARC; don't give up if internal_fork() fails (#152072)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/compiler-rt-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id4eedfbd349c9befcde390618cc6e652ede93e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825909
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497928}
[CVC storage IOS] New 'Save security code' infobar (local card)
Bug: 432109188, 431857697
Mock: https://screenshot.googleplex.com/DzA6wgj8bdBpeNB
Implementation: https://screenshot.googleplex.com/d2CTypXghM8iBwE
Change-Id: I4dd08a21a752e5df1b176a6ef498663e64330312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803228
Reviewed-by: Olivia Saul <[email protected]>
Commit-Queue: Yiwen Qian <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497927}
Import wpt@37dc10d8d727f94b7a8c13402a5cff0f7c6a589c
https://github.com/web-platform-tests/wpt/compare/09ca6b36a...37dc10d8d
Using wpt-import in Chromium 4b58b73a4d1ec19df57255aba13038a320c96175.
With Chromium commits locally applied on WPT:
c182cb38dc "Add the ::interest-hint pseudo element for interest [...]
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected]:
external/wpt/cookies/partitioned-cookies
[email protected], [email protected]:
external/wpt/css/css-conditional
[email protected]:
external/wpt/css/css-text/i18n
external/wpt/css/css-writing-modes
[email protected], [email protected]:
external/wpt/css/CSS2
NOAUTOREVERT=true
No-Export: true
Validate-Test-Flakiness: skip
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I36a306199a92d61e05bc99adac3d5c29f1c15b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824346
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497926}
Extend multiple input related histograms
Fixed: 436259919, 436259979, 436260635
Change-Id: Id448892e3fc6af7a24c10e8827d5c814d09aeb98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825286
Reviewed-by: Gavin Williams <[email protected]>
Auto-Submit: Jimmy Gong <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497925}
[BNPL][Ephemeral] Add methods to open and close Ephemeral Tab
On Clank, when a user selects a Buy Now, Pay Later (BNPL) issuer,
we redirect them to the issuer's website using the ephemeral tab. This
change provides methods to open and close the ephemeral tab and
includes an EphemeralTabObserver to listen for URL navigation.
Design:go/clank-bnpl-ephemeral-tabs-engineering-design
Bug: 430575808
Change-Id: I16d2ee9a85fc235788a9404d4e7140dbdb82c79e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6800014
Reviewed-by: Jinsuk Kim <[email protected]>
Reviewed-by: Vinny Persky <[email protected]>
Reviewed-by: Stephen McGruer <[email protected]>
Commit-Queue: Viplav Kadam <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497924}
docs: Create foundational knowledge base for developers and agents
This commit introduces a new set of documentation and tooling to improve
the developer experience for both humans and AI agents working in the
Chromium codebase.
The core of this change is a new, structured knowledge base designed to improve the effectiveness of the agent's built-in Retrieval-Augmented
Generation (RAG). This includes:
- A new `agents/prompts/knowledge_base.md` file that provides high-level,task-oriented guidance for core Chromium concepts like the build system, dependency management, and Mojo IPC.
- A suite of imported, canonical documentation from external sources
(like the GN repository) cached in `docs/imported/`. This provides a
stable, in-tree reference for foundational tools.
Currently only the gn style guide is provided there.
Eventually this should go away if web_fetch becomes widely available
to agentic coders in Chromium, as the agent could fetch Docs on
demand from https://gn.googlesource.com/gn/+/refs/heads/main/docs/.
- New high-level overview documents for `//tools`, `//docs/debugging.md`,
and the source tree layout to improve discoverability.
These changes are linked in the agent's core `common.md` prompt, making
the new knowledge base directly accessible to AI assistants. This
structured approach enables both humans and agents to more efficiently
find relevant information, tools, and architectural patterns.
Need to use "No-Presubmit: true" any time we update the docs
(we added a presubmit.py rule to prevent hand-editing of the
imported docs).
Bug: 435509437
No-Presubmit: true
Change-Id: I932eda79f2108bb29b2bf3061de0de3bfe6053aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6808155
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Reviewed-by: Jesse McKenna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497923}
[HFM] Add testing config for Ask-before-HTTP dialog UI
Bug: 351990829
Change-Id: I3cb249265aa34c1767da311af61a868d3d9c4e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821044
Commit-Queue: Chris Thompson <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Elly FJ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497922}
Roll Perfetto Trace Processor Win from daa021374bd0 to 9b818254a49c
https://android.googlesource.com/platform/external/perfetto.git/+log/daa021374bd0..9b818254a49c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I8b828a9024d0fa975ccd3c6b6b1f3f5e6905e0ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825289
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497921}
Roll Chromium Variations from ouKP2vp0v1Tjmbd3O... to LnCBXvnhiJJvnt0q7...
https://chrome-infra-packages.appspot.com/p/chromium/chrome/test/data/variations/cipd/+/LnCBXvnhiJJvnt0q721jtJ7zgryfyVVsTyETm-3ZOn8C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-variations-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Variations: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Id520bcb76488899c0db9d8f7d2f366217b25484e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825738
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497920}
[AIM] Send query to AIM via postMessage
Pipes the text query from the composebox to the LensComposeBox
controller which then creates and serializes the proto that is then
piped through to the AIM remote UI via postMessage. Note, the
handshake with the remote UI will come in a follow up.
For more information, see design at http://shortn/_IGKvU6jPC3
Bug: 435504019
Change-Id: I073a7b481aa9a87dba68530e02e0ba0ba6735dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819884
Reviewed-by: Juan Mojica <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Duncan Mercer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497919}
Disable flaky GlicFreControllerUiTest.PressNoThanksButton
Bug: 436190211
Change-Id: I53078ae1a83120df409ab2a194424947767760d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825544
Reviewed-by: Anthony Cui <[email protected]>
Commit-Queue: Nick Birnie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497918}
[Masonry] Implement align/justify content
This change implements align/justify-content for masonry layout. This is
implemented as an offset on all items based on the delta between the
intrinsic masonry size and the container size.
Existing web_tests are very thorough, but are missing cases for safe
alignment, which this change adds.
Bug: 343257585
Change-Id: I8c888ca996fcc270b85096ccd04237121a0917ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6799118
Reviewed-by: Alison Maher <[email protected]>
Commit-Queue: Kurt Catti-Schmidt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497917}
[Accessibility] Refactor accessible name logic in BrowserAccessibilityAndroid
This patch refactors the logic for determining how an accessible name
is mapped to Android's accessibility properties. The new private
function, `ComputeAndroidNameTo`, centralizes this logic, improving
readability and maintainability.
The result of this computation is now cached to avoid redundant
calculations, leading to a minor performance improvement. This change is
purely a refactoring and does not alter any existing functionality.
Bug: None
Change-Id: I47789d8334e62bf1f85736d8b3759c234a82849d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822761
Commit-Queue: Lucas Radaelli <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497916}
Reland "Use @EXECUTE-AND-WAIT-FOR directives in MD component accessibility tests"
This reverts commit b305315b1a4e7e9f0e7801ab0ebb48db27d16b8a.
Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/6824704 disabled the test that caused the revert.
Original change's description:
> Revert "Use @EXECUTE-AND-WAIT-FOR directives in MD component accessibility tests"
>
> This reverts commit 32ae3f16cbd6c60806747ab0f86405df2220c63e.
>
> Reason for revert: Causes content_browsertests failures on gardened bots. E.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/57846/overview
>
> Original change's description:
> > Use @EXECUTE-AND-WAIT-FOR directives in MD component accessibility tests
> >
> > The DumpAccessibilityTree tests for the MD components landed without any
> > interaction/changes in the test. Testing interactivity is covered in the
> > DumpAccessibilityEvents tests for MD components. However, because the
> > latter does not currently support Blink, we have no means to compare
> > the before and after Blink trees. Using @EXECUTE-AND-WAIT-FOR in the
> > DumpAccessibilityTree tests provides that missing coverage.
> >
> > Change-Id: Ic0425cb61f95de17c5f74714a5bc59abdd12b060
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818372
> > Commit-Queue: Joanmarie Diggs <[email protected]>
> > Reviewed-by: Tzarial <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1497694}
>
> Change-Id: I3bed9216691ce9c1cad209ef5d7b6c57fd81776e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825384
> Owners-Override: Noah Rose Ledesma <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Noah Rose Ledesma <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1497842}
Change-Id: I1989a2635d3f6aa3841817c8ede9f0e1ebde6724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825025
Commit-Queue: Tzarial <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Joanmarie Diggs <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497915}
Clean up CustomTabs.Minimized.ReceivedIntentReusingSession
Bug: 417217534
Change-Id: Ieb9eb426e552aa80ac4636861fc07d7808b3081e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825368
Reviewed-by: Wenyu Fu <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497914}
Roll android_deps from ywLef-7rK_zL0qLcT... to z2eZxYkJGXQWXch6O...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/android-deps-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: I5007c0aa4629e5144bf956f9453db43dcd38a84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825347
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497913}
[WebInstallAPI] Create Install Not Supported Dialog for off-the-record
(OTR) profiles
Create new `WebAppInstallNotSupportedDialog` and
`WebAppInstallNotSupportedDialogDelegate`.
- Shows when navigator.install is invoked from an OTR profile.
- See UX review doc [1] page 7 for mocks and more details.
- Dialog creation is initiated by `WebInstallServiceImpl` after it
validates with `AreWebAppsUserInstallable` that the user is on a
OTR profile such as incognito and guest mode.
- Once the dialog is accepted and closes, `ServiceImpl` is notified
and returns `kAbortError` which prevents incognito/guest mode detection.
This CL also updates the `ChromePageInfoUiDelegate` so that the web
install permission shows as "Not allowed" in the Page Info for OTR
profiles.
Feature flag - WebAppInstallation
Demo gif:
https://drive.google.com/file/d/1icDW03OZl8sY3huq7DtKGbmPFGGaRElC/view?usp=sharing
[1] UX Review doc:
https://docs.google.com/document/d/167APSoaq-qbcrw6jNn0t01vaB_ZdehIy2JYHnhb-8fk/edit?pli=1&tab=t.0
Explainer:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WebInstall/explainer.md
Dev Spec:
https://docs.google.com/document/d/12nSXJLm8mW0gWZ_yjlXfrV8r9gwJliVt4WVa-209-KA/edit?usp=sharing
Chrome Status:
https://chromestatus.com/feature/5183481574850560
Bug: 333795265, 402547563
Change-Id: Ie3e288eae1b30a9f15521eefb27962c205c2f7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785408
Reviewed-by: Lia Hiscock <[email protected]>
Reviewed-by: Lu Huang <[email protected]>
Commit-Queue: Kristin Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497912}
ash: delete DemoModeAAExperimentBasedOnStoreId
This code was responsible for registering a synthetic field trial named
DemoModeAAExperimentBasedOnStoreId with the client divided into either
experiment or control arms based on the lowest bit of:
md5(demo_mode::StoreNumber() + "fae448044d545f9c")
There doesn't appear to be any code elsewhere in Chromium that changes
behavior based on this value, nor any other references to the field
trial. There is also no apparent server-side behavior for this
experiment. It is therefore likely that this code is dead and can be
safely deleted.
Bug: None
Change-Id: I0a6ebc27e2d8a98245ba0eec9a9ad4f017ac262f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825310
Reviewed-by: Li Lin <[email protected]>
Commit-Queue: Elly FJ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497911}
[CVC storage IOS] New 'Save security code' infobar (server card)
Bug: 432109188, 431857697
Mock: https://screenshot.googleplex.com/6yZBAi36xsW4jFu
Implementation: https://screenshot.googleplex.com/VaFWypAauKbN48m
Change-Id: I0432ee489b9ae899a9681e211fc30acfaf3b47f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6795764
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Yiwen Qian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497910}
[ScrollPrediction] Prep work for turning the feature ON.
This CL contains some preemptive fixes that are needed for turning the
feature ON. It also adds a constant (based on experimentation, see
crrev.com/c/6179645) that will be used for latency calculation.
Bug: 392817528
Change-Id: Idae2546640bb6cdf67f9faeb65ea0fbff05e538e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819710
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Rahul Arakeri <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497909}
Automated Commit: LKGM 16374.0.0-1070798 for chromeos.
CrOS Changes (16373.0.0-1070779 -> 16374.0.0-1070798):
- External: http://go/cros-changes/78487..78506?ext=true
- Internal: http://go/cros-changes/112185..112204
Uploaded by https://ci.chromium.org/b/8707278109437499025
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-brya-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-volteer-chrome
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-octopus-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-jacuzzi-rel
CrOS-LKGM: 16374.0.0-1070798
Merge-Approval-Bypass: Automated LKGM update
Cr-Original-Build-Id: 8707278109437499025
CrOS-External-Manifest-Position: 78506
CrOS-Internal-Manifest-Position: 112204
Change-Id: I1e4a4faaf5e3a83756e228e70b9661307705edfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824813
Commit-Queue: ChromeOS Prod (Robot) <[email protected]>
Bot-Commit: ChromeOS Prod (Robot) <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497908}
Roll TFLite to Next Green Version
Version Changes:
cpuinfo: 33ed0be77d7767d0e2010e2c3cf972ef36c7c307 to e414c0446436ed34151de3158d18f8ae32e55d03
FP16: 0a92994d729ff76a58f692d3028ca1b64b145d91 to b3720617faf1a4581ed7e6787cc51722ec7751f0
XNNPACK: ae40b1a2d93d5c516bc7657c6c3eea1470f917ae to 63e7e89ddc0cf5671d2659cd34a3eb64a008dd63
tflite: e979aba360252470603b339cc22c9f3b380fcc69 to 31c004ea019ea2499d3e16aeb6a28604e8c7afbc
Bug: 388311883
Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux;luci.chrome.try:optimization_guide-mac-arm64;luci.chrome.try:optimization_guide-mac-x64;luci.chrome.try:optimization_guide-win32;luci.chrome.try:optimization_guide-win64
Include-Ci-Only-Tests: chromium.android:android-pie-arm64-rel|android_browsertests
Change-Id: I04b25dcb912ac738a3683eaae86b9c76894af108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822281
Commit-Queue: Raj T <[email protected]>
Reviewed-by: Zekun Jiang <[email protected]>
Auto-Submit: Raj T <[email protected]>
Commit-Queue: Zekun Jiang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497907}
[iOS] Move customization photo framing files to correct directory
These files were in the model/ directory, when the mediators should have
been in coordinator/ and the mutator/data objects should have been in
ui/.
Bug: none
Change-Id: I381d586fa2a280ede5e0683158a7b73a533ecdbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824134
Commit-Queue: Robbie Gibson <[email protected]>
Reviewed-by: Adam Arcaro <[email protected]>
Auto-Submit: Robbie Gibson <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497906}
Readd blink_python_tests to rts_banned_suites
This test looks like it was accidentally removed in
https://crrev.com/c/6063046. Readd it.
Bug: None
Change-Id: Ia7dacf24c39eeadf4ec688e907f0ceaf0d8a4456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443165
Commit-Queue: Struan Shrimpton <[email protected]>
Reviewed-by: Prakhar Asthana <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497905}
[CLAMS] Add an additional layer to cast Object to appropriate classes.
This CL adds an new class AiCoreSessionWrapper between the native
session and the java session. This class is responsible for casting
Object into appropriate classes like InputPieces and handling the
connection between JNI. With this change, the internal implementation
doesn't need to handle object casting.
Bug: 425408635
Change-Id: I53c7652e3674f65d170e9af82cd0d2d075b9ac70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6820301
Commit-Queue: Xinghui Lu <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497904}
[webauthn] Roll enclave
Bug: 399818721
Change-Id: Id74b3bc2ee6b2667544a2cba1e632c59965f8b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821415
Reviewed-by: Martin Kreichgauer <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497903}
More miscellaneous cleanup in WebAudio codebase
This should cause no functional change.
This CL performs some follow-up fixes promised in previous CLs:
- crrev.com/c/3565058
- crrev.com/c/3583279
- crrev.com/c/3577934
Fixes include:
- Convert DCHECK(0) to NOTREACHED()
- Change declaration order
- Remove comment that is no longer applicable
Change-Id: I95e3a86e64fffbd566f209a77a6b921f36e80cae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825622
Commit-Queue: Michael Wilson <[email protected]>
Reviewed-by: Matt Reynolds <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497902}
Roll Chrome Android ARM64 Orderfile from Ew7p2FAEJqnGKBxqu... to Vrultxol_0agIZNpg...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I4f74f8e114facaeb0c8983aa7b4ae2428e2454a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825474
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497901}
[glic] Add metrics for GetContextFromFocusedTab errors
The "Glic.Api.RequestCounts.GetContextFromFocusedTab" metric shows a
high rate of "Request handling exception caught" events. This generic
error makes it difficult to diagnose the underlying causes. Manual
testing indicates that the "web contents changed" error is a significant
contributor, especially in Live mode where users may navigate while a
query is in flight.
To provide better insight, this change introduces a new histogram,
Glic.Api.GetContextFromFocusedTab.Error.{Mode}, which breaks down the
exceptions by cause. A new enum, GlicGetContextFromFocusedTabError, is
added to categorize the specific errors:
- PermissionDeniedWindowNotShowing
- TabNotFound
- PermissionDeniedContextPermissionNotEnabled
- PermissionDenied
- WebContentsChanged
The new metric is segmented by the last known user input mode (Text or
Audio) to help differentiate behavior between interaction styles. This
is achieved by tracking the last used input mode within GlicMetrics.
Bug: 433328453
Change-Id: I498d834db364dcac33a074785509f3a71aed7e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6810456
Reviewed-by: David Pennington <[email protected]>
Reviewed-by: Dan Harrington <[email protected]>
Commit-Queue: Nick Birnie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497900}