Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
[WebNN] Emulate multi-dimensions blockwise quantization and dequantization
This CL emulates multi-dimensions blockwise quantization and
dequantization by using `resize` operator with `nearest` mode to
blockwise expand the dimension. With this emulation, the returned error
can be removed from `AddDequantizeOrQuantizeLinearOperation()`.
Bug: 433096244, 433055137
Change-Id: If48ceda399d3acd3db7dfb9cf29d1391cf1d7f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6797812
Reviewed-by: Phillis Tang <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Rafael Cintron <[email protected]>
Commit-Queue: Wei4 Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497316}
[NvidiaLinux] Use BufferUsage::SCANOUT for GMB video frames to support NVIDIA drivers
On Linux, GpuMemoryBuffer video frames created with
BufferUsage::SCANOUT_CPU_READ_WRITE implicitly request
GBM_BO_USE_LINEAR, which is incompatible with rendering on certain
NVIDIA drivers.
This incompatibility prevents rendering in CEF shared texture and video
capture pipelines.
Switching to BufferUsage::SCANOUT avoids GBM_BO_USE_LINEAR while
retaining GBM_BO_USE_RENDERING, GBM_BO_USE_SCANOUT, and
GBM_BO_USE_TEXTURING, enabling Skia-based rendering and texture interop
to work correctly with NVIDIA drivers.
To support this a new value kPreferSharedImageWithNativeHandle, was
added to the BufferFormatPreference enum, which indicates that the
consumer prefers buffers with exportable GPU native handles (e.g.,
DMABUF FDs on Linux). These buffers may not be CPU mappable, but are
better suited for GPU interop scenarios such as Vulkan, Skia, or
offscreen rendering with shared textures.
The preference is propagated through the capture pipeline:
Start() receives the BufferFormatPreference from the client.
This preference is passed to VideoFramePool, then to
RenderableGpuMemoryBufferVideoFramePool.
FrameResources::Initialize() uses this to choose between
SCANOUT_CPU_READ_WRITE (default) and SCANOUT, depending on whether CPU
access is required.
The default behavior remains unchanged (i.e. CPU access is assumed
unless otherwise specified). Clients like Chromium Embedded Framework
(CEF) or GPU only consumers can now specify
kPreferSharedImageWithNativeHandle to request buffers that are not CPU
accessible but support efficient GPU interop.
Bug: 428022619
Test:
FrameSinkVideoCapturerTest.BufferFormatPreferencePassedToGpuFramePool,
RenderableGpuMemoryBufferVideoFramePoolTest.RequiresCpuAccessAffectsBufferUsage
Change-Id: I7975173ed38300ce6fa995b530ada2c85a2cea27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6681354
Reviewed-by: Ted (Chromium) Meyer <[email protected]>
Commit-Queue: Anantanarayanan Iyengar US <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497315}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1754416640-dc4a19a5ced016304cf9c392ce0f1d387b8d9486-bb2c195887ca100d73de96972b6b19f64ca1cd91.profdata to chrome-android32-main-1754438291-bc27ba95432f58504b9773b757d7de7ccff3106a-f1d0cdd45d788cba03faaa896d9a0c21c88b9114.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ida86aeb14f2d948d5a7a49fc890390590c0996dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822269
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497314}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1754423968-083a71df9ad3bdb79a66723dc4fbb124ffad6c09-464200e950ef4ae270dc8da96987731bac505f36.profdata to chrome-mac-arm-main-1754430892-0a848ae935212a4730ba2735884e56a130f331fc-27b45fb631e098de0d8799970f4f908b0297419a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I6634547172d4662c21d1fe78b70933b57b228ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822509
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497313}
Roll Chrome Android Desktop x64 PGO Profile
Roll Chrome Android Desktop x64 PGO profile from chrome-android-desktop-x64-main-1754416640-53a3339946a9dbcfbfc2e7a1750fa73df4b49e94-bb2c195887ca100d73de96972b6b19f64ca1cd91.profdata to chrome-android-desktop-x64-main-1754438291-eec23c1a23ecea6e4970a523bd98c7871fb8fcb8-f1d0cdd45d788cba03faaa896d9a0c21c88b9114.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-desktop-x64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Idc928aad48d9f1cc4aebc90ca5e6f60583ff9ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822741
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497312}
Remove Prerender2NewTabPageTriggerV2 in fieldtrial_testing_config.json
Remove the experiment Prerender2NewTabPageTriggerV2 as NTP on-hover
prerender trigger is going to be replaced by on-hover prefetch, and the
experiment has been expired.
Bug: 421941586
Change-Id: I5000d3b0779ebe7d10c07443989fb53b446f10ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821113
Reviewed-by: Shunya Shishido <[email protected]>
Commit-Queue: Huanpo Lin <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497311}
Roll Chrome Android ARM64 Orderfile from q_1s4WYkUH8ERvKEh... to iqaWX9Sicr6ccs-dy...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ibb4a896b504c9a3e7f9716ca373082f5f3473259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822774
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497310}
Clean up features::kBookmarkTriggerForPrerender2 and introduce features::kBookmarkTriggerForPrerender2KillSwitch
This CL does
1. Remove `features::kBookmarkTriggerForPrerender2` as the
feature has been enabled by default. And it is no longer needed.
2. With removal of the feature flag, it is still desired to have a kill
switch to have a way to disable in case of emergency.
`features::kBookmarkTriggerForPrerender2KillSwitch` is introduced in
`BookmarkBarPreloadPipeline::StartPrerender` to do so.
Bug: 40259793
Change-Id: I2af922338277e25aa3a868a8139da59929dd624d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818916
Commit-Queue: Huanpo Lin <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497309}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1754405933-7c3ac3ccb3bf8292b324801ce30a33f383fba26e-c150bcef2c236b3f486f140abb2cd525ee8bdba2.profdata to chrome-win32-main-1754416640-27c9d59e2e8e3ea17771682a0d3d4d5e676a564d-bb2c195887ca100d73de96972b6b19f64ca1cd91.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I400611042f2c1b3e226a4fa205f85423c0625c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822187
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497308}
Add a default case for all switch statements in ts
Starting with ts, because the change is already quite substantial.
The styleguide requires that all switch statements *must* have a default case.
We would like to turn on the linter for this styleguide, but need to fix all
the missing cases first. Styleguide:
https://google.github.io/styleguide/tsguide.html#switch-statements
For cases where it was just falling through, we used:
default:
break;
For cases where it was returning something (that cannot be undefined),
we used:
default:
assertNotReached();
This change should be a noop change.
NO_IFTTT=styleguide change, no modification to underlying enum
This CL was uploaded by git cl split.
[email protected]
Bug: 436274263
Change-Id: I9d6c705a590fe26dddb6fac7eff66b04efaa2b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822549
Auto-Submit: Fred Shih <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497307}
Add a default case for all switch statements in ts
Starting with ts, because the change is already quite substantial.
The styleguide requires that all switch statements *must* have a default case.
We would like to turn on the linter for this styleguide, but need to fix all
the missing cases first. Styleguide:
https://google.github.io/styleguide/tsguide.html#switch-statements
For cases where it was just falling through, we used:
default:
break;
For cases where it was returning something (that cannot be undefined),
we used:
default:
assertNotReached();
This change should be a noop change.
NO_IFTTT=styleguide change, no modification to underlying enum
This CL was uploaded by git cl split.
[email protected]
Bug: 436274263
Change-Id: Id8ccf19da2333e6cf98a1eee3302e44b33896e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822450
Commit-Queue: Wes Okuhara <[email protected]>
Auto-Submit: Fred Shih <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497306}
a11y: dump the entire tree for all mathml examples
In preparation for further work in the platform mappings, expose the
full Blink tree in dump accessibility tree tests.
Also, remove the dump accessibility node tests that become redundant
with this change.
[email protected], [email protected]
Bug: b/436620270
Test: cq
Change-Id: I42e18f84a4a1320134e6469e9ab451f020101b87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821899
Reviewed-by: Lucas Radaelli <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497305}
[build] Only copy libc++ headers in the default toolchain
This change modifies the build configuration to only copy libc++ headers
when the current toolchain is the default toolchain. This avoids
redundant work in multi-toolchain builds.
Dependencies on the header copy targets are updated to explicitly refer
to the default toolchain.
Bug: 411014827
Change-Id: I76ab7688149bc7bd946b0060ef9ea6110e1a5d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821133
Reviewed-by: Matt Stark <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Auto-Submit: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497304}
[PDF] Rename PdfRectangle to PdfRect
Shorten the name, so it is more like gfx::Rect.
Change-Id: I0e0929681a144a10515b81d2be3f4972afcf32df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819576
Reviewed-by: Andy Phan <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497303}
[iOS] Fix Default Browser off-cycle test failure
The Default Browser off-cycle promo registration test in
default_browser_promo_scene_agent_unittest was failing on newer OS
versions but old SDKs. The problem was that the feature code had both an
SDk version preprocessor guard while the test only had a runtime API
check, causing a mismatch in the logic being run and the test
expectations. The fix is to use the availability check helper in the
test instead of checking the API availability directly, so that the test
expectations always match the logic being run by the feature.
Bug: 436180582
Change-Id: I627caa4f3b1dacd8fbdb55605e067f35c253cead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819090
Reviewed-by: Robbie Gibson <[email protected]>
Commit-Queue: Guillaume Jenkins <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497302}
Revert "siso: update to version 1.3.12"
This reverts commit be0d23742daddde982478861aae4f58782f77f31.
Reason for revert:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-extended-tracing-rel/93660/overview
```
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/browser/browser/save_file_manager.o.d -D__STDC_CONSTANT_MACROS -...(too long)
clang++: error: no such file or directory: '../../content/browser/download/save_file_manager.cc'
clang++: error: no input files
remote-exec 82384a6b6655bfb1b0d3023107ba674802614a10830fa406e91897c66d526b92/355 failed: exit=1
error: 1 steps failed: remote-exec 82384a6b6655bfb1b0d3023107ba674802614a10830fa406e91897c66d526b92/355 failed: exit=1
```
Bug: 436113143
Original change's description:
> siso: update to version 1.3.12
>
> ukai@ukai ...src/infra/infra % git log --oneline \
> 887a10bc8a038d8e330d06d1ad5ae6ec646f3040..948637c5fe0dcb9b5de28268939dfaff907bb11c \
> go/src/infra/build/siso
> 948637c5fe [Siso] execute: Wrap errors with more context
> 9b8228f35c siso: fix version
> 53d8543752 siso: show credential type
> ffe8181001 siso: remove go.chromium.org/luci dependency.
> 54b407a89d siso: cache-write continue on error
> 986a68d348 siso: use luci-auth binary instead of go.chromium.org/luci/auth
> 5d38d46d12 revive clang -M deps scanning for scandeps unprocessable inputs
> 7a27a1d596 siso: cache-write cleanup unused test files
> aa4502abb9 siso: cache-write rename nit followups
> 7b33956acb siso: fix backtrace for siso_build.pprof
> 11658bdfb7 siso: rename local-upload to cache-write followup
> 2c2137c587 siso: remove dependency to go.chromium.org/luci/cipd/version
> 8eca0bbaa1 siso: fix noctx lint error in reapi/reapi_test.go
> 40cbf77425 siso: fix noctx lint error after 6799580 merge
> d687cb68af siso: update version string to v1.3.12
>
> Bug: 436113143
> Change-Id: Ia7342bff4069ca1d99cc9a893505c91bd97d7e02
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6820441
> Auto-Submit: Fumitoshi Ukai <[email protected]>
> Reviewed-by: Takuto Ikuta <[email protected]>
> Commit-Queue: Fumitoshi Ukai <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1497290}
Bug: 436113143
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I45764634c021e06d583c52fb291382ac086c4ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819941
Auto-Submit: Fumitoshi Ukai <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497301}
java_cpp_enum: Support IS_POSIX and fix a bug on empty line handling
- Allow enum to have BUILDFLAG(IS_POSIX) ifdefs in it.
- Fix a crash bug that happens if an empty line exists before the last
ignored ifdefs.
Bug: 422035179
Test: java_cpp_enum_tests.py
Change-Id: I89d4ec778722b46e07448ad35bf6babb519c7663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6791387
Commit-Queue: Keigo Oka <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497300}
Roll RE2 from c2c6a2eb663f to 85c7c0fb1163 (2 revisions)
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/c2c6a2eb663f..85c7c0fb1163
2025-08-05 [email protected] re2: prepare to tag 2025-08-05
2025-08-05 [email protected] python: require Python 3.9+
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/re2-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Id9309a926fea5948cabbf6989664cba46a3dc063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822568
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497299}
Enable IndexedDB getAllRecords() API
... for the intent to ship in Chrome 141.
https://groups.google.com/a/chromium.org/g/blink-dev/c/h9Xk1cFORh0/m/j3kja3OvDAAJ
Bug: 40746016
Change-Id: If3ddf29139db9191341afa43e539c0d94a0a5635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819706
Reviewed-by: Dan Clark <[email protected]>
Commit-Queue: Steve Becker <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497298}
[TabStrip] Update keyboard reorder backing shape
Update keyboard reorder backing shape.
-Uses the same color as the tab strip background, so we don't have
overlapping issues and also don't see the backing shape popping in then
out during the reorder.
Fixed: 436640364
Change-Id: Ia67bffb5d9b0ef2f4937df2421a70d0c573aadcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821568
Reviewed-by: Jenna Himawan <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497297}
[PDF] Encapsulate PdfRectangle
Turn PdfRectangle from a struct into a class. Take various functions
like ScalePdfRectangle() and SwapPdfRectangleValuesIfNeeded() and make
them part of the class.
Change-Id: Icb87a398448c70eba48e98b909cdefcbc6776cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818842
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Andy Phan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497296}
[First Run Bookmark Import] Add InitialPreferences::GetBookmarksBlock
This CL adds the GetBookmarksBlock method to load Bookmarks Block from
Initial Preferences file upon first run.
Fixed: 433262898
Change-Id: I1f5c7727584a4c899b45599668512bb777697f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6793224
Reviewed-by: Kaan Alsan <[email protected]>
Commit-Queue: Atharv Maan <[email protected]>
Reviewed-by: Daniel Soromou <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497295}
When Payment app is present the details shown in header will change.
Title will change to `Pay instantly without QR upload` if at least
1 Payment app is present.
Google Pay icon is shown if at least 1 eWallet is present. In case only
payment app are present Google Pay icon is hidden.
SingleEwallet:
https://screenshot.googleplex.com/Afo7omQxRJdHf82.png
Single Payment app:
https://screenshot.googleplex.com/48eveLfw8WGpyJQ.png
Ewallet + Payment App:
https://screenshot.googleplex.com/ANwMGWayYMXxgmm
Multiple Payment App:
https://screenshot.googleplex.com/4vdADduvxepCDcW.png
Mocks:
https://docs.google.com/presentation/d/1G1vd9IrZLnAfpGoRjs-s7wqqXNA6KZhrqgH4pXMYpAM/edit?slide=id.g35fd1f514f2_0_136#slide=id.g35fd1f514f2_0_136
Bug: 433617327
Change-Id: I51da22f08ebe6702560bc487162d6b40deb9be7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6790187
Reviewed-by: Junhui He <[email protected]>
Auto-Submit: Tushar <[email protected]>
Reviewed-by: Siddharth Shah <[email protected]>
Commit-Queue: Tushar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497294}
Roll vulkan-deps from ffd86bf82322 to 1909eee37eb8 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ffd86bf82322..1909eee37eb8
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/97e96f9e9defeb4bba3cfbd034dec516671dd7a3..a7361efd139bf65de0e86d43b01b01e0b34d387f
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/3aeaaa088d37b86cff036eee1a9bf452abad7d9d..cb2f796b2d6da09a4fea123b061f177f767e63c8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],radial-bots+[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel
Bug: None
Tbr: [email protected],radial-bots+[email protected],[email protected]
Change-Id: If7d5647468027bae3f86e2c4d1c4e1e080dace4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822185
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497293}
Roll Perfetto Trace Processor Win from 734eb2bcaeee to a34053856f7c
https://android.googlesource.com/platform/external/perfetto.git/+log/734eb2bcaeee..a34053856f7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie0543c7c293677d0f3ce7f83ba63f787213b2778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821886
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497292}
[download] Fix SavePackage::TruncateBaseNameToFitPathConstraints
Resolves long-standing issues with filename truncation in SavePackage:
* Fix encoding-unaware truncation on POSIX systems by using UTF-8 safe
truncation with base::TruncateUTF8ToByteSize() to respect character
boundaries instead of unsafe byte-level substr().
* Replace hardcoded filesystem constants with runtime queries using
base::GetMaximumPathComponentLength() in
ComputeMaxPathLengthForDirectory() when blocking I/O is allowed (file
threads).
* Implement two-tier architecture: runtime filesystem queries during
path selection and conservative platform defaults during save operations
to avoid blocking I/O on UI thread.
* Add proper UTF-8 encoding conversion on POSIX (AsUTF8Unsafe/FromUTF8Unsafe)
with fallback handling for edge cases.
* Update comments and method names for clarity between blocking
(ComputeMaxPathLengthForDirectory) and non-blocking
(GetMaxPathLengthForDirectory) variants.
* Add comprehensive test coverage for UTF-8 truncation, edge cases, and
cross-platform compatibility including Fuchsia support.
Bug: 41258047
Change-Id: I9772618bc9eae0e48f0b85a6d0ccee82d057a276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6809425
Commit-Queue: Ho Cheung <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497291}
siso: update to version 1.3.12
ukai@ukai ...src/infra/infra % git log --oneline \
887a10bc8a038d8e330d06d1ad5ae6ec646f3040..948637c5fe0dcb9b5de28268939dfaff907bb11c \
go/src/infra/build/siso
948637c5fe [Siso] execute: Wrap errors with more context
9b8228f35c siso: fix version
53d8543752 siso: show credential type
ffe8181001 siso: remove go.chromium.org/luci dependency.
54b407a89d siso: cache-write continue on error
986a68d348 siso: use luci-auth binary instead of go.chromium.org/luci/auth
5d38d46d12 revive clang -M deps scanning for scandeps unprocessable inputs
7a27a1d596 siso: cache-write cleanup unused test files
aa4502abb9 siso: cache-write rename nit followups
7b33956acb siso: fix backtrace for siso_build.pprof
11658bdfb7 siso: rename local-upload to cache-write followup
2c2137c587 siso: remove dependency to go.chromium.org/luci/cipd/version
8eca0bbaa1 siso: fix noctx lint error in reapi/reapi_test.go
40cbf77425 siso: fix noctx lint error after 6799580 merge
d687cb68af siso: update version string to v1.3.12
Bug: 436113143
Change-Id: Ia7342bff4069ca1d99cc9a893505c91bd97d7e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6820441
Auto-Submit: Fumitoshi Ukai <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Commit-Queue: Fumitoshi Ukai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497290}
[PDF] Change some offset calculations to return gfx::Vector2dF
CalculateScaledClipBoxOffset() and CalculateNonScaledClipBoxOffset()
currently return gfx::PointF to represent the offset. It would be better
to use gfx::Vector2dF.
Improve the code along the way:
- Auto-format
- Improve comments
- Declare variables closer to where used
Change-Id: I641c988aa0db6c8c381c5c531c3bdd58ed8b9c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6816389
Reviewed-by: Andy Phan <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497289}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1754427225-ed0d4dab58b93ddcb466e70b2280ce001d2d4817-49f743e6f7376142a5bd7a136a7116815371a47d.profdata to chrome-android64-main-1754432480-323d76a49e8419c2de1bb9e6992b0d5e0a1aa0ed-7d955fb856f224c6f9008357547edc524fe3bb0f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3bfbaedb3f2e6c0b3a2ab9a14ccce04873bbe0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822484
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497288}
[PDF] Modernize and encapsulate SetDefaultClipBox()
Change SetDefaultClipBox() to GetDefaultClipBox() and remove the
out-parameter. Then move it into an anonymous namespace. Delete its unit
test, as its behavior is already being tested by the unit test for
CalculateMediaBoxAndCropBox().
Change-Id: Icfea8ade06f082e92bf251209ee8681606bcc8cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819417
Reviewed-by: Andy Phan <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497287}
Roll Chrome Android ARM64 Orderfile from UlPg767tW2OJwjxGn... to q_1s4WYkUH8ERvKEh...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I2b7cdaa3dc967e9f18e2ed29abbf03e7d652ebcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822560
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497286}
Disable ContentFaviconDriverTest.DoNotRemoveMappingIfStopped
This test recently became flaky: https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fchrome%2Ftest%3Abrowser_tests%2FContentFaviconDriverTest.DoNotRemoveMappingIfStopped
Bug: 434752631
Change-Id: Ie7f4406a623a9073504a755b06e37b5ae74ef83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821482
Commit-Queue: Reilly Grant <[email protected]>
Owners-Override: Reilly Grant <[email protected]>
Reviewed-by: Mike Wasserman <[email protected]>
Commit-Queue: Mike Wasserman <[email protected]>
Auto-Submit: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497285}
Revert "Manual roll ANGLE from b6b2f380814e to 35023c8ab484 (1 revision)"
This reverts commit 982c99a9c5c9948b5f85013271586e53d4c60fd1.
Reason for revert: May break conformance/misc/type-conversion-test.html
Cq-Include-Trybots: luci.chrome.try:fuchsia-webgl-sherlock
Bug: None
Original change's description:
> Manual roll ANGLE from b6b2f380814e to 35023c8ab484 (1 revision)
>
> Manual roll requested by [email protected]
>
> https://chromium.googlesource.com/angle/angle.git/+log/b6b2f380814e..35023c8ab484
>
> 2025-08-04 [email protected] Throttle validation error messages in release builds
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/angle-chromium-autoroll
> Please CC [email protected],[email protected] on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
> Bug: None
> Tbr: [email protected]
> Change-Id: I27a9defcceb30bf152735dffb32e9de71b75c790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821515
> Bot-Commit: chromium-autoroll <[email protected]>
> Commit-Queue: Shahbaz Youssefi <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1497068}
Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Change-Id: I2a9a91b82c6b7a9a38fd4bf89f1fb10e64f6644b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822000
Commit-Queue: Zijie He <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497284}
Implement browser_window_interface_iterator.h:GetAll..WindowInterfaces
The implementation calls into Java ChromeAndroidTaskTracker, which is
the source of truth that maintains all live BrowserWindowInterfaces.
Bug: 435264038
Change-Id: I37d7755d27c7a5294da18e55d6b9da6641fe9937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819887
Commit-Queue: Linyu He <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497283}
Clean up launched `CopyImageFilenameToClipboard` feature flag.
This CL cleans up the launched `CopyImageFilenameToClipboard` feature
flag. The feature launched in M134 (https://crrev.com/c/6187922).
Bug: 400502444
Change-Id: I20ef360d58abe4ab54b211ebda552233bc41163e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821759
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497282}
Disable ChromeContentBrowserClientTest.SecurityCheckExceptionForAllowlistedUrls
It's flaky, and appears to have been broken by a recent change. See the
test history:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fchrome%2Ftest%3Abrowser_tests%2FProtocolHandlerTest.SecurityCheckExceptionForAllowlistedUrls
Bug: 434758587
Change-Id: I12e90cbd4b6a673d5d9c98458bb2c7bd9925a8a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821527
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Reviewed-by: Mike Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497281}
Add BUILD_OWNERS for //chrome/browser/ui/browser_window
BUILD files under //chrome/browser/ui/browser_window contains both
Android and cross-platform targets. This CL adds BUILD_OWNERS to
streamline code reviews, e.g., Android CLs that touch BUILD files
won't require cross-platform code owners.
Change-Id: I39ab53e23a8579c575ff6ecc1d22569b1c6ed1f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821884
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Auto-Submit: Linyu He <[email protected]>
Commit-Queue: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497280}
Roll clank/internal/apps from 86740fe4cfe2 to 21da233e631a (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/86740fe4cfe2..21da233e631a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
No-Try: true
Change-Id: I3f7e4a92530b8a7f30f7b93326e8530b84e4647f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822566
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1497279}
Clean up launched `RetainOmniboxOnFocus` feature flag.
This CL cleans up the launched `RetainOmniboxOnFocus` feature flag. The
feature launched in M136 (https://crrev.com/c/6335041).
Bug: 427497741
Change-Id: I9b4afad2542b3fbae1fe1f566a5d574feff91e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821558
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497278}
[DX12 Enc] Add Flush() support.
Support Flush() API with D3D12 VEA.
Bug: 40275246
Change-Id: If369e4c15c00d7a9f32cd52bacf8679dc0a31723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6810325
Reviewed-by: Eugene Zemtsov <[email protected]>
Commit-Queue: Jianlin Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497277}
Roll Enterprise Companion chromium_win_x86_64 from c6fb8bBjJbS3FTvo7... to P1KR_Mpi1jjRjvYCO...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/ceca-chromium-win-x86-64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Enterprise Companion chromium_win_x86_64: https://g-issues.chromium.org/issues/new?component=1604672&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-enterprise-companion-try-builder-dbg;luci.chromium.try:linux-enterprise-companion-try-builder-rel;luci.chromium.try:mac-enterprise-companion-try-builder-dbg;luci.chromium.try:mac-enterprise-companion-try-builder-rel;luci.chromium.try:win-enterprise-companion-try-builder-dbg;luci.chromium.try:win-enterprise-companion-try-builder-rel
Tbr: [email protected]
Change-Id: I41e8605e19444c69137dc9e4cc245501e51e1917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822557
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497276}
Remove FakeChromeUserManager from CrostiniTestHelper.
The class was deprecated. CrostiniTestHelper takes a Profile instance
so the user must be created beforehand. Now callers have responsibility
to create needed Users.
BUG=425160398
TEST=Tryjob
Change-Id: I73e80fdc07897290ac4569829f1719c78f8df872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6817920
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497275}
Roll Enterprise Companion chromium_mac_amd64 from ZXik2MzB8S6g1-HZA... to Mdbtvu7-pJUze7pKE...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/ceca-chromium-mac-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Enterprise Companion chromium_mac_amd64: https://g-issues.chromium.org/issues/new?component=1604672&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-enterprise-companion-try-builder-dbg;luci.chromium.try:linux-enterprise-companion-try-builder-rel;luci.chromium.try:mac-enterprise-companion-try-builder-dbg;luci.chromium.try:mac-enterprise-companion-try-builder-rel;luci.chromium.try:win-enterprise-companion-try-builder-dbg;luci.chromium.try:win-enterprise-companion-try-builder-rel
Tbr: [email protected]
Change-Id: I5e3157de63486bda55e40b663cd884966f8796b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822502
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497274}
Roll Enterprise Companion chromium_win_x86 from YoKJcQ41yn2CLo3UE... to wMOaOefFIUALEZFQ6...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/ceca-chromium-win-x86-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Enterprise Companion chromium_win_x86: https://g-issues.chromium.org/issues/new?component=1604672&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-enterprise-companion-try-builder-dbg;luci.chromium.try:linux-enterprise-companion-try-builder-rel;luci.chromium.try:mac-enterprise-companion-try-builder-dbg;luci.chromium.try:mac-enterprise-companion-try-builder-rel;luci.chromium.try:win-enterprise-companion-try-builder-dbg;luci.chromium.try:win-enterprise-companion-try-builder-rel
Tbr: [email protected]
Change-Id: Ice3fb101a09392f84787f61580a821f267dcbf81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822503
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497273}
Fix DSE icon handling discrepancy on IOS
Screen: http://screen/C48QGybamuMhF6C.png
Change-Id: I25a342932b8d414f64fe9a5a33ee92221ef4b780
Fixed: 436591107, 422992330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821916
Reviewed-by: Michael Wojcicka <[email protected]>
Reviewed-by: Robbie Gibson <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Owners-Override: Robbie Gibson <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497272}
Roll Enterprise Companion chromium_mac_arm64 from kPgLQAjvoRkS1vb_C... to TipoR97RttJOrr39y...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/ceca-chromium-mac-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Enterprise Companion chromium_mac_arm64: https://g-issues.chromium.org/issues/new?component=1604672&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-enterprise-companion-try-builder-dbg;luci.chromium.try:linux-enterprise-companion-try-builder-rel;luci.chromium.try:mac-enterprise-companion-try-builder-dbg;luci.chromium.try:mac-enterprise-companion-try-builder-rel;luci.chromium.try:win-enterprise-companion-try-builder-dbg;luci.chromium.try:win-enterprise-companion-try-builder-rel
Tbr: [email protected]
Change-Id: I3fbc6c41403c63a1a96c1dbc679111b9cc02f066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822556
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497271}
Make pix account linking pref local
Target Milestone: M140
Since users have pix accounts linked in Wallet
only on one of their devices, keeping the pref synced to profile results
in losing the opportunity to show it on the right device that is used
for making Pix transactions. This CL changes the pref to local only.
Fixed: 435461727
Change-Id: I228507d74626297d9bb6de8e09143266d67017d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6807452
Reviewed-by: Olivia Saul <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Auto-Submit: Siddharth Shah <[email protected]>
Commit-Queue: Siddharth Shah <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497270}
Roll Enterprise Companion chromium_linux64 from c-3HHiNKBHRve_MJr... to Zf0sHTROh4aRqgDix...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/ceca-chromium-linux64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Enterprise Companion chromium_linux64: https://g-issues.chromium.org/issues/new?component=1604672&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-enterprise-companion-try-builder-dbg;luci.chromium.try:linux-enterprise-companion-try-builder-rel;luci.chromium.try:mac-enterprise-companion-try-builder-dbg;luci.chromium.try:mac-enterprise-companion-try-builder-rel;luci.chromium.try:win-enterprise-companion-try-builder-dbg;luci.chromium.try:win-enterprise-companion-try-builder-rel
Tbr: [email protected]
Change-Id: I1033a177180c0c112d9805703e0233d0896e0cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822555
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497269}
[CLAMS] Propagate GenerateOptions to Android Session
There isn't a generic mojo utility for converting c++ mojo struct to
java[1], so disassemble the struct in c++ and reassemble it in java.
Only passing the parameters that are supported on Android (max_output_tokens). max_output_tokens is equivalent to targetReplyLengthMax in AiCore.
[1]
https://chromium.googlesource.com/chromium/src/mojo/+/HEAD/public/java/bindings/README.md#missing-type-conversions-structtraits
Bug: 425408635
Change-Id: I413ebbda254bb1d9a719652b57968631e65cdff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819592
Commit-Queue: Xinghui Lu <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497268}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1754416640-d415ba2d1c7a4ed2ce64467de8259cc8b1977276-bb2c195887ca100d73de96972b6b19f64ca1cd91.profdata to chrome-mac-arm-main-1754423968-083a71df9ad3bdb79a66723dc4fbb124ffad6c09-464200e950ef4ae270dc8da96987731bac505f36.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I131f62d203308eeaeb8c1f5b27deec7867b4614a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822069
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497267}