Google Git
Sign in
chromium / chromium / src / 19f15cf75d5c89a376e197e5d2faf4bf0d4448d3
commit19f15cf75d5c89a376e197e5d2faf4bf0d4448d3[log] [tgz]
authorJenna Himawan <[email protected]>Thu Aug 07 00:07:44 2025
committerChromium LUCI CQ <[email protected]>Thu Aug 07 00:07:44 2025
treea2d3d29920b72c105d14ed44a2fe2e85abc623e3
parent73bcd28e5eee369b5e2c9cd374900ad754efae51 [diff]
Make ModelList changes atomically

This avoids having DataSetObservers trigger before the changes are
complete, and fixes a bug where the DataSetObserver would destroy the
popup because the menu was (temporarily) empty.

Demo: https://screencast.googleplex.com/cast/NDc5Nzk0OTM0NjMxNjI4OHw5NzMyZGFmMC0zNA

Bug: 402164499
Change-Id: I6f275088746569bdaaf25417edb39fa3eca52aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6822505
Commit-Queue: Jenna Himawan <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497934}
3 files changed
tree: a2d3d29920b72c105d14ed44a2fe2e85abc623e3
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.