Google Git
Sign in
chromium / chromium / src / 579eeb1ef1c019f78c26508ee1543f24dc0e9008
commit579eeb1ef1c019f78c26508ee1543f24dc0e9008[log] [tgz]
authorKristin Lee <[email protected]>Wed Aug 06 23:13:53 2025
committerChromium LUCI CQ <[email protected]>Wed Aug 06 23:13:53 2025
tree4964b2973ef7207f55e7efd26e29dfc6999c35af
parent5bd503a5e126a5799313277a33f87b71e4eb66e5 [diff]
[WebInstallAPI] Create Install Not Supported Dialog for off-the-record
(OTR) profiles

Create new `WebAppInstallNotSupportedDialog` and
`WebAppInstallNotSupportedDialogDelegate`.
- Shows when navigator.install is invoked from an OTR profile.
- See UX review doc [1] page 7 for mocks and more details.
- Dialog creation is initiated by `WebInstallServiceImpl` after it
validates with `AreWebAppsUserInstallable` that the user is on a
OTR profile such as incognito and guest mode.
- Once the dialog is accepted and closes, `ServiceImpl` is notified
and returns `kAbortError` which prevents incognito/guest mode detection.

This CL also updates the `ChromePageInfoUiDelegate` so that the web
install permission shows as "Not allowed" in the Page Info for OTR
profiles.

Feature flag - WebAppInstallation
Demo gif:
https://drive.google.com/file/d/1icDW03OZl8sY3huq7DtKGbmPFGGaRElC/view?usp=sharing

[1] UX Review doc:
https://docs.google.com/document/d/167APSoaq-qbcrw6jNn0t01vaB_ZdehIy2JYHnhb-8fk/edit?pli=1&tab=t.0

Explainer:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WebInstall/explainer.md

Dev Spec:
https://docs.google.com/document/d/12nSXJLm8mW0gWZ_yjlXfrV8r9gwJliVt4WVa-209-KA/edit?usp=sharing

Chrome Status:
https://chromestatus.com/feature/5183481574850560

Bug: 333795265, 402547563
Change-Id: Ie3e288eae1b30a9f15521eefb27962c205c2f7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6785408
Reviewed-by: Lia Hiscock <[email protected]>
Reviewed-by: Lu Huang <[email protected]>
Commit-Queue: Kristin Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497912}
12 files changed
tree: 4964b2973ef7207f55e7efd26e29dfc6999c35af
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.