Google Git
Sign in
chromium / chromium / src / 786d57fc01cb6d5f077ed345b2c41c0664bfbefa
commit786d57fc01cb6d5f077ed345b2c41c0664bfbefa[log] [tgz]
authorNick Birnie <[email protected]>Wed Aug 06 22:47:19 2025
committerChromium LUCI CQ <[email protected]>Wed Aug 06 22:47:19 2025
treebdb31aa56be667adc47bff7ce8414628dd23c8a4
parentca2b4464049660f7ee6b9bcefc16597a61fb853e [diff]
[glic] Add metrics for GetContextFromFocusedTab errors

The "Glic.Api.RequestCounts.GetContextFromFocusedTab" metric shows a
high rate of "Request handling exception caught" events. This generic
error makes it difficult to diagnose the underlying causes. Manual
testing indicates that the "web contents changed" error is a significant
contributor, especially in Live mode where users may navigate while a
query is in flight.

To provide better insight, this change introduces a new histogram,
Glic.Api.GetContextFromFocusedTab.Error.{Mode}, which breaks down the
exceptions by cause. A new enum, GlicGetContextFromFocusedTabError, is
added to categorize the specific errors:
 - PermissionDeniedWindowNotShowing
 - TabNotFound
 - PermissionDeniedContextPermissionNotEnabled
 - PermissionDenied
 - WebContentsChanged

The new metric is segmented by the last known user input mode (Text or
Audio) to help differentiate behavior between interaction styles. This
is achieved by tracking the last used input mode within GlicMetrics.

Bug: 433328453
Change-Id: I498d834db364dcac33a074785509f3a71aed7e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6810456
Reviewed-by: David Pennington <[email protected]>
Reviewed-by: Dan Harrington <[email protected]>
Commit-Queue: Nick Birnie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1497900}
16 files changed
tree: bdb31aa56be667adc47bff7ce8414628dd23c8a4
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.