Post task to show the extension uninstall dialog a little later.

Post task to show the extension uninstall dialog a little later.

BUG=121544
TEST=See bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131221

[Yoyo Zhou, 2012-04-06 01:16:17]

I can't help but feel that this is a hack, but it seems to no longer crash.

[Robert Sesek, 2012-04-06 14:15:07]

https://chromiumcodereview.appspot.com/10012033/diff/2001/chrome/browser/exte...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

https://chromiumcodereview.appspot.com/10012033/diff/2001/chrome/browser/exte...
chrome/browser/extensions/extension_disabled_ui.cc:255:
base::Unretained(uninstall_dialog_.get()), extension_));
Is Unretained safe here?

[Yoyo Zhou, 2012-04-06 19:10:44]

http://codereview.chromium.org/10012033/diff/2001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

http://codereview.chromium.org/10012033/diff/2001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_disabled_ui.cc:255:
base::Unretained(uninstall_dialog_.get()), extension_));
On 2012/04/06 14:15:07, rsesek wrote:
> Is Unretained safe here?

This object isn't getting deleted unless the extension is reloaded or
uninstalled in the meantime, which seems unlikely, but I suppose we could make
the uninstall dialog refcounted if you're worrieda bout that.

[Robert Sesek, 2012-04-06 20:53:39]

http://codereview.chromium.org/10012033/diff/2001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

http://codereview.chromium.org/10012033/diff/2001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_disabled_ui.cc:255:
base::Unretained(uninstall_dialog_.get()), extension_));
On 2012/04/06 19:10:45, Yoyo Zhou wrote:
> On 2012/04/06 14:15:07, rsesek wrote:
> > Is Unretained safe here?
> 
> This object isn't getting deleted unless the extension is reloaded or
> uninstalled in the meantime, which seems unlikely, but I suppose we could make
> the uninstall dialog refcounted if you're worrieda bout that.

You could use a WeakPtrFactory<T> instead.

[Yoyo Zhou, 2012-04-06 21:14:27]

On 2012/04/06 20:53:39, rsesek wrote:
>
http://codereview.chromium.org/10012033/diff/2001/chrome/browser/extensions/e...
> File chrome/browser/extensions/extension_disabled_ui.cc (right):
> 
>
http://codereview.chromium.org/10012033/diff/2001/chrome/browser/extensions/e...
> chrome/browser/extensions/extension_disabled_ui.cc:255:
> base::Unretained(uninstall_dialog_.get()), extension_));
> On 2012/04/06 19:10:45, Yoyo Zhou wrote:
> > On 2012/04/06 14:15:07, rsesek wrote:
> > > Is Unretained safe here?
> > 
> > This object isn't getting deleted unless the extension is reloaded or
> > uninstalled in the meantime, which seems unlikely, but I suppose we could
make
> > the uninstall dialog refcounted if you're worrieda bout that.
> 
> You could use a WeakPtrFactory<T> instead.

That seems appropriate (well, SupportsWeakPtr<T>). I changed it to use that.

[Robert Sesek, 2012-04-06 22:02:07]

lgtm

[jstritar, 2012-04-06 22:05:13]

lgtm

https://chromiumcodereview.appspot.com/10012033/diff/5/chrome/browser/extensi...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

https://chromiumcodereview.appspot.com/10012033/diff/5/chrome/browser/extensi...
chrome/browser/extensions/extension_disabled_ui.cc:253:
MessageLoop::current()->PostTask(FROM_HERE,
Can you add a little comment above this, since it's pretty obscure?

[Yoyo Zhou, 2012-04-06 22:12:02]

https://chromiumcodereview.appspot.com/10012033/diff/5/chrome/browser/extensi...
File chrome/browser/extensions/extension_disabled_ui.cc (right):

https://chromiumcodereview.appspot.com/10012033/diff/5/chrome/browser/extensi...
chrome/browser/extensions/extension_disabled_ui.cc:253:
MessageLoop::current()->PostTask(FROM_HERE,
On 2012/04/06 22:05:13, jstritar wrote:
> Can you add a little comment above this, since it's pretty obscure?

Done.