Issue 10054038: Support WebView in ash.

Issue 10054038: Support WebView in ash. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)

Modified:
8 years, 8 months ago

Reviewers:
jam, sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Support WebView in ash. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132063

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1073 lines, -107 lines)			Patch
M	ash/ash.gyp	View	1 2	3 chunks	+19 lines, -0 lines	0 comments	Download
M	ash/shell.h	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download
A	ash/shell/DEPS	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/shell/app_list.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	ash/shell/content_client/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	ash/shell/content_client/shell_browser_main_parts.h	View	1 2	1 chunk	+77 lines, -0 lines	0 comments	Download
A	ash/shell/content_client/shell_browser_main_parts.cc	View	1	1 chunk	+120 lines, -0 lines	0 comments	Download
A	ash/shell/content_client/shell_content_browser_client.h	View		1 chunk	+210 lines, -0 lines	0 comments	Download
A	ash/shell/content_client/shell_content_browser_client.cc	View	1	1 chunk	+373 lines, -0 lines	0 comments	Download
A	ash/shell/content_client/shell_main_delegate.h	View		1 chunk	+64 lines, -0 lines	0 comments	Download
A	ash/shell/content_client/shell_main_delegate.cc	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
M	ash/shell/shell_main.cc	View	1	1 chunk	+18 lines, -96 lines	0 comments	Download
M	ash/shell/window_type_launcher.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/content_shell.gypi	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/shell/shell.h	View	1 2	4 chunks	+6 lines, -6 lines	0 comments	Download
M	content/shell/shell.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	content/shell/shell_aura.cc	View	1 2	1 chunk	+44 lines, -0 lines	0 comments	Download
M	content/shell/shell_download_manager_delegate.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/examples/examples_main.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10054038/diff/7001/ash/ash.gyp File ash/ash.gyp (right): http://codereview.chromium.org/10054038/diff/7001/ash/ash.gyp#newcode440 ash/ash.gyp:440: '../content/app/startup_helper_win.cc', nit: put at end with other relative ...

8 years, 8 months ago (2012-04-12 19:14:54 UTC) #2

commit-bot: I haz the power

8 years, 8 months ago (2012-04-12 20:26:20 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10054038/12001

Expand Messages | Collapse Messages