Issue 10073014: Add more functionality to WebView.

Issue 10073014: Add more functionality to WebView. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)

Modified:
8 years, 8 months ago

Reviewers:
Avi (use Gerrit), Elliot Glaysher, sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add more functionality to WebView. - Ability for WebContents to be replaced. - Various focus/destruction observers. - Hook up to BrowserView, replacing TabContentsContainer. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132614

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+276 lines, -95 lines)			Patch
M	chrome/browser/autofill/autofill_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_focus_uitest.cc	View	1 2	15 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/browser_keyevents_browsertest.cc	View	1 2	14 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm	View	1 2 3	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/tab_contents_container_gtk.cc	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/view_id_util.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/view_ids.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_interactive_uitest.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2	10 chunks	+16 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_view_mac.mm	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/browser/web_contents_view_delegate.h	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/views/controls/webview/webview.h	View	1 2	1 chunk	+55 lines, -5 lines	0 comments	Download
M	ui/views/controls/webview/webview.cc	View	1 2	3 chunks	+162 lines, -9 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/10073014/diff/1/ui/views/controls/webview/webview.cc File ui/views/controls/webview/webview.cc (right): http://codereview.chromium.org/10073014/diff/1/ui/views/controls/webview/webview.cc#newcode36 ui/views/controls/webview/webview.cc:36: if (!web_contents_) { I don't think this works quite ...

8 years, 8 months ago (2012-04-13 19:19:08 UTC) #2

Ben Goodger (Google)

I had to deprecate VIEW_ID_TAB_CONTAINER_FOCUS_VIEW completely to calm tests on all platforms. Avi: *.mm Erg: ...

8 years, 8 months ago (2012-04-17 15:55:56 UTC) #5

Avi (use Gerrit)

http://codereview.chromium.org/10073014/diff/19004/chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm File chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm (right): http://codereview.chromium.org/10073014/diff/19004/chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm#newcode10 chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm:10: #import "chrome/browser/ui/cocoa/view_id_util.h" This is no longer needed. http://codereview.chromium.org/10073014/diff/19004/chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm#newcode63 chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm:63: ...

8 years, 8 months ago (2012-04-17 16:33:46 UTC) #6

Ben Goodger (Google)

Updated, see also changes to content now, and the header file for the chrome web ...

8 years, 8 months ago (2012-04-17 16:43:18 UTC) #7

Avi (use Gerrit)

mac-n-cheese... er... mac-n-content LGTM Good to see stuff go away.

8 years, 8 months ago (2012-04-17 16:57:03 UTC) #8

gtk lgtm

Expand Messages | Collapse Messages