Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 10118003: Death to TCVV! (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1767 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -22 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_delegate_aura.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_delegate_aura.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc View 1 chunk +0 lines, -425 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_delegate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 1 chunk +0 lines, -342 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 chunk +0 lines, -428 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ben Goodger (Google)
8 years, 8 months ago (2012-04-17 23:54:55 UTC) #1
jam
lgtm please also update chrome/browser/DEPS
8 years, 8 months ago (2012-04-17 23:56:36 UTC) #2
Ben Goodger (Google)
Done!
8 years, 8 months ago (2012-04-18 00:02:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10118003/9002
8 years, 8 months ago (2012-04-18 00:02:13 UTC) #4
jam
btw i added BUG=98716 to this change also looks like this change won't land since ...
8 years, 8 months ago (2012-04-18 00:21:41 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-18 00:35:42 UTC) #6
Try job failure for 10118003-9002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698