Issue 10173030: User Gesture plumbed from Renderer to Browser's FullscreenController::RequestToLockMouse.

Issue 10173030: User Gesture plumbed from Renderer to Browser's FullscreenController::RequestToLockMouse. (Closed)

Created:
8 years, 8 months ago by scheib

Modified:
8 years, 8 months ago

Reviewers:
jam, yzshen1, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

User Gesture plumbed from Renderer to Browser's FullscreenController::RequestToLockMouse. Part of a larger set of patches refactoring FullscreenController to support mouse lock in windowed (not fullscreen) mode. [email protected] BUG=107320 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134113

Patch Set 1 #

Total comments: 3

Patch Set 2 : yzshen nits fixed. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -27 lines)			Patch
M	chrome/browser/ui/browser.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/fullscreen_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/fullscreen_controller.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/view_messages.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/public/browser/render_view_host_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/mouse_lock_dispatcher.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yzshen1

lgtm https://chromiumcodereview.appspot.com/10173030/diff/1/chrome/browser/ui/fullscreen_controller.cc File chrome/browser/ui/fullscreen_controller.cc (right): https://chromiumcodereview.appspot.com/10173030/diff/1/chrome/browser/ui/fullscreen_controller.cc#newcode63 chrome/browser/ui/fullscreen_controller.cc:63: bool /* user_gesture */) { One space after ...

8 years, 8 months ago (2012-04-25 23:24:36 UTC) #2

scheib

Owners review please jam /content/... sky /chrome/browser/ui/

8 years, 8 months ago (2012-04-25 23:45:26 UTC) #3

LGTM

Expand Messages | Collapse Messages