Issue 10317014: Move Command class out of the Extension class and into its own location (under chrome/common/exten…

Issue 10317014: Move Command class out of the Extension class and into its own location (under chrome/common/exten… (Closed)

Created:
8 years, 7 months ago by Finnur

Modified:
8 years, 7 months ago

Reviewers:
Jói

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move Command class out of the Extension class and into its own location (under chrome/common/extensions). BUG=None TEST=None (No functional change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135334

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+503 lines, -440 lines)			Patch
M	chrome/browser/extensions/api/commands/extension_command_service.h	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/commands/extension_command_service.cc	View		8 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_installed_bubble.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/page_action_image_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		4 chunks	+7 lines, -39 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		2 chunks	+1 line, -198 lines	0 comments	Download
A	chrome/common/extensions/extension_commands.h	View		1 chunk	+56 lines, -0 lines	1 comment	Download
A	chrome/common/extensions/extension_commands.cc	View		1 chunk	+218 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/extension_commands_unittest.cc	View		1 chunk	+186 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View		1 chunk	+0 lines, -173 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

8 years, 7 months ago (2012-05-04 13:26:40 UTC) #2

LGTM with a nit

https://chromiumcodereview.appspot.com/10317014/diff/11003/chrome/common/exte...
File chrome/common/extensions/extension_commands.h (right):

https://chromiumcodereview.appspot.com/10317014/diff/11003/chrome/common/exte...
chrome/common/extensions/extension_commands.h:54: }
I think our coding standard says this should should be:

}  // namespace extensions

Expand Messages | Collapse Messages