Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10332124: browser: Move the tabs directory into ui. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, marja+watch_chromium.org, yoshiki+watch_chromium.org, ben+watch_chromium.org, kkania, Dmitry Titov, dcheng, Aaron Boodman, rginda+watch_chromium.org, jennb, robertshield, jianli, darin-cc_chromium.org, James Su, stevenjb+watch_chromium.org, Andrei, davemoore+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -6842 lines) Patch
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/oom_priority_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_install_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/base_setting_change.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/session_startup_change.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/tabs/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_codec.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_codec.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_codec_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_service.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_service.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_service_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_service_factory.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_service_unittest.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_test_utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/tabs/pinned_tab_test_utils.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/tabs/tab_finder.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/tabs/tab_finder.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model.h View 1 chunk +0 lines, -693 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model.cc View 1 chunk +0 lines, -1353 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model_delegate.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model_observer.h View 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model_observer.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model_order_controller.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model_order_controller.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/tabs/tab_strip_model_unittest.cc View 1 chunk +0 lines, -2449 lines 0 comments Download
D chrome/browser/tabs/tab_strip_selection_model.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/tabs/tab_strip_selection_model.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/tabs/tab_strip_selection_model_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D chrome/browser/tabs/test_tab_strip_model_delegate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/tabs/test_tab_strip_model_delegate.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller_target.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/drag_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/hover_tab_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_codec.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_codec.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_codec_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_service.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_service_factory.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_service_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_test_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/pinned_tab_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_finder.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model_order_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model_order_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_selection_model.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_selection_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/tab_strip_selection_model_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/tabs/test_tab_strip_model_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/tabs/test_tab_strip_model_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +17 lines, -19 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
.
8 years, 7 months ago (2012-05-11 20:30:03 UTC) #1
tfarina
8 years, 7 months ago (2012-05-11 20:33:32 UTC) #2
Ben Goodger (Google)
8 years, 7 months ago (2012-05-11 20:40:29 UTC) #3 
rubber stamp lgtm

Powered by Google App Engine
This is Rietveld 408576698