Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 10332164: Add CreateFileWriter method to MountPointProvider. (Closed)

Created:
8 years, 7 months ago by kinaba
Modified:
8 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, Ben Chan, zel, satorux1
Visibility:
Public.

Description

Add CreateFileWriter method to MountPointProvider. In this patch, just adding an interface. Concrete implementations that return appropriate FileWriter subclass instances are on the way. BUG=123993 TEST=check it compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137363

Patch Set 1 #

Total comments: 2

Patch Set 2 : Working impl for IsolatedMountPointProvider. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -12 lines) Patch
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 2 chunks +11 lines, -0 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 3 chunks +24 lines, -12 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
Kinuko-san, could you take a look?
8 years, 7 months ago (2012-05-15 05:00:16 UTC) #1
kinuko
lgtm http://codereview.chromium.org/10332164/diff/1/webkit/fileapi/isolated_mount_point_provider.cc File webkit/fileapi/isolated_mount_point_provider.cc (right): http://codereview.chromium.org/10332164/diff/1/webkit/fileapi/isolated_mount_point_provider.cc#newcode127 webkit/fileapi/isolated_mount_point_provider.cc:127: // TODO(kinaba,kinuko): return SandboxFileWriter when it is implemented. ...
8 years, 7 months ago (2012-05-15 06:51:21 UTC) #2
kinaba
Thanks, Implemented for IsolatedFS in the current CL. http://codereview.chromium.org/10332164/diff/1/webkit/fileapi/isolated_mount_point_provider.cc File webkit/fileapi/isolated_mount_point_provider.cc (right): http://codereview.chromium.org/10332164/diff/1/webkit/fileapi/isolated_mount_point_provider.cc#newcode127 webkit/fileapi/isolated_mount_point_provider.cc:127: // ...
8 years, 7 months ago (2012-05-15 07:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10332164/6001
8 years, 7 months ago (2012-05-16 03:21:39 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 04:42:04 UTC) #5
Change committed as 137363

Powered by Google App Engine
This is Rietveld 408576698