Make the page action space show extensions with active content scripts or

Make the page action space show extensions with active content scripts or
executed script when the action box is enabled.

This is platform independent but will only work on GTK until cocoa and views
have been updated to use the ActionBoxController interface.


BUG=127988
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138021

[Matt Perry, 2012-05-18 19:31:31]

lgtm

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
File chrome/browser/extensions/page_action_controller.cc (right):

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
chrome/browser/extensions/page_action_controller.cc:57: case 2: // middle
2 spaces before comments

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
File chrome/browser/extensions/script_badge_controller.cc (right):

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
chrome/browser/extensions/script_badge_controller.cc:95: std::map<std::string,
linked_ptr<ExtensionAction> >::iterator existing =
typedefing the map in the header would make this a little cleaner

[not at google - send to devlin, 2012-05-18 22:51:27]

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
File chrome/browser/extensions/page_action_controller.cc (right):

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
chrome/browser/extensions/page_action_controller.cc:57: case 2: // middle
On 2012/05/18 19:31:31, Matt Perry wrote:
> 2 spaces before comments

Done.

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
File chrome/browser/extensions/script_badge_controller.cc (right):

https://chromiumcodereview.appspot.com/10332235/diff/5001/chrome/browser/exte...
chrome/browser/extensions/script_badge_controller.cc:95: std::map<std::string,
linked_ptr<ExtensionAction> >::iterator existing =
On 2012/05/18 19:31:31, Matt Perry wrote:
> typedefing the map in the header would make this a little cleaner

Done.

[commit-bot: I haz the power, 2012-05-18 22:58:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10332235/7002

[commit-bot: I haz the power, 2012-05-18 23:24:50]

Try job failure for 10332235-7002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-05-19 01:10:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10332235/12001

[commit-bot: I haz the power, 2012-05-19 03:51:13]

Change committed as 138021