Issue 10369003: Renames some of the launcher classes to better mirror what they do and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10369003: Renames some of the launcher classes to better mirror what they do and (Closed)

Created:
8 years, 7 months ago by sky

Modified:
8 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Renames some of the launcher classes to better mirror what they do and are responsible for. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135288

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+302 lines, -1812 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ash/app_list/extension_app_item.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ash/chrome_shell_delegate.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.h	View		7 chunks	+24 lines, -23 lines	0 comments	Download
A +	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.cc	View		7 chunks	+35 lines, -31 lines	0 comments	Download
A +	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller_unittest.cc	View		18 chunks	+43 lines, -40 lines	0 comments	Download
A +	chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.h	View	1	8 chunks	+31 lines, -30 lines	0 comments	Download
A +	chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc	View	1	27 chunks	+93 lines, -85 lines	0 comments	Download
D	chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h	View	1	1 chunk	+0 lines, -247 lines	0 comments	Download
D	chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc	View	1	1 chunk	+0 lines, -613 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_context_menu.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc	View		4 chunks	+21 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
D	chrome/browser/ui/views/ash/launcher/launcher_updater.h	View		1 chunk	+0 lines, -137 lines	0 comments	Download
D	chrome/browser/ui/views/ash/launcher/launcher_updater.cc	View		1 chunk	+0 lines, -182 lines	0 comments	Download
D	chrome/browser/ui/views/ash/launcher/launcher_updater_unittest.cc	View		1 chunk	+0 lines, -356 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages