Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10386069: Add RegisterMountPointProvider and TestMountPointProvider for testing (Closed)

Created:
8 years, 7 months ago by kinuko
Modified:
8 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, ericu, kinaba
Visibility:
Public.

Description

Add RegisterMountPointProvider and TestMountPointProvider for testing BUG=none TEST=none, I'll convert some tests to use it once it's submitted Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136551

Patch Set 1 #

Total comments: 16

Patch Set 2 : adding sandbox_mpp change #

Total comments: 2

Patch Set 3 : fixing #

Patch Set 4 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -23 lines) Patch
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_context.cc View 5 chunks +20 lines, -7 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_operation.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_util.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_types.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_util.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A + webkit/fileapi/test_mount_point_provider.h View 1 2 3 2 chunks +23 lines, -12 lines 0 comments Download
A webkit/fileapi/test_mount_point_provider.cc View 1 2 3 1 chunk +165 lines, -0 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
8 years, 7 months ago (2012-05-10 07:32:18 UTC) #1
tzik
lgtm http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_context.h File webkit/fileapi/file_system_context.h (right): http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_context.h#newcode12 webkit/fileapi/file_system_context.h:12: #include "base/file_path.h" Forward declaration looks still enough. Could ...
8 years, 7 months ago (2012-05-10 08:31:00 UTC) #2
kinuko
8 years, 7 months ago (2012-05-11 06:59:34 UTC) #3 
http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_con...
File webkit/fileapi/file_system_context.h (right):

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_con...
webkit/fileapi/file_system_context.h:12: #include "base/file_path.h"
On 2012/05/10 08:31:00, tzik wrote:
> Forward declaration looks still enough.
> Could we remove it?

Done.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_mou...
File webkit/fileapi/file_system_mount_point_provider.h (right):

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_mou...
webkit/fileapi/file_system_mount_point_provider.h:27: class FileSystemQuotaUtil;
On 2012/05/10 08:31:00, tzik wrote:
> sort?

Done.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_ope...
File webkit/fileapi/file_system_operation.h (right):

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/file_system_ope...
webkit/fileapi/file_system_operation.h:133:
FileSystemOperation(FileSystemContext* file_system_context);
On 2012/05/10 08:31:00, tzik wrote:
> need explicit?

Done.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
File webkit/fileapi/test_mount_point_provider.cc (right):

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
webkit/fileapi/test_mount_point_provider.cc:24:
TestFileSystemQuotaUtil(base::SequencedTaskRunner* task_runner)
On 2012/05/10 08:31:00, tzik wrote:
> need explicit?

Done.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
webkit/fileapi/test_mount_point_provider.cc:67: usage_ = 0;
On 2012/05/10 08:31:00, tzik wrote:
> This method should not reset usage.
> Could you leave usage as is, or place NOTREACHED()?

Done.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
webkit/fileapi/test_mount_point_provider.cc:102: DCHECK_EQ(kFileSystemTypeTest,
type);
On 2012/05/10 08:31:00, tzik wrote:
> Maybe, we should check if the directory exists, and should return empty path
if
> !create && !exists.

Done.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
webkit/fileapi/test_mount_point_provider.cc:119: return 
std::vector<FilePath>();
On 2012/05/10 08:31:00, tzik wrote:
> extra space?

Fixed.

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
File webkit/fileapi/test_mount_point_provider.h (right):

http://codereview.chromium.org/10386069/diff/1/webkit/fileapi/test_mount_poin...
webkit/fileapi/test_mount_point_provider.h:11: #include
"base/memory/ref_counted.h"
On 2012/05/10 08:31:00, tzik wrote:
> sort?

Done.

http://codereview.chromium.org/10386069/diff/2001/webkit/fileapi/test_mount_p...
File webkit/fileapi/test_mount_point_provider.cc (right):

http://codereview.chromium.org/10386069/diff/2001/webkit/fileapi/test_mount_p...
webkit/fileapi/test_mount_point_provider.cc:6: 
On 2012/05/10 08:31:00, tzik wrote:
> add #include <set> and #include <string> for lint.

Done.

Powered by Google App Engine
This is Rietveld 408576698