Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 10411082: Simplify BufferedSocketWriter by making it non-thread-safe. (Closed)

Created:
8 years, 7 months ago by Sergey Ulanov
Modified:
8 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Simplify BufferedSocketWriter by making it non-thread-safe. Originally BufferedSocketWriter was implemented to be thread-safe, so that any thread can call Write() method. We don't write any data from other threads anymore, so there is no need to keep it thread-safe. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138694

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -113 lines) Patch
M remoting/protocol/buffered_socket_writer.h View 1 2 6 chunks +17 lines, -32 lines 0 comments Download
M remoting/protocol/buffered_socket_writer.cc View 1 12 chunks +30 lines, -45 lines 0 comments Download
M remoting/protocol/client_control_dispatcher.h View 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/client_control_dispatcher.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download
M remoting/protocol/client_event_dispatcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/client_event_dispatcher.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M remoting/protocol/host_control_dispatcher.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/host_control_dispatcher.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M remoting/protocol/protobuf_video_writer.h View 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/protobuf_video_writer.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
8 years, 7 months ago (2012-05-22 23:39:10 UTC) #1
Alpha Left Google
LGTM with 2 nits. http://codereview.chromium.org/10411082/diff/2001/remoting/protocol/buffered_socket_writer.h File remoting/protocol/buffered_socket_writer.h (right): http://codereview.chromium.org/10411082/diff/2001/remoting/protocol/buffered_socket_writer.h#newcode36 remoting/protocol/buffered_socket_writer.h:36: explicit BufferedSocketWriterBase(); No need to ...
8 years, 7 months ago (2012-05-23 20:28:37 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/10411082/diff/2001/remoting/protocol/buffered_socket_writer.h File remoting/protocol/buffered_socket_writer.h (right): http://codereview.chromium.org/10411082/diff/2001/remoting/protocol/buffered_socket_writer.h#newcode36 remoting/protocol/buffered_socket_writer.h:36: explicit BufferedSocketWriterBase(); On 2012/05/23 20:28:37, Alpha wrote: > No ...
8 years, 7 months ago (2012-05-23 22:29:00 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 22:30:37 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698