Pass user gesture indicator for RPH and intents.

Pass user gesture indicator for RPH and intents.

We are moving to a policy which will change where we show
RPH and web intents registrations between infobar and page-action
type indicator depending on factors like user gesture, previous
showing of the infobar, and perhaps other considerations. This
change gets that user gesture indicator to the policy logic.

It also incorporates a change to the web intents registration IPC
to pass the service info struct instead of individual members. (Adding
the user gesture went over the param limit, and passing the struct
is a good change regardless.)

[email protected],[email protected]
BUG=119438
TEST=*WebIntent*.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139996

[jam, 2012-05-29 16:53:40]

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
File chrome/browser/external_tab/external_tab_container_win.cc (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
chrome/browser/external_tab/external_tab_container_win.cc:746: const
webkit_glue::WebIntentServiceData& data,
nit: user_gesture and 80 chars

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
File chrome/browser/external_tab/external_tab_container_win.h (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
chrome/browser/external_tab/external_tab_container_win.h:183: bool userGesture)
OVERRIDE;
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
File chrome/browser/intents/register_intent_handler_helper.cc (left):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
chrome/browser/intents/register_intent_handler_helper.cc:37: // |href| can be
relative to originating URL. Resolve if necessary.
this code isn't needed anymore?

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
File chrome/browser/intents/register_intent_handler_helper.cc (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
chrome/browser/intents/register_intent_handler_helper.cc:23: bool userGesture) {
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc#n...
chrome/browser/ui/browser.cc:2237: bool userGesture) {
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc#n...
chrome/browser/ui/browser.cc:3602: bool userGesture) {
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc#n...
chrome/browser/ui/browser.cc:3607: const webkit_glue::WebIntentServiceData&
data,
nit: 80 chars and user_gesture

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.h#ne...
chrome/browser/ui/browser.h:658: const webkit_glue::WebIntentServiceData& data,
nit: user_gesture and 80 chars. also above and below

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_impl.cc (right):

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.cc:1739: bool userGesture) {
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.cc:2042: bool userGesture) {
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_impl.h (right):

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.h:466: bool userGesture);
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.h:498: bool userGesture);
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/common/intents_messages.h
File content/common/intents_messages.h (right):

http://codereview.chromium.org/10447067/diff/1/content/common/intents_message...
content/common/intents_messages.h:67: bool /* userGesture */)
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

http://codereview.chromium.org/10447067/diff/1/content/common/view_messages.h...
content/common/view_messages.h:2026: bool /* userGesture */)
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/public/browser/web_con...
File content/public/browser/web_contents_delegate.h (right):

http://codereview.chromium.org/10447067/diff/1/content/public/browser/web_con...
content/public/browser/web_contents_delegate.h:358: const
webkit_glue::WebIntentServiceData& data,
nit: 80 chars...

http://codereview.chromium.org/10447067/diff/1/content/public/browser/web_con...
content/public/browser/web_contents_delegate.h:359: bool userGesture) {}
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/content/renderer/render_view_i...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/10447067/diff/1/content/renderer/render_view_i...
content/renderer/render_view_impl.cc:5440: bool userGesture =
(webview()->focusedFrame() &&
nit: user_gesture

http://codereview.chromium.org/10447067/diff/1/webkit/glue/web_intent_service...
File webkit/glue/web_intent_service_data.h (right):

http://codereview.chromium.org/10447067/diff/1/webkit/glue/web_intent_service...
webkit/glue/web_intent_service_data.h:12: #include <iosfwd>
nit: this needs to be at the top per the styleguide

http://codereview.chromium.org/10447067/diff/1/webkit/glue/web_intent_service...
webkit/glue/web_intent_service_data.h:33: WebIntentServiceData(const
WebKit::WebIntentServiceInfo& info);
nit: explicit

[Greg Billock, 2012-05-29 17:09:07]

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
File chrome/browser/external_tab/external_tab_container_win.cc (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
chrome/browser/external_tab/external_tab_container_win.cc:746: const
webkit_glue::WebIntentServiceData& data,
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture and 80 chars

Done.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
File chrome/browser/external_tab/external_tab_container_win.h (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/external_tab/ex...
chrome/browser/external_tab/external_tab_container_win.h:183: bool userGesture)
OVERRIDE;
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Oh, drat. I had it in my mental queue to change all these before uploading, but
with the long weekend I forgot. :-( Sorry about that.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
File chrome/browser/intents/register_intent_handler_helper.cc (left):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
chrome/browser/intents/register_intent_handler_helper.cc:37: // |href| can be
relative to originating URL. Resolve if necessary.
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> this code isn't needed anymore?

No. The incoming object now does this resolution within webkit, so the code is
dead. The conversion to the struct is also done upstream now.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
File chrome/browser/intents/register_intent_handler_helper.cc (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/intents/registe...
chrome/browser/intents/register_intent_handler_helper.cc:23: bool userGesture) {
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc#n...
chrome/browser/ui/browser.cc:2237: bool userGesture) {
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc#n...
chrome/browser/ui/browser.cc:3602: bool userGesture) {
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.cc#n...
chrome/browser/ui/browser.cc:3607: const webkit_glue::WebIntentServiceData&
data,
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: 80 chars and user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/10447067/diff/1/chrome/browser/ui/browser.h#ne...
chrome/browser/ui/browser.h:658: const webkit_glue::WebIntentServiceData& data,
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture and 80 chars. also above and below

Done.

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_impl.cc (right):

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.cc:1739: bool userGesture) {
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.cc:2042: bool userGesture) {
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_impl.h (right):

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.h:466: bool userGesture);
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.h:498: bool userGesture);
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/common/intents_messages.h
File content/common/intents_messages.h (right):

http://codereview.chromium.org/10447067/diff/1/content/common/intents_message...
content/common/intents_messages.h:67: bool /* userGesture */)
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

http://codereview.chromium.org/10447067/diff/1/content/common/view_messages.h...
content/common/view_messages.h:2026: bool /* userGesture */)
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/public/browser/web_con...
File content/public/browser/web_contents_delegate.h (right):

http://codereview.chromium.org/10447067/diff/1/content/public/browser/web_con...
content/public/browser/web_contents_delegate.h:358: const
webkit_glue::WebIntentServiceData& data,
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: 80 chars...

Done.

http://codereview.chromium.org/10447067/diff/1/content/public/browser/web_con...
content/public/browser/web_contents_delegate.h:359: bool userGesture) {}
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/content/renderer/render_view_i...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/10447067/diff/1/content/renderer/render_view_i...
content/renderer/render_view_impl.cc:5440: bool userGesture =
(webview()->focusedFrame() &&
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: user_gesture

Done.

http://codereview.chromium.org/10447067/diff/1/webkit/glue/web_intent_service...
File webkit/glue/web_intent_service_data.h (right):

http://codereview.chromium.org/10447067/diff/1/webkit/glue/web_intent_service...
webkit/glue/web_intent_service_data.h:12: #include <iosfwd>
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: this needs to be at the top per the styleguide

Done.

http://codereview.chromium.org/10447067/diff/1/webkit/glue/web_intent_service...
webkit/glue/web_intent_service_data.h:33: WebIntentServiceData(const
WebKit::WebIntentServiceInfo& info);
On 2012/05/29 16:53:40, John Abd-El-Malek wrote:
> nit: explicit

Done.

[groby-ooo-7-16, 2012-05-30 01:07:13]

I'd argue that it'd be even better to have an enum instead a bool for
user_gesture, but the style guide is sufficiently vague on when that's necessary
that I won't insist :)

It'd probably good to at least rename user_gesture to user_gesture_initiated, to
make clearer what it does.

But that's a nit, so lgtm

http://codereview.chromium.org/10447067/diff/9001/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/10447067/diff/9001/chrome/browser/ui/browser.h...
chrome/browser/ui/browser.h:657: static void RegisterIntentHandlerHelper(
nit: Can you document params? (Specifically, user_gesture?)

http://codereview.chromium.org/10447067/diff/9001/content/public/browser/web_...
File content/public/browser/web_contents_delegate.h (right):

http://codereview.chromium.org/10447067/diff/9001/content/public/browser/web_...
content/public/browser/web_contents_delegate.h:360: bool user_gesture) {}
nit: Document user_gesture (here and elsewhere)

[jam, 2012-05-30 02:01:22]

lgtm

[Greg Billock, 2012-05-30 17:45:21]

http://codereview.chromium.org/10447067/diff/9001/chrome/browser/ui/browser.h
File chrome/browser/ui/browser.h (right):

http://codereview.chromium.org/10447067/diff/9001/chrome/browser/ui/browser.h...
chrome/browser/ui/browser.h:657: static void RegisterIntentHandlerHelper(
On 2012/05/30 01:07:13, groby wrote:
> nit: Can you document params? (Specifically, user_gesture?)

Done.

http://codereview.chromium.org/10447067/diff/9001/content/public/browser/web_...
File content/public/browser/web_contents_delegate.h (right):

http://codereview.chromium.org/10447067/diff/9001/content/public/browser/web_...
content/public/browser/web_contents_delegate.h:360: bool user_gesture) {}
On 2012/05/30 01:07:13, groby wrote:
> nit: Document user_gesture (here and elsewhere)

Done.

[Greg Billock, 2012-05-30 17:47:11]

On 2012/05/30 17:45:21, Greg Billock wrote:
> http://codereview.chromium.org/10447067/diff/9001/chrome/browser/ui/browser.h
> File chrome/browser/ui/browser.h (right):
> 
>
http://codereview.chromium.org/10447067/diff/9001/chrome/browser/ui/browser.h...
> chrome/browser/ui/browser.h:657: static void RegisterIntentHandlerHelper(
> On 2012/05/30 01:07:13, groby wrote:
> > nit: Can you document params? (Specifically, user_gesture?)
> 
> Done.
> 
>
http://codereview.chromium.org/10447067/diff/9001/content/public/browser/web_...
> File content/public/browser/web_contents_delegate.h (right):
> 
>
http://codereview.chromium.org/10447067/diff/9001/content/public/browser/web_...
> content/public/browser/web_contents_delegate.h:360: bool user_gesture) {}
> On 2012/05/30 01:07:13, groby wrote:
> > nit: Document user_gesture (here and elsewhere)
> 
> Done.

Darin, Peter, can I get an OWNERS look for webkit/* and chome/browser/ui/* ?

[Peter Kasting, 2012-05-31 01:43:14]

chrome/browser/ui LGTM

[darin (slow to review), 2012-05-31 21:01:17]

LGTM for src/webkit

http://codereview.chromium.org/10447067/diff/1021/webkit/glue/web_intent_serv...
File webkit/glue/web_intent_service_data.h (right):

http://codereview.chromium.org/10447067/diff/1021/webkit/glue/web_intent_serv...
webkit/glue/web_intent_service_data.h:9: #include <iosfwd>
nit: insert new line between system includes and non-system includes:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_...

[Greg Billock, 2012-05-31 21:27:27]

http://codereview.chromium.org/10447067/diff/1021/webkit/glue/web_intent_serv...
File webkit/glue/web_intent_service_data.h (right):

http://codereview.chromium.org/10447067/diff/1021/webkit/glue/web_intent_serv...
webkit/glue/web_intent_service_data.h:9: #include <iosfwd>
On 2012/05/31 21:01:17, darin wrote:
> nit: insert new line between system includes and non-system includes:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_...

Done.

[commit-bot: I haz the power, 2012-05-31 21:28:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10447067/35

[commit-bot: I haz the power, 2012-05-31 23:08:31]

Try job failure for 10447067-35 (retry) (previous was lost) on win_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-31 23:14:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10447067/35

[commit-bot: I haz the power, 2012-06-01 04:13:47]

Try job failure for 10447067-35 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-01 04:25:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10447067/35

[commit-bot: I haz the power, 2012-06-01 08:38:41]

Change committed as 139996