Issue 10536012: Reland r124453. The change was reverted in 140030 to be merged with M20.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536012: Reland r124453. The change was reverted in 140030 to be merged with M20. (Closed)

Created:
8 years, 6 months ago by sadrul

Modified:
8 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, Fady Samuel, varunjain

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland r124453. The change was reverted in 140030 to be merged with M20. Original CL: --- WebWidgetClient::screenInfo() no longer does a synchronous IPC. Instead it grabs the necessary info from a cached WebScreenInfo factory. BUG=111401 TEST=Manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140691

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -46 lines)			Patch
M	content/browser/renderer_host/render_message_filter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter_win.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	content/common/view_messages.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_channel_manager.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	5 chunks	+6 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	content/renderer/render_widget.cc	View	4 chunks	+6 lines, -15 lines	0 comments	Download
M	content/renderer/render_widget_fullscreen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/render_view_test.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sadrul

Review of the original CL at: http://codereview.chromium.org/9302022

8 years, 6 months ago (2012-06-05 19:43:33 UTC) #1

lgtm