Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 10536044: More prep for CORS support in WebKit/chromium. (Closed)

Created:
8 years, 6 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

More prep for CORS support in WebKit/chromium. BUG=123369 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140949

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M webkit/media/android/webmediaplayer_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/media/buffered_data_source.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/media/buffered_data_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/media/buffered_resource_loader.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/media/buffered_resource_loader.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_proxy.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ami GONE FROM CHROMIUM
This is needed to support the latest patch in http://webk.it/88349
8 years, 6 months ago (2012-06-07 00:07:29 UTC) #1
Ami GONE FROM CHROMIUM
If LGTY, please check the CQ box.
8 years, 6 months ago (2012-06-07 00:16:21 UTC) #2
scherkus (not reviewing)
LGTM w/ one q that might require updating docs on some methods / adding a ...
8 years, 6 months ago (2012-06-07 01:20:53 UTC) #3
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10536044/diff/1/webkit/media/buffered_resource_loader.h File webkit/media/buffered_resource_loader.h (right): https://chromiumcodereview.appspot.com/10536044/diff/1/webkit/media/buffered_resource_loader.h#newcode179 webkit/media/buffered_resource_loader.h:179: bool DidPassCORSAccessCheck() const; On 2012/06/07 01:20:53, scherkus wrote: > ...
8 years, 6 months ago (2012-06-07 01:36:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10536044/6001
8 years, 6 months ago (2012-06-07 01:37:39 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-07 04:00:02 UTC) #6
Change committed as 140949

Powered by Google App Engine
This is Rietveld 408576698