aura: Drop unnecessary composites

aura: Drop unnecessary composites

During a composite pass, there are many commits that occur. The results of these commits will be visible immediately, so we can cull the scheduleComposite() calls that occur.

BUG=131059
TEST=manual: run with --force-compositing-mode; go to google.com; observe only one draw per cursor blink via chrome://tracing


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140876

[jonathan.backer, 2012-06-06 14:55:24]

A much pared down version of http://codereview.chromium.org/10453117 which
focusses on just one issue. This fix does not break aura_bench.

[jonathan.backer, 2012-06-06 20:12:01]

Based on a conversation with piman@, I've made the dropping of
Compositor::scheduleComposite() much more conservative.

[piman, 2012-06-06 20:17:24]

lgtm

http://codereview.chromium.org/10537028/diff/1009/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

http://codereview.chromium.org/10537028/diff/1009/ui/compositor/compositor.cc...
ui/compositor/compositor.cc:184: disable_schedule_composite_ = true;
nit: it's probably not useful to do this here, since it's done in layout()
anyway.

[jonathan.backer, 2012-06-06 20:31:43]

http://codereview.chromium.org/10537028/diff/1009/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

http://codereview.chromium.org/10537028/diff/1009/ui/compositor/compositor.cc...
ui/compositor/compositor.cc:184: disable_schedule_composite_ = true;
On 2012/06/06 20:17:24, piman wrote:
> nit: it's probably not useful to do this here, since it's done in layout()
> anyway.

Thanks. Tried to squeeze this in before a meeting. I shouldn't have rushed.

[jonathan.backer, 2012-06-06 21:17:07]

+sky for ui/aura OWNERS

[sky, 2012-06-06 21:25:36]

LGTM

[commit-bot: I haz the power, 2012-06-06 21:27:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10537028/1010

[commit-bot: I haz the power, 2012-06-06 23:02:11]

Change committed as 140876