Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10538031: Reland 140814 - Rename ShellRenderView{,Host}Observer to LayoutTestController{,Host} (Closed)

Created:
8 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, sadrul, jochen+watch-content_chromium.org, ben+watch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reland 140814 - Rename ShellRenderView{,Host}Observer to LayoutTestController{,Host} also hook up the stay on page after handling before unload flag. Also removing incorrect references from aura/ui code to layout test controller stuff BUG=111316 TEST=manual [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -340 lines) Patch
M ash/shell/content_client/shell_content_browser_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/shell/layout_test_controller.h View 2 chunks +8 lines, -9 lines 0 comments Download
A + content/shell/layout_test_controller.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M content/shell/layout_test_controller.js View 2 chunks +3 lines, -0 lines 0 comments Download
M content/shell/layout_test_controller_bindings.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A content/shell/layout_test_controller_host.h View 1 chunk +59 lines, -0 lines 0 comments Download
A + content/shell/layout_test_controller_host.cc View 6 chunks +38 lines, -14 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/shell_content_renderer_client.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M content/shell/shell_javascript_dialog_creator.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/shell/shell_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
D content/shell/shell_render_view_host_observer.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/shell/shell_render_view_host_observer.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D content/shell/shell_render_view_observer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/shell/shell_render_view_observer.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M ui/views/examples/content_client/examples_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
My CL got reverted because it broke ash_shell seems like ash_shell and the ui examples ...
8 years, 6 months ago (2012-06-06 21:31:53 UTC) #1
jam
lgtm
8 years, 6 months ago (2012-06-06 22:06:28 UTC) #2
jam
lgtm lgtm
8 years, 6 months ago (2012-06-06 22:06:28 UTC) #3
Ben Goodger (Google)
8 years, 6 months ago (2012-06-12 18:23:26 UTC) #4 
ash/ui LGTM

Powered by Google App Engine
This is Rietveld 408576698